// Partial Copyright Jerome Benoit. 2021-2023. All Rights Reserved.
-import fs from 'fs';
-import path from 'path';
-import { URL, fileURLToPath } from 'url';
+import fs from 'node:fs';
+import path from 'node:path';
+import { URL, fileURLToPath } from 'node:url';
import type { JSONSchemaType } from 'ajv';
import { Client, type FTPResponse } from 'basic-ftp';
import tar from 'tar';
-import OCPPError from '../../../exception/OCPPError';
-import type { JsonObject, JsonType } from '../../../types/JsonType';
-import { OCPP16ChargePointErrorCode } from '../../../types/ocpp/1.6/ChargePointErrorCode';
-import { OCPP16ChargePointStatus } from '../../../types/ocpp/1.6/ChargePointStatus';
import {
- ChargingProfilePurposeType,
- type OCPP16ChargingProfile,
-} from '../../../types/ocpp/1.6/ChargingProfile';
-import {
- OCPP16StandardParametersKey,
- OCPP16SupportedFeatureProfiles,
-} from '../../../types/ocpp/1.6/Configuration';
-import { OCPP16DiagnosticsStatus } from '../../../types/ocpp/1.6/DiagnosticsStatus';
+ type ChargingStation,
+ ChargingStationConfigurationUtils,
+ ChargingStationUtils,
+} from '../../../charging-station';
+import { OCPPError } from '../../../exception';
import {
type ChangeAvailabilityRequest,
+ type ChangeAvailabilityResponse,
type ChangeConfigurationRequest,
+ type ChangeConfigurationResponse,
type ClearChargingProfileRequest,
+ type ClearChargingProfileResponse,
+ ErrorType,
+ type GenericResponse,
type GetConfigurationRequest,
+ type GetConfigurationResponse,
type GetDiagnosticsRequest,
+ type GetDiagnosticsResponse,
+ type IncomingRequestHandler,
+ type JsonObject,
+ type JsonType,
+ OCPP16AuthorizationStatus,
+ type OCPP16AuthorizeRequest,
+ type OCPP16AuthorizeResponse,
OCPP16AvailabilityType,
type OCPP16BootNotificationRequest,
+ type OCPP16BootNotificationResponse,
+ OCPP16ChargePointErrorCode,
+ OCPP16ChargePointStatus,
+ type OCPP16ChargingProfile,
+ OCPP16ChargingProfilePurposeType,
type OCPP16ClearCacheRequest,
type OCPP16DataTransferRequest,
+ type OCPP16DataTransferResponse,
+ OCPP16DataTransferStatus,
OCPP16DataTransferVendorId,
+ OCPP16DiagnosticsStatus,
type OCPP16DiagnosticsStatusNotificationRequest,
+ type OCPP16DiagnosticsStatusNotificationResponse,
OCPP16FirmwareStatus,
type OCPP16FirmwareStatusNotificationRequest,
+ type OCPP16FirmwareStatusNotificationResponse,
type OCPP16HeartbeatRequest,
+ type OCPP16HeartbeatResponse,
OCPP16IncomingRequestCommand,
OCPP16MessageTrigger,
OCPP16RequestCommand,
+ OCPP16StandardParametersKey,
+ type OCPP16StartTransactionRequest,
+ type OCPP16StartTransactionResponse,
type OCPP16StatusNotificationRequest,
+ type OCPP16StatusNotificationResponse,
+ OCPP16StopTransactionReason,
+ OCPP16SupportedFeatureProfiles,
type OCPP16TriggerMessageRequest,
+ type OCPP16TriggerMessageResponse,
type OCPP16UpdateFirmwareRequest,
+ type OCPP16UpdateFirmwareResponse,
+ type OCPPConfigurationKey,
+ OCPPVersion,
type RemoteStartTransactionRequest,
type RemoteStopTransactionRequest,
type ResetRequest,
type SetChargingProfileRequest,
- type UnlockConnectorRequest,
-} from '../../../types/ocpp/1.6/Requests';
-import {
- type ChangeAvailabilityResponse,
- type ChangeConfigurationResponse,
- type ClearChargingProfileResponse,
- type GetConfigurationResponse,
- type GetDiagnosticsResponse,
- type OCPP16BootNotificationResponse,
- type OCPP16DataTransferResponse,
- OCPP16DataTransferStatus,
- type OCPP16DiagnosticsStatusNotificationResponse,
- type OCPP16FirmwareStatusNotificationResponse,
- type OCPP16HeartbeatResponse,
- type OCPP16StatusNotificationResponse,
- type OCPP16TriggerMessageResponse,
- type OCPP16UpdateFirmwareResponse,
type SetChargingProfileResponse,
+ type UnlockConnectorRequest,
type UnlockConnectorResponse,
-} from '../../../types/ocpp/1.6/Responses';
-import {
- OCPP16AuthorizationStatus,
- type OCPP16AuthorizeRequest,
- type OCPP16AuthorizeResponse,
- type OCPP16StartTransactionRequest,
- type OCPP16StartTransactionResponse,
- OCPP16StopTransactionReason,
-} from '../../../types/ocpp/1.6/Transaction';
-import type { OCPPConfigurationKey } from '../../../types/ocpp/Configuration';
-import { ErrorType } from '../../../types/ocpp/ErrorType';
-import { OCPPVersion } from '../../../types/ocpp/OCPPVersion';
-import type { IncomingRequestHandler } from '../../../types/ocpp/Requests';
-import type { DefaultResponse } from '../../../types/ocpp/Responses';
-import Constants from '../../../utils/Constants';
-import logger from '../../../utils/Logger';
-import Utils from '../../../utils/Utils';
-import type ChargingStation from '../../ChargingStation';
-import { ChargingStationConfigurationUtils } from '../../ChargingStationConfigurationUtils';
-import { ChargingStationUtils } from '../../ChargingStationUtils';
-import OCPPConstants from '../OCPPConstants';
-import OCPPIncomingRequestService from '../OCPPIncomingRequestService';
-import { OCPP16ServiceUtils } from './OCPP16ServiceUtils';
+} from '../../../types';
+import { Constants, Utils, logger } from '../../../utils';
+import { OCPP16ServiceUtils, OCPPConstants, OCPPIncomingRequestService } from '../internal';
const moduleName = 'OCPP16IncomingRequestService';
-export default class OCPP16IncomingRequestService extends OCPPIncomingRequestService {
+export class OCPP16IncomingRequestService extends OCPPIncomingRequestService {
protected jsonSchemas: Map<OCPP16IncomingRequestCommand, JSONSchemaType<JsonObject>>;
private incomingRequestHandlers: Map<OCPP16IncomingRequestCommand, IncomingRequestHandler>;
this.jsonSchemas = new Map<OCPP16IncomingRequestCommand, JSONSchemaType<JsonObject>>([
[
OCPP16IncomingRequestCommand.RESET,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/Reset.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<ResetRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<ResetRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/Reset.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.CLEAR_CACHE,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/ClearCache.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<OCPP16ClearCacheRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<OCPP16ClearCacheRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/ClearCache.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.UNLOCK_CONNECTOR,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/UnlockConnector.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<UnlockConnectorRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<UnlockConnectorRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/UnlockConnector.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.GET_CONFIGURATION,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/GetConfiguration.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<GetConfigurationRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<GetConfigurationRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/GetConfiguration.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.CHANGE_CONFIGURATION,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/ChangeConfiguration.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<ChangeConfigurationRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<ChangeConfigurationRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/ChangeConfiguration.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.GET_DIAGNOSTICS,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/GetDiagnostics.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<GetDiagnosticsRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<GetDiagnosticsRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/GetDiagnostics.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.SET_CHARGING_PROFILE,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/SetChargingProfile.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<SetChargingProfileRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<SetChargingProfileRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/SetChargingProfile.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.CLEAR_CHARGING_PROFILE,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/ClearChargingProfile.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<ClearChargingProfileRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<ClearChargingProfileRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/ClearChargingProfile.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.CHANGE_AVAILABILITY,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/ChangeAvailability.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<ChangeAvailabilityRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<ChangeAvailabilityRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/ChangeAvailability.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.REMOTE_START_TRANSACTION,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/RemoteStartTransaction.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<RemoteStartTransactionRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<RemoteStartTransactionRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/RemoteStartTransaction.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.REMOTE_STOP_TRANSACTION,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/RemoteStopTransaction.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<RemoteStopTransactionRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<RemoteStopTransactionRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/RemoteStopTransaction.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.TRIGGER_MESSAGE,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/TriggerMessage.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<OCPP16TriggerMessageRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<OCPP16TriggerMessageRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/TriggerMessage.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.DATA_TRANSFER,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/DataTransfer.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<OCPP16DataTransferRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<OCPP16DataTransferRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/DataTransfer.json',
+ moduleName,
+ 'constructor'
+ ),
],
[
OCPP16IncomingRequestCommand.UPDATE_FIRMWARE,
- JSON.parse(
- fs.readFileSync(
- path.resolve(
- path.dirname(fileURLToPath(import.meta.url)),
- '../../../assets/json-schemas/ocpp/1.6/UpdateFirmware.json'
- ),
- 'utf8'
- )
- ) as JSONSchemaType<OCPP16UpdateFirmwareRequest>,
+ OCPP16ServiceUtils.parseJsonSchemaFile<OCPP16UpdateFirmwareRequest>(
+ '../../../assets/json-schemas/ocpp/1.6/UpdateFirmware.json',
+ moduleName,
+ 'constructor'
+ ),
],
]);
this.validatePayload.bind(this);
private handleRequestReset(
chargingStation: ChargingStation,
commandPayload: ResetRequest
- ): DefaultResponse {
- this.asyncResource
- .runInAsyncScope(
- chargingStation.reset.bind(chargingStation) as (
- this: ChargingStation,
- ...args: any[]
- ) => Promise<void>,
- chargingStation,
- (commandPayload.type + 'Reset') as OCPP16StopTransactionReason
- )
- .catch(() => {
- /* This is intentional */
- });
+ ): GenericResponse {
+ this.runInAsyncScope(
+ chargingStation.reset.bind(chargingStation) as (
+ this: ChargingStation,
+ ...args: any[]
+ ) => Promise<void>,
+ chargingStation,
+ `${commandPayload.type}Reset` as OCPP16StopTransactionReason
+ ).catch(() => {
+ /* This is intentional */
+ });
logger.info(
`${chargingStation.logPrefix()} ${
commandPayload.type
return OCPPConstants.OCPP_RESPONSE_ACCEPTED;
}
- private handleRequestClearCache(chargingStation: ChargingStation): DefaultResponse {
- chargingStation.authorizedTagsCache.deleteAuthorizedTags(
- ChargingStationUtils.getAuthorizationFile(chargingStation.stationInfo)
- );
- return OCPPConstants.OCPP_RESPONSE_ACCEPTED;
- }
-
private async handleRequestUnlockConnector(
chargingStation: ChargingStation,
commandPayload: UnlockConnectorRequest
}
if (connectorId === 0) {
logger.error(
- chargingStation.logPrefix() + ' Trying to unlock connector Id ' + connectorId.toString()
+ `${chargingStation.logPrefix()} Trying to unlock connector Id ${connectorId.toString()}`
);
return OCPPConstants.OCPP_RESPONSE_UNLOCK_NOT_SUPPORTED;
}
): GetConfigurationResponse {
const configurationKey: OCPPConfigurationKey[] = [];
const unknownKey: string[] = [];
- if (Utils.isEmptyArray(commandPayload.key) === true) {
+ if (Utils.isUndefined(commandPayload.key) === true) {
for (const configuration of chargingStation.ocppConfiguration.configurationKey) {
if (Utils.isUndefined(configuration.visible) === true) {
configuration.visible = true;
value: configuration.value,
});
}
- } else {
+ } else if (Utils.isNotEmptyArray(commandPayload.key) === true) {
for (const key of commandPayload.key) {
const keyFound = ChargingStationConfigurationUtils.getConfigurationKey(
chargingStation,
- key
+ key,
+ true
);
if (keyFound) {
if (Utils.isUndefined(keyFound.visible) === true) {
}
if (
commandPayload.csChargingProfiles.chargingProfilePurpose ===
- ChargingProfilePurposeType.CHARGE_POINT_MAX_PROFILE &&
+ OCPP16ChargingProfilePurposeType.CHARGE_POINT_MAX_PROFILE &&
commandPayload.connectorId !== 0
) {
return OCPPConstants.OCPP_SET_CHARGING_PROFILE_RESPONSE_REJECTED;
}
if (
commandPayload.csChargingProfiles.chargingProfilePurpose ===
- ChargingProfilePurposeType.TX_PROFILE &&
+ OCPP16ChargingProfilePurposeType.TX_PROFILE &&
(commandPayload.connectorId === 0 ||
chargingStation.getConnectorStatus(commandPayload.connectorId)?.transactionStarted ===
false)
logger.debug(
`${chargingStation.logPrefix()} Charging profile(s) set on connector id ${
commandPayload.connectorId
- }, dump their stack: %j`,
- chargingStation.getConnectorStatus(commandPayload.connectorId).chargingProfiles
+ }: %j`,
+ commandPayload.csChargingProfiles
);
return OCPPConstants.OCPP_SET_CHARGING_PROFILE_RESPONSE_ACCEPTED;
}
return OCPPConstants.OCPP_CLEAR_CHARGING_PROFILE_RESPONSE_UNKNOWN;
}
const connectorStatus = chargingStation.getConnectorStatus(commandPayload.connectorId);
- if (commandPayload.connectorId && !Utils.isEmptyArray(connectorStatus.chargingProfiles)) {
+ if (
+ !Utils.isNullOrUndefined(commandPayload.connectorId) &&
+ Utils.isNotEmptyArray(connectorStatus?.chargingProfiles)
+ ) {
connectorStatus.chargingProfiles = [];
logger.debug(
`${chargingStation.logPrefix()} Charging profile(s) cleared on connector id ${
commandPayload.connectorId
- }, dump their stack: %j`,
- connectorStatus.chargingProfiles
+ }`
);
return OCPPConstants.OCPP_CLEAR_CHARGING_PROFILE_RESPONSE_ACCEPTED;
}
- if (!commandPayload.connectorId) {
+ if (Utils.isNullOrUndefined(commandPayload.connectorId)) {
let clearedCP = false;
for (const connectorId of chargingStation.connectors.keys()) {
- if (!Utils.isEmptyArray(chargingStation.getConnectorStatus(connectorId).chargingProfiles)) {
+ if (
+ Utils.isNotEmptyArray(chargingStation.getConnectorStatus(connectorId)?.chargingProfiles)
+ ) {
chargingStation
.getConnectorStatus(connectorId)
- .chargingProfiles?.forEach((chargingProfile: OCPP16ChargingProfile, index: number) => {
+ ?.chargingProfiles?.forEach((chargingProfile: OCPP16ChargingProfile, index: number) => {
let clearCurrentCP = false;
if (chargingProfile.chargingProfileId === commandPayload.id) {
clearCurrentCP = true;
clearCurrentCP = true;
}
if (clearCurrentCP) {
- connectorStatus.chargingProfiles.splice(index, 1);
+ connectorStatus?.chargingProfiles?.splice(index, 1);
logger.debug(
- `${chargingStation.logPrefix()} Matching charging profile(s) cleared on connector id ${
- commandPayload.connectorId
- }, dump their stack: %j`,
- connectorStatus.chargingProfiles
+ `${chargingStation.logPrefix()} Matching charging profile(s) cleared: %j`,
+ chargingProfile
);
clearedCP = true;
}
private async handleRequestRemoteStartTransaction(
chargingStation: ChargingStation,
commandPayload: RemoteStartTransactionRequest
- ): Promise<DefaultResponse> {
+ ): Promise<GenericResponse> {
const transactionConnectorId = commandPayload.connectorId;
if (chargingStation.connectors.has(transactionConnectorId) === true) {
- const remoteStartTransactionLogMsg =
- chargingStation.logPrefix() +
- ' Transaction remotely STARTED on ' +
- chargingStation.stationInfo.chargingStationId +
- '#' +
- transactionConnectorId.toString() +
- " for idTag '" +
- commandPayload.idTag +
- "'";
+ const remoteStartTransactionLogMsg = `${chargingStation.logPrefix()} Transaction remotely STARTED on ${
+ chargingStation.stationInfo.chargingStationId
+ }#${transactionConnectorId.toString()} for idTag '${commandPayload.idTag}'`;
await chargingStation.ocppRequestService.requestHandler<
OCPP16StatusNotificationRequest,
OCPP16StatusNotificationResponse
if (
chargingStation.getLocalAuthListEnabled() === true &&
chargingStation.hasAuthorizedTags() === true &&
- chargingStation.authorizedTagsCache
- .getAuthorizedTags(
- ChargingStationUtils.getAuthorizationFile(chargingStation.stationInfo)
- )
- .find((idTag) => idTag === commandPayload.idTag)
+ Utils.isNotEmptyString(
+ chargingStation.authorizedTagsCache
+ .getAuthorizedTags(
+ ChargingStationUtils.getAuthorizationFile(chargingStation.stationInfo)
+ )
+ ?.find((idTag) => idTag === commandPayload.idTag)
+ )
) {
connectorStatus.localAuthorizeIdTag = commandPayload.idTag;
connectorStatus.idTagLocalAuthorized = true;
chargingStation: ChargingStation,
connectorId: number,
idTag: string
- ): Promise<DefaultResponse> {
+ ): Promise<GenericResponse> {
if (
- chargingStation.getConnectorStatus(connectorId).status !== OCPP16ChargePointStatus.AVAILABLE
+ chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.AVAILABLE
) {
await chargingStation.ocppRequestService.requestHandler<
OCPP16StatusNotificationRequest,
chargingStation.getConnectorStatus(connectorId).status = OCPP16ChargePointStatus.AVAILABLE;
}
logger.warn(
- chargingStation.logPrefix() +
- ' Remote starting transaction REJECTED on connector Id ' +
- connectorId.toString() +
- ", idTag '" +
- idTag +
- "', availability '" +
- chargingStation.getConnectorStatus(connectorId).availability +
- "', status '" +
- chargingStation.getConnectorStatus(connectorId).status +
- "'"
+ `${chargingStation.logPrefix()} Remote starting transaction REJECTED on connector Id ${connectorId.toString()}, idTag '${idTag}', availability '${
+ chargingStation.getConnectorStatus(connectorId)?.availability
+ }', status '${chargingStation.getConnectorStatus(connectorId)?.status}'`
);
return OCPPConstants.OCPP_RESPONSE_REJECTED;
}
connectorId: number,
cp: OCPP16ChargingProfile
): boolean {
- if (cp && cp.chargingProfilePurpose === ChargingProfilePurposeType.TX_PROFILE) {
+ if (cp && cp.chargingProfilePurpose === OCPP16ChargingProfilePurposeType.TX_PROFILE) {
OCPP16ServiceUtils.setChargingProfile(chargingStation, connectorId, cp);
logger.debug(
- `${chargingStation.logPrefix()} Charging profile(s) set at remote start transaction on connector id ${connectorId}, dump their stack: %j`,
- chargingStation.getConnectorStatus(connectorId).chargingProfiles
+ `${chargingStation.logPrefix()} Charging profile(s) set at remote start transaction on connector id ${connectorId}: %j`,
+ cp
);
return true;
- } else if (cp && cp.chargingProfilePurpose !== ChargingProfilePurposeType.TX_PROFILE) {
+ } else if (cp && cp.chargingProfilePurpose !== OCPP16ChargingProfilePurposeType.TX_PROFILE) {
logger.warn(
`${chargingStation.logPrefix()} Not allowed to set ${
cp.chargingProfilePurpose
private async handleRequestRemoteStopTransaction(
chargingStation: ChargingStation,
commandPayload: RemoteStopTransactionRequest
- ): Promise<DefaultResponse> {
+ ): Promise<GenericResponse> {
const transactionId = commandPayload.transactionId;
for (const connectorId of chargingStation.connectors.keys()) {
if (
}
}
logger.warn(
- chargingStation.logPrefix() +
- ' Trying to remote stop a non existing transaction ' +
- transactionId.toString()
+ `${chargingStation.logPrefix()} Trying to remote stop a non existing transaction ${transactionId.toString()}`
);
return OCPPConstants.OCPP_RESPONSE_REJECTED;
}
OCPP16IncomingRequestCommand.UPDATE_FIRMWARE
) === false
) {
+ logger.warn(
+ `${chargingStation.logPrefix()} ${moduleName}.handleRequestUpdateFirmware: Cannot simulate firmware update: feature profile not supported`
+ );
+ return OCPPConstants.OCPP_RESPONSE_EMPTY;
+ }
+ if (
+ !Utils.isNullOrUndefined(chargingStation.stationInfo.firmwareStatus) &&
+ chargingStation.stationInfo.firmwareStatus !== OCPP16FirmwareStatus.Installed
+ ) {
+ logger.warn(
+ `${chargingStation.logPrefix()} ${moduleName}.handleRequestUpdateFirmware: Cannot simulate firmware update: firmware update is already in progress`
+ );
return OCPPConstants.OCPP_RESPONSE_EMPTY;
}
const retrieveDate = Utils.convertToDate(commandPayload.retrieveDate);
- if (retrieveDate.getTime() <= Date.now()) {
- this.asyncResource
- .runInAsyncScope(
- this.updateFirmware.bind(this) as (
- this: OCPP16IncomingRequestService,
- ...args: any[]
- ) => Promise<void>,
- this,
- chargingStation
- )
- .catch(() => {
- /* This is intentional */
- });
+ const now = Date.now();
+ if (retrieveDate?.getTime() <= now) {
+ this.runInAsyncScope(
+ this.updateFirmware.bind(this) as (
+ this: OCPP16IncomingRequestService,
+ ...args: any[]
+ ) => Promise<void>,
+ this,
+ chargingStation
+ ).catch(() => {
+ /* This is intentional */
+ });
} else {
setTimeout(() => {
this.updateFirmware(chargingStation).catch(() => {
/* Intentional */
});
- }, retrieveDate.getTime() - Date.now());
+ }, retrieveDate?.getTime() - now);
}
return OCPPConstants.OCPP_RESPONSE_EMPTY;
}
private async updateFirmware(
chargingStation: ChargingStation,
- minDelay = 15,
- maxDelay = 30
+ maxDelay = 30,
+ minDelay = 15
): Promise<void> {
chargingStation.stopAutomaticTransactionGenerator();
for (const connectorId of chargingStation.connectors.keys()) {
if (
connectorId > 0 &&
- chargingStation.getConnectorStatus(connectorId).transactionStarted === false
+ chargingStation.getConnectorStatus(connectorId)?.transactionStarted === false
) {
await chargingStation.ocppRequestService.requestHandler<
OCPP16StatusNotificationRequest,
status: OCPP16ChargePointStatus.UNAVAILABLE,
errorCode: OCPP16ChargePointErrorCode.NO_ERROR,
});
+ chargingStation.getConnectorStatus(connectorId).status =
+ OCPP16ChargePointStatus.UNAVAILABLE;
}
}
+ if (
+ chargingStation.stationInfo?.firmwareUpgrade?.failureStatus &&
+ Utils.isNotEmptyString(chargingStation.stationInfo?.firmwareUpgrade?.failureStatus)
+ ) {
+ await chargingStation.ocppRequestService.requestHandler<
+ OCPP16FirmwareStatusNotificationRequest,
+ OCPP16FirmwareStatusNotificationResponse
+ >(chargingStation, OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, {
+ status: chargingStation.stationInfo?.firmwareUpgrade?.failureStatus,
+ });
+ return;
+ }
await chargingStation.ocppRequestService.requestHandler<
OCPP16FirmwareStatusNotificationRequest,
OCPP16FirmwareStatusNotificationResponse
status: OCPP16FirmwareStatus.Downloading,
});
chargingStation.stationInfo.firmwareStatus = OCPP16FirmwareStatus.Downloading;
- await Utils.sleep(Utils.getRandomInteger(minDelay, maxDelay) * 1000);
+ await Utils.sleep(Utils.getRandomInteger(maxDelay, minDelay) * 1000);
await chargingStation.ocppRequestService.requestHandler<
OCPP16FirmwareStatusNotificationRequest,
OCPP16FirmwareStatusNotificationResponse
status: OCPP16FirmwareStatus.Downloaded,
});
chargingStation.stationInfo.firmwareStatus = OCPP16FirmwareStatus.Downloaded;
- await Utils.sleep(Utils.getRandomInteger(minDelay, maxDelay) * 1000);
+ await Utils.sleep(Utils.getRandomInteger(maxDelay, minDelay) * 1000);
await chargingStation.ocppRequestService.requestHandler<
OCPP16FirmwareStatusNotificationRequest,
OCPP16FirmwareStatusNotificationResponse
status: OCPP16FirmwareStatus.Installing,
});
chargingStation.stationInfo.firmwareStatus = OCPP16FirmwareStatus.Installing;
- await Utils.sleep(Utils.getRandomInteger(minDelay, maxDelay) * 1000);
- await chargingStation.reset(OCPP16StopTransactionReason.REBOOT);
+ if (chargingStation.stationInfo?.firmwareUpgrade?.reset === true) {
+ await Utils.sleep(Utils.getRandomInteger(maxDelay, minDelay) * 1000);
+ await chargingStation.reset(OCPP16StopTransactionReason.REBOOT);
+ }
}
private async handleRequestGetDiagnostics(
OCPP16IncomingRequestCommand.GET_DIAGNOSTICS
) === false
) {
+ logger.warn(
+ `${chargingStation.logPrefix()} ${moduleName}.handleRequestGetDiagnostics: Cannot get diagnostics: feature profile not supported`
+ );
return OCPPConstants.OCPP_RESPONSE_EMPTY;
}
const uri = new URL(commandPayload.location);
.readdirSync(path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../../'))
.filter((file) => file.endsWith('.log'))
.map((file) => path.join('./', file));
- const diagnosticsArchive = chargingStation.stationInfo.chargingStationId + '_logs.tar.gz';
+ const diagnosticsArchive = `${chargingStation.stationInfo.chargingStationId}_logs.tar.gz`;
tar.create({ gzip: true }, logFiles).pipe(fs.createWriteStream(diagnosticsArchive));
ftpClient = new Client();
const accessResponse = await ftpClient.access({
host: uri.host,
- ...(!Utils.isEmptyString(uri.port) && { port: Utils.convertToInt(uri.port) }),
- ...(!Utils.isEmptyString(uri.username) && { user: uri.username }),
- ...(!Utils.isEmptyString(uri.password) && { password: uri.password }),
+ ...(Utils.isNotEmptyString(uri.port) && { port: Utils.convertToInt(uri.port) }),
+ ...(Utils.isNotEmptyString(uri.username) && { user: uri.username }),
+ ...(Utils.isNotEmptyString(uri.password) && { password: uri.password }),
});
let uploadResponse: FTPResponse;
if (accessResponse.code === 220) {
- // eslint-disable-next-line @typescript-eslint/no-misused-promises
- ftpClient.trackProgress(async (info) => {
+ ftpClient.trackProgress((info) => {
logger.info(
`${chargingStation.logPrefix()} ${
info.bytes / 1024
} bytes transferred from diagnostics archive ${info.name}`
);
- await chargingStation.ocppRequestService.requestHandler<
- OCPP16DiagnosticsStatusNotificationRequest,
- OCPP16DiagnosticsStatusNotificationResponse
- >(chargingStation, OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, {
- status: OCPP16DiagnosticsStatus.Uploading,
- });
+ chargingStation.ocppRequestService
+ .requestHandler<
+ OCPP16DiagnosticsStatusNotificationRequest,
+ OCPP16DiagnosticsStatusNotificationResponse
+ >(chargingStation, OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, {
+ status: OCPP16DiagnosticsStatus.Uploading,
+ })
+ .catch((error) => {
+ logger.error(
+ `${chargingStation.logPrefix()} ${moduleName}.handleRequestGetDiagnostics: Error while sending '${
+ OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION
+ }'`,
+ error
+ );
+ });
});
uploadResponse = await ftpClient.uploadFrom(
path.join(
path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../../'),
diagnosticsArchive
),
- uri.pathname + diagnosticsArchive
+ `${uri.pathname}${diagnosticsArchive}`
);
if (uploadResponse.code === 226) {
await chargingStation.ocppRequestService.requestHandler<
throw new OCPPError(
ErrorType.GENERIC_ERROR,
`Diagnostics transfer failed with error code ${accessResponse.code.toString()}${
- uploadResponse?.code && '|' + uploadResponse?.code.toString()
+ uploadResponse?.code && `|${uploadResponse?.code.toString()}`
}`,
OCPP16IncomingRequestCommand.GET_DIAGNOSTICS
);
throw new OCPPError(
ErrorType.GENERIC_ERROR,
`Diagnostics transfer failed with error code ${accessResponse.code.toString()}${
- uploadResponse?.code && '|' + uploadResponse?.code.toString()
+ uploadResponse?.code && `|${uploadResponse?.code.toString()}`
}`,
OCPP16IncomingRequestCommand.GET_DIAGNOSTICS
);
return OCPPConstants.OCPP_TRIGGER_MESSAGE_RESPONSE_ACCEPTED;
case OCPP16MessageTrigger.StatusNotification:
setTimeout(() => {
- if (commandPayload?.connectorId) {
+ if (!Utils.isNullOrUndefined(commandPayload?.connectorId)) {
chargingStation.ocppRequestService
.requestHandler<OCPP16StatusNotificationRequest, OCPP16StatusNotificationResponse>(
chargingStation,
{
connectorId: commandPayload.connectorId,
errorCode: OCPP16ChargePointErrorCode.NO_ERROR,
- status: chargingStation.getConnectorStatus(commandPayload.connectorId).status,
+ status: chargingStation.getConnectorStatus(commandPayload.connectorId)?.status,
},
{
triggerMessage: true,
{
connectorId,
errorCode: OCPP16ChargePointErrorCode.NO_ERROR,
- status: chargingStation.getConnectorStatus(connectorId).status,
+ status: chargingStation.getConnectorStatus(connectorId)?.status,
},
{
triggerMessage: true,