repositories
/
poolifier.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
fix: updates strategies internals once statistics are computed
[poolifier.git]
/
src
/
pools
/
selection-strategies
/
fair-share-worker-choice-strategy.ts
diff --git
a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts
b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts
index 56d9dc361fe6e70255877ec6c1e6be6f33b70a70..39da59a0f2c2d0a16c58e9f4f8b9ce91cc915b92 100644
(file)
--- a/
src/pools/selection-strategies/fair-share-worker-choice-strategy.ts
+++ b/
src/pools/selection-strategies/fair-share-worker-choice-strategy.ts
@@
-2,10
+2,11
@@
import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils'
import type { IPool } from '../pool'
import type { IWorker } from '../worker'
import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy'
import type { IPool } from '../pool'
import type { IWorker } from '../worker'
import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy'
-import type {
- IWorkerChoiceStrategy,
- RequiredStatistics,
- WorkerChoiceStrategyOptions
+import {
+ type IWorkerChoiceStrategy,
+ Measurements,
+ type TaskStatisticsRequirements,
+ type WorkerChoiceStrategyOptions
} from './selection-strategies-types'
/**
} from './selection-strategies-types'
/**
@@
-24,13
+25,22
@@
export class FairShareWorkerChoiceStrategy<
extends AbstractWorkerChoiceStrategy<Worker, Data, Response>
implements IWorkerChoiceStrategy {
/** @inheritDoc */
extends AbstractWorkerChoiceStrategy<Worker, Data, Response>
implements IWorkerChoiceStrategy {
/** @inheritDoc */
- public readonly requiredStatistics: RequiredStatistics = {
- runTime: true,
- avgRunTime: true,
- medRunTime: false,
- waitTime: false,
- avgWaitTime: false,
- medWaitTime: false
+ public readonly taskStatisticsRequirements: TaskStatisticsRequirements = {
+ runTime: {
+ aggregate: true,
+ average: true,
+ median: false
+ },
+ waitTime: {
+ aggregate: false,
+ average: false,
+ median: false
+ },
+ elu: {
+ aggregate: true,
+ average: true,
+ median: false
+ }
}
/**
}
/**
@@
-44,7
+54,7
@@
export class FairShareWorkerChoiceStrategy<
opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS
) {
super(pool, opts)
opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS
) {
super(pool, opts)
- this.set
RequiredStatistic
s(this.opts)
+ this.set
TaskStatisticsRequirement
s(this.opts)
}
/** @inheritDoc */
}
/** @inheritDoc */
@@
-56,13
+66,7
@@
export class FairShareWorkerChoiceStrategy<
/** @inheritDoc */
public update (workerNodeKey: number): boolean {
this.computeWorkerVirtualTaskEndTimestamp(workerNodeKey)
/** @inheritDoc */
public update (workerNodeKey: number): boolean {
this.computeWorkerVirtualTaskEndTimestamp(workerNodeKey)
- return true
- }
-
- /** @inheritDoc */
- public choose (): number {
let minWorkerVirtualTaskEndTimestamp = Infinity
let minWorkerVirtualTaskEndTimestamp = Infinity
- let chosenWorkerNodeKey!: number
for (const [workerNodeKey] of this.pool.workerNodes.entries()) {
if (this.workersVirtualTaskEndTimestamp[workerNodeKey] == null) {
this.computeWorkerVirtualTaskEndTimestamp(workerNodeKey)
for (const [workerNodeKey] of this.pool.workerNodes.entries()) {
if (this.workersVirtualTaskEndTimestamp[workerNodeKey] == null) {
this.computeWorkerVirtualTaskEndTimestamp(workerNodeKey)
@@
-71,10
+75,15
@@
export class FairShareWorkerChoiceStrategy<
this.workersVirtualTaskEndTimestamp[workerNodeKey]
if (workerVirtualTaskEndTimestamp < minWorkerVirtualTaskEndTimestamp) {
minWorkerVirtualTaskEndTimestamp = workerVirtualTaskEndTimestamp
this.workersVirtualTaskEndTimestamp[workerNodeKey]
if (workerVirtualTaskEndTimestamp < minWorkerVirtualTaskEndTimestamp) {
minWorkerVirtualTaskEndTimestamp = workerVirtualTaskEndTimestamp
-
chosenWorkerNodeKey
= workerNodeKey
+
this.nextWorkerNodeId
= workerNodeKey
}
}
}
}
- return chosenWorkerNodeKey
+ return true
+ }
+
+ /** @inheritDoc */
+ public choose (): number {
+ return this.nextWorkerNodeId
}
/** @inheritDoc */
}
/** @inheritDoc */
@@
-100,9
+109,11
@@
export class FairShareWorkerChoiceStrategy<
workerNodeKey: number,
workerVirtualTaskStartTimestamp: number
): number {
workerNodeKey: number,
workerVirtualTaskStartTimestamp: number
): number {
- return (
- workerVirtualTaskStartTimestamp + this.getWorkerTaskRunTime(workerNodeKey)
- )
+ const workerTaskRunTime =
+ this.opts.measurement === Measurements.elu
+ ? this.getWorkerTaskElu(workerNodeKey)
+ : this.getWorkerTaskRunTime(workerNodeKey)
+ return workerVirtualTaskStartTimestamp + workerTaskRunTime
}
private getWorkerVirtualTaskStartTimestamp (workerNodeKey: number): number {
}
private getWorkerVirtualTaskStartTimestamp (workerNodeKey: number): number {