Fix GitHub actions issues on tests with windows and stable node

[poolifier.git] / .github / workflows / ci.yml

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d08f4158b0f53be1a5c125fa361442bb8a7516bf..5cf59718b9c99c61e8a19be1b59be5c15190d885 100644 (file)
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -5,6 +5,7 @@ on:
     branches:
       - master
   pull_request:
+    types: [opened, synchronize, reopened]
   workflow_dispatch:
     inputs:
       withBenchmark:
@@ -13,20 +14,23 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x]
+        os: [windows-latest, macos-latest, ubuntu-latest]
+        node: ['16.x', '18.x']
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis. This is needed for better sonar
 
-      - name: Set node version to ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+      - name: Set node version to ${{ matrix.node }}
+        uses: actions/setup-node@v3
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ matrix.node }}
 
       - name: Install
         run: npm ci
@@ -37,18 +41,22 @@ jobs:
       - name: Lint
         run: npm run lint
 
-      - name: Test
-        if: github.ref != 'refs/heads/master'
+      - name: Tests
+        if: "matrix.os != 'windows-latest' && matrix.node != '18.x'"
         run: npm run test
 
-      - name: Test & Coverage
-        if: github.ref == 'refs/heads/master'
+      - name: Coverage & Linter Reports
+        if: "github.repository == 'poolifier/poolifier' && matrix.os == 'ubuntu-latest' && matrix.node == '16.x'"
         run: |
-          npm run test
-          export COVERALLS_REPO_TOKEN=${{ secrets.COVERALLS_REPO_TOKEN }}
           npm run coverage
+          npm run lint:report
+
+      - name: Sonar Code Analysis
+        if: "github.repository == 'poolifier/poolifier' && matrix.os == 'ubuntu-latest' && matrix.node == '16.x'"
+        uses: sonarsource/sonarcloud-github-action@master
         env:
-          CI: true
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
       - name: Benchmark
         if: github.event.inputs.withBenchmark