refactor: cleanup loops over object keys

[e-mobility-charging-stations-simulator.git] / src / charging-station / AutomaticTransactionGenerator.ts

diff --git a/src/charging-station/AutomaticTransactionGenerator.ts b/src/charging-station/AutomaticTransactionGenerator.ts
index 477a8d9c824f2922cb178631d5156ee840a96878..3c2a2c38c80abf3b4eb7e32df83c453ec10bc8b0 100644 (file)
--- a/src/charging-station/AutomaticTransactionGenerator.ts
+++ b/src/charging-station/AutomaticTransactionGenerator.ts
@@ -3,7 +3,7 @@
 import { AsyncResource } from 'node:async_hooks';
 
 import type { ChargingStation } from './ChargingStation';
-import { ChargingStationUtils } from './ChargingStationUtils';
+import { checkChargingStation } from './ChargingStationUtils';
 import { IdTagsCache } from './IdTagsCache';
 import { BaseError } from '../exception';
 import { PerformanceStatistics } from '../performance';
@@ -19,7 +19,17 @@ import {
   StopTransactionReason,
   type StopTransactionResponse,
 } from '../types';
-import { Constants, Utils, logger } from '../utils';
+import {
+  Constants,
+  cloneObject,
+  formatDurationMilliSeconds,
+  getRandomInteger,
+  isNullOrUndefined,
+  logPrefix,
+  logger,
+  secureRandom,
+  sleep,
+} from '../utils';
 
 const moduleName = 'AutomaticTransactionGenerator';
 
@@ -31,11 +41,15 @@ export class AutomaticTransactionGenerator extends AsyncResource {
 
   public readonly connectorsStatus: Map<number, Status>;
   public started: boolean;
+  private starting: boolean;
+  private stopping: boolean;
   private readonly chargingStation: ChargingStation;
 
   private constructor(chargingStation: ChargingStation) {
     super(moduleName);
     this.started = false;
+    this.starting = false;
+    this.stopping = false;
     this.chargingStation = chargingStation;
     this.connectorsStatus = new Map<number, Status>();
     this.initializeConnectorsStatus();
@@ -54,17 +68,21 @@ export class AutomaticTransactionGenerator extends AsyncResource {
   }
 
   public start(): void {
-    if (
-      ChargingStationUtils.checkChargingStation(this.chargingStation, this.logPrefix()) === false
-    ) {
+    if (checkChargingStation(this.chargingStation, this.logPrefix()) === false) {
       return;
     }
     if (this.started === true) {
       logger.warn(`${this.logPrefix()} is already started`);
       return;
     }
+    if (this.starting === true) {
+      logger.warn(`${this.logPrefix()} is already starting`);
+      return;
+    }
+    this.starting = true;
     this.startConnectors();
     this.started = true;
+    this.starting = false;
   }
 
   public stop(): void {
@@ -72,17 +90,18 @@ export class AutomaticTransactionGenerator extends AsyncResource {
       logger.warn(`${this.logPrefix()} is already stopped`);
       return;
     }
+    if (this.stopping === true) {
+      logger.warn(`${this.logPrefix()} is already stopping`);
+      return;
+    }
+    this.stopping = true;
     this.stopConnectors();
     this.started = false;
+    this.stopping = false;
   }
 
   public startConnector(connectorId: number): void {
-    if (
-      ChargingStationUtils.checkChargingStation(
-        this.chargingStation,
-        this.logPrefix(connectorId)
-      ) === false
-    ) {
+    if (checkChargingStation(this.chargingStation, this.logPrefix(connectorId)) === false) {
       return;
     }
     if (this.connectorsStatus.has(connectorId) === false) {
@@ -163,7 +182,7 @@ export class AutomaticTransactionGenerator extends AsyncResource {
     logger.info(
       `${this.logPrefix(
         connectorId
-      )} started on connector and will run for ${Utils.formatDurationMilliSeconds(
+      )} started on connector and will run for ${formatDurationMilliSeconds(
         this.connectorsStatus.get(connectorId).stopDate.getTime() -
           this.connectorsStatus.get(connectorId).startDate.getTime()
       )}`
@@ -219,21 +238,19 @@ export class AutomaticTransactionGenerator extends AsyncResource {
           )} transaction loop waiting for charging station service to be initialized`
         );
         do {
-          await Utils.sleep(Constants.CHARGING_STATION_ATG_INITIALIZATION_TIME);
+          await sleep(Constants.CHARGING_STATION_ATG_INITIALIZATION_TIME);
         } while (!this.chargingStation?.ocppRequestService);
       }
       const wait =
-        Utils.getRandomInteger(
+        getRandomInteger(
           this.chargingStation.getAutomaticTransactionGeneratorConfiguration()
             .maxDelayBetweenTwoTransactions,
           this.chargingStation.getAutomaticTransactionGeneratorConfiguration()
             .minDelayBetweenTwoTransactions
         ) * 1000;
-      logger.info(
-        `${this.logPrefix(connectorId)} waiting for ${Utils.formatDurationMilliSeconds(wait)}`
-      );
-      await Utils.sleep(wait);
-      const start = Utils.secureRandom();
+      logger.info(`${this.logPrefix(connectorId)} waiting for ${formatDurationMilliSeconds(wait)}`);
+      await sleep(wait);
+      const start = secureRandom();
       if (
         start <
         this.chargingStation.getAutomaticTransactionGeneratorConfiguration().probabilityOfStart
@@ -244,18 +261,18 @@ export class AutomaticTransactionGenerator extends AsyncResource {
         if (startResponse?.idTagInfo?.status === AuthorizationStatus.ACCEPTED) {
           // Wait until end of transaction
           const waitTrxEnd =
-            Utils.getRandomInteger(
+            getRandomInteger(
               this.chargingStation.getAutomaticTransactionGeneratorConfiguration().maxDuration,
               this.chargingStation.getAutomaticTransactionGeneratorConfiguration().minDuration
             ) * 1000;
           logger.info(
             `${this.logPrefix(connectorId)} transaction started with id ${this.chargingStation
               .getConnectorStatus(connectorId)
-              ?.transactionId?.toString()} and will stop in ${Utils.formatDurationMilliSeconds(
+              ?.transactionId?.toString()} and will stop in ${formatDurationMilliSeconds(
               waitTrxEnd
             )}`
           );
-          await Utils.sleep(waitTrxEnd);
+          await sleep(waitTrxEnd);
           // Stop transaction
           logger.info(
             `${this.logPrefix(connectorId)} stop transaction with id ${this.chargingStation
@@ -281,7 +298,7 @@ export class AutomaticTransactionGenerator extends AsyncResource {
     logger.info(
       `${this.logPrefix(
         connectorId
-      )} stopped on connector and lasted for ${Utils.formatDurationMilliSeconds(
+      )} stopped on connector and lasted for ${formatDurationMilliSeconds(
         this.connectorsStatus.get(connectorId).stoppedDate.getTime() -
           this.connectorsStatus.get(connectorId).startDate.getTime()
       )}`
@@ -330,7 +347,7 @@ export class AutomaticTransactionGenerator extends AsyncResource {
   }
 
   private getConnectorStatus(connectorId: number): Status {
-    const connectorStatus = Utils.cloneObject(
+    const connectorStatus = cloneObject(
       this.chargingStation.getAutomaticTransactionGeneratorStatuses()
     )[connectorId];
     delete connectorStatus?.startDate;
@@ -442,7 +459,7 @@ export class AutomaticTransactionGenerator extends AsyncResource {
       const transactionId = this.chargingStation.getConnectorStatus(connectorId)?.transactionId;
       logger.warn(
         `${this.logPrefix(connectorId)} stopping a not started transaction${
-          !Utils.isNullOrUndefined(transactionId) ? ` with id ${transactionId?.toString()}` : ''
+          !isNullOrUndefined(transactionId) ? ` with id ${transactionId?.toString()}` : ''
         }`
       );
     }
@@ -457,9 +474,9 @@ export class AutomaticTransactionGenerator extends AsyncResource {
   }
 
   private logPrefix = (connectorId?: number): string => {
-    return Utils.logPrefix(
+    return logPrefix(
       ` ${this.chargingStation.stationInfo.chargingStationId} | ATG${
-        !Utils.isNullOrUndefined(connectorId) ? ` on connector #${connectorId.toString()}` : ''
+        !isNullOrUndefined(connectorId) ? ` on connector #${connectorId.toString()}` : ''
       }:`
     );
   };