Simplify WorkerUtils.defaultErrorHandler usage in WorkerSet
[e-mobility-charging-stations-simulator.git] / src / charging-station / ChargingStation.ts
index d6c65b8fcf4f4cc9a948d43da365ffa936a6bfe2..93042f20ae6db111bae72b6383da070c358a3c30 100644 (file)
@@ -14,7 +14,7 @@ import PerformanceStatistics from '../performance/PerformanceStatistics';
 import type { AutomaticTransactionGeneratorConfiguration } from '../types/AutomaticTransactionGenerator';
 import type ChargingStationConfiguration from '../types/ChargingStationConfiguration';
 import type ChargingStationInfo from '../types/ChargingStationInfo';
-import type ChargingStationOcppConfiguration from '../types/ChargingStationOcppConfiguration';
+import type { ChargingStationOcppConfiguration } from '../types/ChargingStationOcppConfiguration';
 import ChargingStationTemplate, {
   CurrentType,
   PowerUnits,
@@ -479,88 +479,96 @@ export default class ChargingStation {
   }
 
   public start(): void {
-    if (this.starting === false) {
-      this.starting = true;
-      if (this.getEnableStatistics()) {
-        this.performanceStatistics.start();
-      }
-      this.openWSConnection();
-      // Monitor charging station template file
-      this.templateFileWatcher = FileUtils.watchJsonFile(
-        this.logPrefix(),
-        FileType.ChargingStationTemplate,
-        this.templateFile,
-        null,
-        (event, filename): void => {
-          if (filename && event === 'change') {
-            try {
-              logger.debug(
-                `${this.logPrefix()} ${FileType.ChargingStationTemplate} ${
-                  this.templateFile
-                } file have changed, reload`
-              );
-              this.sharedLRUCache.deleteChargingStationTemplate(this.stationInfo?.templateHash);
-              // Initialize
-              this.initialize();
-              // Restart the ATG
-              this.stopAutomaticTransactionGenerator();
-              if (
-                this.getAutomaticTransactionGeneratorConfigurationFromTemplate()?.enable === true
-              ) {
-                this.startAutomaticTransactionGenerator();
-              }
-              if (this.getEnableStatistics()) {
-                this.performanceStatistics.restart();
-              } else {
-                this.performanceStatistics.stop();
+    if (this.started === false) {
+      if (this.starting === false) {
+        this.starting = true;
+        if (this.getEnableStatistics()) {
+          this.performanceStatistics.start();
+        }
+        this.openWSConnection();
+        // Monitor charging station template file
+        this.templateFileWatcher = FileUtils.watchJsonFile(
+          this.logPrefix(),
+          FileType.ChargingStationTemplate,
+          this.templateFile,
+          null,
+          (event, filename): void => {
+            if (filename && event === 'change') {
+              try {
+                logger.debug(
+                  `${this.logPrefix()} ${FileType.ChargingStationTemplate} ${
+                    this.templateFile
+                  } file have changed, reload`
+                );
+                this.sharedLRUCache.deleteChargingStationTemplate(this.stationInfo?.templateHash);
+                // Initialize
+                this.initialize();
+                // Restart the ATG
+                this.stopAutomaticTransactionGenerator();
+                if (
+                  this.getAutomaticTransactionGeneratorConfigurationFromTemplate()?.enable === true
+                ) {
+                  this.startAutomaticTransactionGenerator();
+                }
+                if (this.getEnableStatistics()) {
+                  this.performanceStatistics.restart();
+                } else {
+                  this.performanceStatistics.stop();
+                }
+                // FIXME?: restart heartbeat and WebSocket ping when their interval values have changed
+              } catch (error) {
+                logger.error(
+                  `${this.logPrefix()} ${FileType.ChargingStationTemplate} file monitoring error:`,
+                  error
+                );
               }
-              // FIXME?: restart heartbeat and WebSocket ping when their interval values have changed
-            } catch (error) {
-              logger.error(
-                `${this.logPrefix()} ${FileType.ChargingStationTemplate} file monitoring error:`,
-                error
-              );
             }
           }
-        }
-      );
-      parentPort.postMessage(MessageChannelUtils.buildStartedMessage(this));
-      this.starting = false;
+        );
+        parentPort.postMessage(MessageChannelUtils.buildStartedMessage(this));
+        this.starting = false;
+      } else {
+        logger.warn(`${this.logPrefix()} Charging station is already starting...`);
+      }
     } else {
-      logger.warn(`${this.logPrefix()} Charging station is already starting...`);
+      logger.warn(`${this.logPrefix()} Charging station is already started...`);
     }
   }
 
   public async stop(reason?: StopTransactionReason): Promise<void> {
-    if (this.stopping === false) {
-      this.stopping = true;
-      await this.stopMessageSequence(reason);
-      for (const connectorId of this.connectors.keys()) {
-        if (connectorId > 0) {
-          await this.ocppRequestService.requestHandler<
-            StatusNotificationRequest,
-            StatusNotificationResponse
-          >(this, RequestCommand.STATUS_NOTIFICATION, {
-            connectorId,
-            status: ChargePointStatus.UNAVAILABLE,
-            errorCode: ChargePointErrorCode.NO_ERROR,
-          });
-          this.getConnectorStatus(connectorId).status = ChargePointStatus.UNAVAILABLE;
+    if (this.started === true) {
+      if (this.stopping === false) {
+        this.stopping = true;
+        await this.stopMessageSequence(reason);
+        for (const connectorId of this.connectors.keys()) {
+          if (connectorId > 0) {
+            await this.ocppRequestService.requestHandler<
+              StatusNotificationRequest,
+              StatusNotificationResponse
+            >(this, RequestCommand.STATUS_NOTIFICATION, {
+              connectorId,
+              status: ChargePointStatus.UNAVAILABLE,
+              errorCode: ChargePointErrorCode.NO_ERROR,
+            });
+            this.getConnectorStatus(connectorId).status = ChargePointStatus.UNAVAILABLE;
+          }
         }
+        this.closeWSConnection();
+        if (this.getEnableStatistics()) {
+          this.performanceStatistics.stop();
+        }
+        this.sharedLRUCache.deleteChargingStationConfiguration(this.configurationFileHash);
+        this.templateFileWatcher.close();
+        this.sharedLRUCache.deleteChargingStationTemplate(this.stationInfo?.templateHash);
+        this.bootNotificationResponse = null;
+        this.started = false;
+        parentPort.postMessage(MessageChannelUtils.buildStoppedMessage(this));
+        this.stopping = false;
+      } else {
+        logger.warn(`${this.logPrefix()} Charging station is already stopping...`);
       }
-      this.closeWSConnection();
-      if (this.getEnableStatistics()) {
-        this.performanceStatistics.stop();
-      }
-      this.sharedLRUCache.deleteChargingStationConfiguration(this.configurationFileHash);
-      this.templateFileWatcher.close();
-      this.sharedLRUCache.deleteChargingStationTemplate(this.stationInfo?.templateHash);
-      this.bootNotificationResponse = null;
-      this.started = false;
-      parentPort.postMessage(MessageChannelUtils.buildStoppedMessage(this));
-      this.stopping = false;
     } else {
-      logger.warn(`${this.logPrefix()} Charging station is already stopping...`);
+      logger.warn(`${this.logPrefix()} Charging station is already stopped...`);
     }
   }
 
@@ -723,6 +731,7 @@ export default class ChargingStation {
     } else {
       this.automaticTransactionGenerator.start();
     }
+    parentPort.postMessage(MessageChannelUtils.buildUpdatedMessage(this));
   }
 
   public stopAutomaticTransactionGenerator(connectorIds?: number[]): void {
@@ -732,8 +741,8 @@ export default class ChargingStation {
       }
     } else {
       this.automaticTransactionGenerator?.stop();
-      this.automaticTransactionGenerator = null;
     }
+    parentPort.postMessage(MessageChannelUtils.buildUpdatedMessage(this));
   }
 
   public async stopTransactionOnConnector(
@@ -1197,7 +1206,7 @@ export default class ChargingStation {
           const lastConnectorId = Utils.convertToInt(lastConnector);
           if (
             lastConnectorId === 0 &&
-            this.getUseConnectorId0(stationInfo) &&
+            this.getUseConnectorId0(stationInfo) === true &&
             stationInfo?.Connectors[lastConnector]
           ) {
             this.connectors.set(
@@ -1444,7 +1453,7 @@ export default class ChargingStation {
           // Incoming Message
           case MessageType.CALL_MESSAGE:
             [, , commandName, commandPayload] = request as IncomingRequest;
-            if (this.getEnableStatistics()) {
+            if (this.getEnableStatistics() === true) {
               this.performanceStatistics.addRequestStatistic(commandName, messageType);
             }
             logger.debug(
@@ -1463,7 +1472,7 @@ export default class ChargingStation {
           // Outcome Message
           case MessageType.CALL_RESULT_MESSAGE:
             [, , commandPayload] = request as Response;
-            if (!this.requests.has(messageId)) {
+            if (this.requests.has(messageId) === false) {
               // Error
               throw new OCPPError(
                 ErrorType.INTERNAL_ERROR,
@@ -1475,7 +1484,7 @@ export default class ChargingStation {
             // Respond
             cachedRequest = this.requests.get(messageId);
             if (Array.isArray(cachedRequest) === true) {
-              [responseCallback, , requestCommandName, requestPayload] = cachedRequest;
+              [responseCallback, errorCallback, requestCommandName, requestPayload] = cachedRequest;
             } else {
               throw new OCPPError(
                 ErrorType.PROTOCOL_ERROR,
@@ -1494,7 +1503,7 @@ export default class ChargingStation {
           // Error Message
           case MessageType.CALL_ERROR_MESSAGE:
             [, , errorType, errorMessage, errorDetails] = request as ErrorResponse;
-            if (!this.requests.has(messageId)) {
+            if (this.requests.has(messageId) === false) {
               // Error
               throw new OCPPError(
                 ErrorType.INTERNAL_ERROR,
@@ -1531,7 +1540,7 @@ export default class ChargingStation {
         parentPort.postMessage(MessageChannelUtils.buildUpdatedMessage(this));
       } else {
         throw new OCPPError(ErrorType.PROTOCOL_ERROR, 'Incoming message is not an array', null, {
-          payload: request,
+          request,
         });
       }
     } catch (error) {
@@ -1539,12 +1548,14 @@ export default class ChargingStation {
       logger.error(
         `${this.logPrefix()} Incoming OCPP command '${
           commandName ?? requestCommandName ?? null
-        }' message '${data.toString()}' matching cached request '${JSON.stringify(
-          this.requests.get(messageId)
-        )}' processing error:`,
+        }' message '${data.toString()}'${
+          messageType !== MessageType.CALL_MESSAGE
+            ? ` matching cached request '${JSON.stringify(this.requests.get(messageId))}'`
+            : ''
+        } processing error:`,
         error
       );
-      if (!(error instanceof OCPPError)) {
+      if (error instanceof OCPPError === false) {
         logger.warn(
           `${this.logPrefix()} Error thrown at incoming OCPP command '${
             commandName ?? requestCommandName ?? null
@@ -1552,14 +1563,25 @@ export default class ChargingStation {
           error
         );
       }
-      // Send error
-      messageType === MessageType.CALL_MESSAGE &&
-        (await this.ocppRequestService.sendError(
+      if (messageType === MessageType.CALL_MESSAGE) {
+        // Send error
+        await this.ocppRequestService.sendError(
           this,
           messageId,
           error as OCPPError,
           commandName ?? requestCommandName ?? null
-        ));
+        );
+      } else if (
+        [MessageType.CALL_RESULT_MESSAGE, MessageType.CALL_ERROR_MESSAGE].includes(messageType) ===
+        true
+      ) {
+        // Always remove the request from the cache in case of error at response handling
+        this.requests.delete(messageId);
+        // Always reject the deferred promise in case of error at response handling (rejecting an already fulfilled promise is a no-op)
+        if (errorCallback) {
+          errorCallback(error as OCPPError, false);
+        }
+      }
     }
   }
 
@@ -1580,7 +1602,7 @@ export default class ChargingStation {
     connectorStatus: ConnectorStatus,
     meterStop = false
   ): number {
-    if (this.getMeteringPerTransaction()) {
+    if (this.getMeteringPerTransaction() === true) {
       return (
         (meterStop === true
           ? Math.round(connectorStatus?.transactionEnergyActiveImportRegisterValue)
@@ -1594,7 +1616,7 @@ export default class ChargingStation {
     );
   }
 
-  private getUseConnectorId0(stationInfo?: ChargingStationInfo): boolean | undefined {
+  private getUseConnectorId0(stationInfo?: ChargingStationInfo): boolean {
     const localStationInfo = stationInfo ?? this.stationInfo;
     return !Utils.isUndefined(localStationInfo.useConnectorId0)
       ? localStationInfo.useConnectorId0