fix: fix 'Cannot read properties of undefined' with revervation enabled

[e-mobility-charging-stations-simulator.git] / src / charging-station / ChargingStationConfigurationUtils.ts

diff --git a/src/charging-station/ChargingStationConfigurationUtils.ts b/src/charging-station/ChargingStationConfigurationUtils.ts
index 541fd4455df5ca70c4bd736aa6a6fa2a89bb7076..39606b66e1ea8d08cacc61b53d58607d53d9c73d 100644 (file)
--- a/src/charging-station/ChargingStationConfigurationUtils.ts
+++ b/src/charging-station/ChargingStationConfigurationUtils.ts
@@ -1,109 +1,111 @@
 import type { ChargingStation } from './ChargingStation';
-import type { ConfigurationKey, StandardParametersKey } from '../types';
-import { logger } from '../utils/Logger';
+import type { ConfigurationKey, ConfigurationKeyType } from '../types';
+import { logger } from '../utils';
 
-type ConfigurationKeyOptions = { readonly?: boolean; visible?: boolean; reboot?: boolean };
-type DeleteConfigurationKeyParams = { save?: boolean; caseInsensitive?: boolean };
-type AddConfigurationKeyParams = { overwrite?: boolean; save?: boolean };
-
-export class ChargingStationConfigurationUtils {
-  private constructor() {
-    // This is intentional
-  }
+interface ConfigurationKeyOptions {
+  readonly?: boolean;
+  visible?: boolean;
+  reboot?: boolean;
+}
+interface DeleteConfigurationKeyParams {
+  save?: boolean;
+  caseInsensitive?: boolean;
+}
+interface AddConfigurationKeyParams {
+  overwrite?: boolean;
+  save?: boolean;
+}
 
-  public static getConfigurationKey(
-    chargingStation: ChargingStation,
-    key: string | StandardParametersKey,
-    caseInsensitive = false
-  ): ConfigurationKey | undefined {
-    return chargingStation.ocppConfiguration?.configurationKey?.find((configElement) => {
-      if (caseInsensitive) {
-        return configElement.key.toLowerCase() === key.toLowerCase();
-      }
-      return configElement.key === key;
-    });
-  }
+export const getConfigurationKey = (
+  chargingStation: ChargingStation,
+  key: ConfigurationKeyType,
+  caseInsensitive = false,
+): ConfigurationKey | undefined => {
+  return chargingStation.ocppConfiguration?.configurationKey?.find((configElement) => {
+    if (caseInsensitive) {
+      return configElement.key.toLowerCase() === key.toLowerCase();
+    }
+    return configElement.key === key;
+  });
+};
 
-  public static addConfigurationKey(
-    chargingStation: ChargingStation,
-    key: string | StandardParametersKey,
-    value: string,
-    options: ConfigurationKeyOptions = {
+export const addConfigurationKey = (
+  chargingStation: ChargingStation,
+  key: ConfigurationKeyType,
+  value: string,
+  options: ConfigurationKeyOptions = {
+    readonly: false,
+    visible: true,
+    reboot: false,
+  },
+  params: AddConfigurationKeyParams = { overwrite: false, save: false },
+): void => {
+  options = {
+    ...{
       readonly: false,
       visible: true,
       reboot: false,
     },
-    params: AddConfigurationKeyParams = { overwrite: false, save: false }
-  ): void {
-    options = options ?? ({} as ConfigurationKeyOptions);
-    options.readonly = options?.readonly ?? false;
-    options.visible = options?.visible ?? true;
-    options.reboot = options?.reboot ?? false;
-    let keyFound = ChargingStationConfigurationUtils.getConfigurationKey(chargingStation, key);
-    if (keyFound && params?.overwrite) {
-      ChargingStationConfigurationUtils.deleteConfigurationKey(chargingStation, keyFound.key, {
-        save: false,
-      });
-      keyFound = undefined;
-    }
-    if (!keyFound) {
-      chargingStation.ocppConfiguration?.configurationKey?.push({
-        key,
-        readonly: options.readonly,
-        value,
-        visible: options.visible,
-        reboot: options.reboot,
-      });
-      params?.save && chargingStation.saveOcppConfiguration();
-    } else {
-      logger.error(
-        `${chargingStation.logPrefix()} Trying to add an already existing configuration key: %j`,
-        keyFound
-      );
-    }
+    ...options,
+  };
+  params = { ...{ overwrite: false, save: false }, ...params };
+  let keyFound = getConfigurationKey(chargingStation, key);
+  if (keyFound && params?.overwrite) {
+    deleteConfigurationKey(chargingStation, keyFound.key, {
+      save: false,
+    });
+    keyFound = undefined;
   }
-
-  public static setConfigurationKeyValue(
-    chargingStation: ChargingStation,
-    key: string | StandardParametersKey,
-    value: string,
-    caseInsensitive = false
-  ): void {
-    const keyFound = ChargingStationConfigurationUtils.getConfigurationKey(
-      chargingStation,
+  if (!keyFound) {
+    chargingStation.ocppConfiguration?.configurationKey?.push({
       key,
-      caseInsensitive
+      readonly: options.readonly!,
+      value,
+      visible: options.visible,
+      reboot: options.reboot,
+    });
+    params?.save && chargingStation.saveOcppConfiguration();
+  } else {
+    logger.error(
+      `${chargingStation.logPrefix()} Trying to add an already existing configuration key: %j`,
+      keyFound,
     );
-    if (keyFound) {
-      chargingStation.ocppConfiguration.configurationKey[
-        chargingStation.ocppConfiguration.configurationKey.indexOf(keyFound)
-      ].value = value;
-      chargingStation.saveOcppConfiguration();
-    } else {
-      logger.error(
-        `${chargingStation.logPrefix()} Trying to set a value on a non existing configuration key: %j`,
-        { key, value }
-      );
-    }
   }
+};
 
-  public static deleteConfigurationKey(
-    chargingStation: ChargingStation,
-    key: string | StandardParametersKey,
-    params: DeleteConfigurationKeyParams = { save: true, caseInsensitive: false }
-  ): ConfigurationKey[] | undefined {
-    const keyFound = ChargingStationConfigurationUtils.getConfigurationKey(
-      chargingStation,
-      key,
-      params?.caseInsensitive
+export const setConfigurationKeyValue = (
+  chargingStation: ChargingStation,
+  key: ConfigurationKeyType,
+  value: string,
+  caseInsensitive = false,
+): void => {
+  const keyFound = getConfigurationKey(chargingStation, key, caseInsensitive);
+  if (keyFound) {
+    chargingStation.ocppConfiguration!.configurationKey![
+      chargingStation.ocppConfiguration!.configurationKey!.indexOf(keyFound)
+    ].value = value;
+    chargingStation.saveOcppConfiguration();
+  } else {
+    logger.error(
+      `${chargingStation.logPrefix()} Trying to set a value on a non existing configuration key: %j`,
+      { key, value },
     );
-    if (keyFound) {
-      const deletedConfigurationKey = chargingStation.ocppConfiguration?.configurationKey?.splice(
-        chargingStation.ocppConfiguration.configurationKey.indexOf(keyFound),
-        1
-      );
-      params?.save && chargingStation.saveOcppConfiguration();
-      return deletedConfigurationKey;
-    }
   }
-}
+};
+
+export const deleteConfigurationKey = (
+  chargingStation: ChargingStation,
+  key: ConfigurationKeyType,
+  params: DeleteConfigurationKeyParams = { save: true, caseInsensitive: false },
+): ConfigurationKey[] | undefined => {
+  params = { ...{ save: true, caseInsensitive: false }, ...params };
+  const keyFound = getConfigurationKey(chargingStation, key, params?.caseInsensitive);
+  if (keyFound) {
+    const deletedConfigurationKey = chargingStation.ocppConfiguration?.configurationKey?.splice(
+      chargingStation.ocppConfiguration.configurationKey.indexOf(keyFound),
+      1,
+    );
+    params?.save && chargingStation.saveOcppConfiguration();
+    return deletedConfigurationKey;
+  }
+};