import path from 'path';
import { fileURLToPath } from 'url';
-import { JSONSchemaType } from 'ajv';
+import type { JSONSchemaType } from 'ajv';
import OCPPError from '../../../exception/OCPPError';
-import { JsonObject, JsonType } from '../../../types/JsonType';
-import { OCPP16MeterValuesRequest } from '../../../types/ocpp/1.6/MeterValues';
+import type { JsonObject, JsonType } from '../../../types/JsonType';
+import type { OCPP16MeterValuesRequest } from '../../../types/ocpp/1.6/MeterValues';
import {
DiagnosticsStatusNotificationRequest,
OCPP16BootNotificationRequest,
OCPP16RequestCommand,
OCPP16StatusNotificationRequest,
} from '../../../types/ocpp/1.6/Requests';
-import {
+import type {
OCPP16AuthorizeRequest,
OCPP16StartTransactionRequest,
OCPP16StopTransactionRequest,
} from '../../../types/ocpp/1.6/Transaction';
import { ErrorType } from '../../../types/ocpp/ErrorType';
-import { RequestParams } from '../../../types/ocpp/Requests';
+import type { RequestParams } from '../../../types/ocpp/Requests';
import Constants from '../../../utils/Constants';
import logger from '../../../utils/Logger';
import Utils from '../../../utils/Utils';
import type ChargingStation from '../../ChargingStation';
-import { ChargingStationUtils } from '../../ChargingStationUtils';
import OCPPRequestService from '../OCPPRequestService';
import type OCPPResponseService from '../OCPPResponseService';
import { OCPP16ServiceUtils } from './OCPP16ServiceUtils';
) as JSONSchemaType<OCPP16StopTransactionRequest>,
],
]);
+ this.buildRequestPayload.bind(this);
+ this.validatePayload.bind(this);
}
- public async requestHandler<Request extends JsonType, Response extends JsonType>(
+ public async requestHandler<RequestType extends JsonType, ResponseType extends JsonType>(
chargingStation: ChargingStation,
commandName: OCPP16RequestCommand,
commandParams?: JsonType,
params?: RequestParams
- ): Promise<Response> {
- if (ChargingStationUtils.isRequestCommandSupported(commandName, chargingStation)) {
- const requestPayload = this.buildRequestPayload<Request>(
+ ): Promise<ResponseType> {
+ if (OCPP16ServiceUtils.isRequestCommandSupported(chargingStation, commandName) === true) {
+ const requestPayload = this.buildRequestPayload<RequestType>(
chargingStation,
commandName,
commandParams
requestPayload,
commandName,
params
- )) as unknown as Response;
+ )) as unknown as ResponseType;
}
+ // OCPPError usage here is debatable: it's an error in the OCPP stack but not targeted to sendError().
throw new OCPPError(
ErrorType.NOT_SUPPORTED,
- `${moduleName}.requestHandler: Unsupported OCPP command '${commandName}'`,
+ `Unsupported OCPP command '${commandName}'`,
commandName,
commandParams
);
commandParams?: JsonType
): Request {
let connectorId: number;
+ let energyActiveImportRegister: number;
commandParams = commandParams as JsonObject;
switch (commandName) {
case OCPP16RequestCommand.AUTHORIZE:
connectorId = chargingStation.getConnectorIdByTransactionId(
commandParams?.transactionId as number
);
+ commandParams?.meterStop &&
+ (energyActiveImportRegister =
+ chargingStation.getEnergyActiveImportRegisterByTransactionId(
+ commandParams?.transactionId as number,
+ true
+ ));
return {
transactionId: commandParams?.transactionId,
- ...(!Utils.isUndefined(commandParams?.idTag) && { idTag: commandParams.idTag }),
- meterStop: commandParams?.meterStop,
+ idTag:
+ commandParams?.idTag ??
+ chargingStation.getTransactionIdTag(commandParams?.transactionId as number),
+ meterStop: commandParams?.meterStop ?? energyActiveImportRegister,
timestamp: new Date().toISOString(),
- ...(commandParams?.reason && { reason: commandParams.reason }),
+ reason: commandParams?.reason,
...(chargingStation.getTransactionDataMeterValues() && {
transactionData: OCPP16ServiceUtils.buildTransactionDataMeterValues(
chargingStation.getConnectorStatus(connectorId).transactionBeginMeterValue,
OCPP16ServiceUtils.buildTransactionEndMeterValue(
chargingStation,
connectorId,
- commandParams?.meterStop as number
+ (commandParams?.meterStop as number) ?? energyActiveImportRegister
)
),
}),
} as unknown as Request;
default:
+ // OCPPError usage here is debatable: it's an error in the OCPP stack but not targeted to sendError().
throw new OCPPError(
ErrorType.NOT_SUPPORTED,
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
- `${moduleName}.buildRequestPayload: Unsupported OCPP command '${commandName}'`,
+ `Unsupported OCPP command '${commandName}'`,
commandName,
commandParams
);