refactor: rename a template key to a more sensible name

[e-mobility-charging-stations-simulator.git] / src / performance / storage / JsonFileStorage.ts

diff --git a/src/performance/storage/JsonFileStorage.ts b/src/performance/storage/JsonFileStorage.ts
index 9b016f0637bad0c15cbfa9b18700c6c10801ceaa..fcb35a4df0507569d941edbcb1aac223561e6be4 100644 (file)
--- a/src/performance/storage/JsonFileStorage.ts
+++ b/src/performance/storage/JsonFileStorage.ts
@@ -1,12 +1,13 @@
-// Copyright Jerome Benoit. 2021. All Rights Reserved.
+// Copyright Jerome Benoit. 2021-2023. All Rights Reserved.
+
+import fs from 'node:fs';
 
-import Constants from '../../utils/Constants';
-import FileUtils from '../../utils/FileUtils';
-import Statistics from '../../types/Statistics';
-import { Storage } from './Storage';
-import fs from 'fs';
 import lockfile from 'proper-lockfile';
 
+import { FileType, type Statistics } from '../../types';
+import { Constants, FileUtils, Utils } from '../../utils';
+import { Storage } from '../internal';
+
 export class JsonFileStorage extends Storage {
   private fd: number | null = null;
 
@@ -17,42 +18,45 @@ export class JsonFileStorage extends Storage {
 
   public storePerformanceStatistics(performanceStatistics: Statistics): void {
     this.checkPerformanceRecordsFile();
-    lockfile.lock(this.dbName, { stale: 5000, retries: 3 })
+    lockfile
+      .lock(this.dbName, { stale: 5000, retries: 3 })
       .then(async (release) => {
         try {
           const fileData = fs.readFileSync(this.dbName, 'utf8');
-          const performanceRecords: Statistics[] = fileData ? JSON.parse(fileData) as Statistics[] : [];
+          const performanceRecords: Statistics[] = fileData
+            ? (JSON.parse(fileData) as Statistics[])
+            : [];
           performanceRecords.push(performanceStatistics);
           fs.writeFileSync(
             this.dbName,
-            JSON.stringify(performanceRecords,
-              (key, value) => {
-                if (value instanceof Map) {
-                  return {
-                    dataType: 'Map',
-                    value: [...value]
-                  };
-                }
-                return value as Statistics;
-              },
-              2),
+            Utils.JSONStringifyWithMapSupport(performanceRecords, 2),
             'utf8'
           );
         } catch (error) {
-          FileUtils.handleFileException(this.logPrefix, Constants.PERFORMANCE_RECORDS_FILETYPE, this.dbName, error as NodeJS.ErrnoException);
+          FileUtils.handleFileException(
+            this.dbName,
+            FileType.PerformanceRecords,
+            error as NodeJS.ErrnoException,
+            this.logPrefix
+          );
         }
         await release();
       })
-      .catch(() => { /* This is intentional */ });
+      .catch(Constants.EMPTY_FUNCTION);
   }
 
   public open(): void {
     try {
-      if (!this?.fd) {
+      if (Utils.isNullOrUndefined(this?.fd)) {
         this.fd = fs.openSync(this.dbName, 'a+');
       }
     } catch (error) {
-      FileUtils.handleFileException(this.logPrefix, Constants.PERFORMANCE_RECORDS_FILETYPE, this.dbName, error as NodeJS.ErrnoException);
+      FileUtils.handleFileException(
+        this.dbName,
+        FileType.PerformanceRecords,
+        error as NodeJS.ErrnoException,
+        this.logPrefix
+      );
     }
   }
 
@@ -63,13 +67,20 @@ export class JsonFileStorage extends Storage {
         this.fd = null;
       }
     } catch (error) {
-      FileUtils.handleFileException(this.logPrefix, Constants.PERFORMANCE_RECORDS_FILETYPE, this.dbName, error as NodeJS.ErrnoException);
+      FileUtils.handleFileException(
+        this.dbName,
+        FileType.PerformanceRecords,
+        error as NodeJS.ErrnoException,
+        this.logPrefix
+      );
     }
   }
 
   private checkPerformanceRecordsFile(): void {
     if (!this?.fd) {
-      throw new Error(`${this.logPrefix} Performance records '${this.dbName}' file descriptor not found`);
+      throw new Error(
+        `${this.logPrefix} Performance records '${this.dbName}' file descriptor not found`
+      );
     }
   }
 }