test: cleanup helpers

[poolifier.git] / src / pools / cluster / fixed.ts

diff --git a/src/pools/cluster/fixed.ts b/src/pools/cluster/fixed.ts
index 78a0b52f8cc5b515c6c300587e518ebc163432a3..3f56c858b0ed5b363fc19da06eb1b9a295a66dd5 100644 (file)
--- a/src/pools/cluster/fixed.ts
+++ b/src/pools/cluster/fixed.ts
@@ -18,8 +18,7 @@ export interface ClusterPoolOptions extends PoolOptions<Worker> {
    *
    * @see https://nodejs.org/api/cluster.html#cluster_cluster_fork_env
    */
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  env?: any
+  env?: Record<string, unknown>
   /**
    * Cluster settings.
    *
@@ -33,8 +32,6 @@ export interface ClusterPoolOptions extends PoolOptions<Worker> {
  *
  * It is possible to perform tasks in sync or asynchronous mode as you prefer.
  *
- * This pool selects the workers in a round robin fashion.
- *
  * @typeParam Data - Type of data sent to the worker. This can only be serializable data.
  * @typeParam Response - Type of execution response. This can only be serializable data.
  * @author [Christopher Quadflieg](https://github.com/Shinigami92)
@@ -54,7 +51,7 @@ export class FixedClusterPool<
   public constructor (
     numberOfWorkers: number,
     filePath: string,
-    public readonly opts: ClusterPoolOptions = {}
+    protected readonly opts: ClusterPoolOptions = {}
   ) {
     super(numberOfWorkers, filePath, opts)
   }
@@ -72,7 +69,10 @@ export class FixedClusterPool<
   /** @inheritDoc */
   protected destroyWorker (worker: Worker): void {
     this.sendToWorker(worker, { kill: 1 })
-    worker.kill()
+    worker.on('disconnect', () => {
+      worker.kill()
+    })
+    worker.disconnect()
   }
 
   /** @inheritDoc */
@@ -100,7 +100,7 @@ export class FixedClusterPool<
   }
 
   /** @inheritDoc */
-  public get type (): PoolType {
+  protected get type (): PoolType {
     return PoolTypes.fixed
   }
 
@@ -119,11 +119,6 @@ export class FixedClusterPool<
     return this.numberOfWorkers
   }
 
-  /** @inheritDoc */
-  protected get full (): boolean {
-    return this.workerNodes.length >= this.numberOfWorkers
-  }
-
   /** @inheritDoc */
   protected get busy (): boolean {
     return this.internalBusy()