perf: improve node eligibility branching on worker choice strategies

[poolifier.git] / src / pools / cluster / fixed.ts

diff --git a/src/pools/cluster/fixed.ts b/src/pools/cluster/fixed.ts
index 8e264359b2ceed7a5efeab91d1488112b4f1dcb7..75c0853586c21739ff217eb3be4e63c64e7bb271 100644 (file)
--- a/src/pools/cluster/fixed.ts
+++ b/src/pools/cluster/fixed.ts
@@ -63,8 +63,9 @@ export class FixedClusterPool<
   protected async destroyWorkerNode (workerNodeKey: number): Promise<void> {
     this.flushTasksQueue(workerNodeKey)
     // FIXME: wait for tasks to be finished
-    const worker = this.workerNodes[workerNodeKey].worker
-    const workerExitPromise = new Promise<void>(resolve => {
+    const workerNode = this.workerNodes[workerNodeKey]
+    const worker = workerNode.worker
+    const waitWorkerExit = new Promise<void>((resolve) => {
       worker.on('exit', () => {
         resolve()
       })
@@ -72,9 +73,12 @@ export class FixedClusterPool<
     worker.on('disconnect', () => {
       worker.kill()
     })
-    this.sendToWorker(workerNodeKey, { kill: true, workerId: worker.id })
+    await this.sendKillMessageToWorker(
+      workerNodeKey,
+      workerNode.info.id as number
+    )
     worker.disconnect()
-    await workerExitPromise
+    await waitWorkerExit
   }
 
   /** @inheritDoc */
@@ -89,7 +93,7 @@ export class FixedClusterPool<
   protected sendStartupMessageToWorker (workerNodeKey: number): void {
     this.sendToWorker(workerNodeKey, {
       ready: false,
-      workerId: this.workerNodes[workerNodeKey].worker.id
+      workerId: this.workerNodes[workerNodeKey].info.id as number
     })
   }
 
@@ -116,16 +120,6 @@ export class FixedClusterPool<
     return WorkerTypes.cluster
   }
 
-  /** @inheritDoc */
-  protected get minSize (): number {
-    return this.numberOfWorkers
-  }
-
-  /** @inheritDoc */
-  protected get maxSize (): number {
-    return this.numberOfWorkers
-  }
-
   /** @inheritDoc */
   protected get busy (): boolean {
     return this.internalBusy()