refactor: untangle worker choosing code from worker creation code

[poolifier.git] / src / pools / selection-strategies / abstract-worker-choice-strategy.ts

diff --git a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
index 9cbebc3b0d4d87cdac321e60d0d840f343683576..f32229ec3da8550d49263f2ed76a434a63d6d97b 100644 (file)
--- a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
+++ b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
@@ -1,32 +1,49 @@
-import type { AbstractPoolWorker } from '../abstract-pool-worker'
 import type { IPoolInternal } from '../pool-internal'
 import { PoolType } from '../pool-internal'
-import type { IWorkerChoiceStrategy } from './selection-strategies-types'
+import type { IPoolWorker } from '../pool-worker'
+import type {
+  IWorkerChoiceStrategy,
+  RequiredStatistics
+} from './selection-strategies-types'
 
 /**
- * Abstract worker choice strategy class.
+ * Worker choice strategy abstract base class.
  *
- * @template Worker Type of worker which manages the strategy.
- * @template Data Type of data sent to the worker. This can only be serializable data.
- * @template Response Type of response of execution. This can only be serializable data.
+ * @typeParam Worker - Type of worker which manages the strategy.
+ * @typeParam Data - Type of data sent to the worker. This can only be serializable data.
+ * @typeParam Response - Type of response of execution. This can only be serializable data.
  */
 export abstract class AbstractWorkerChoiceStrategy<
-  Worker extends AbstractPoolWorker,
-  Data,
-  Response
-> implements IWorkerChoiceStrategy<Worker> {
-  /** @inheritdoc */
-  public isDynamicPool: boolean = this.pool.type === PoolType.DYNAMIC
+  Worker extends IPoolWorker,
+  Data = unknown,
+  Response = unknown
+> implements IWorkerChoiceStrategy {
+  /** @inheritDoc */
+  public readonly isDynamicPool: boolean
+  /** @inheritDoc */
+  public requiredStatistics: RequiredStatistics = {
+    runTime: false,
+    avgRunTime: false
+  }
 
   /**
-   * Constructs a worker choice strategy attached to the pool.
+   * Constructs a worker choice strategy bound to the pool.
    *
-   * @param pool The pool instance.
+   * @param pool - The pool instance.
    */
   public constructor (
-    protected readonly pool: IPoolInternal<Worker, Data, Response>
-  ) {}
+    public readonly pool: IPoolInternal<Worker, Data, Response>
+  ) {
+    this.isDynamicPool = this.pool.type === PoolType.DYNAMIC
+    this.choose.bind(this)
+  }
 
-  /** @inheritdoc */
-  public abstract choose (): Worker
+  /** @inheritDoc */
+  public abstract reset (): boolean
+
+  /** @inheritDoc */
+  public abstract choose (): number
+
+  /** @inheritDoc */
+  public abstract remove (workerKey: number): boolean
 }