refactor: untangle worker choosing code from worker creation code

[poolifier.git] / src / pools / selection-strategies / abstract-worker-choice-strategy.ts

diff --git a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
index ebe74dcb07543b7c7698e2c2f284c33893b6e9ca..f32229ec3da8550d49263f2ed76a434a63d6d97b 100644 (file)
--- a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
+++ b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts
@@ -7,7 +7,7 @@ import type {
 } from './selection-strategies-types'
 
 /**
- * Abstract worker choice strategy class.
+ * Worker choice strategy abstract base class.
  *
  * @typeParam Worker - Type of worker which manages the strategy.
  * @typeParam Data - Type of data sent to the worker. This can only be serializable data.
@@ -15,30 +15,35 @@ import type {
  */
 export abstract class AbstractWorkerChoiceStrategy<
   Worker extends IPoolWorker,
-  Data,
-  Response
-> implements IWorkerChoiceStrategy<Worker> {
-  /** {@inheritDoc} */
+  Data = unknown,
+  Response = unknown
+> implements IWorkerChoiceStrategy {
+  /** @inheritDoc */
   public readonly isDynamicPool: boolean
-  /** {@inheritDoc} */
+  /** @inheritDoc */
   public requiredStatistics: RequiredStatistics = {
-    runTime: false
+    runTime: false,
+    avgRunTime: false
   }
 
   /**
-   * Constructs a worker choice strategy attached to the pool.
+   * Constructs a worker choice strategy bound to the pool.
    *
    * @param pool - The pool instance.
    */
   public constructor (
-    protected readonly pool: IPoolInternal<Worker, Data, Response>
+    public readonly pool: IPoolInternal<Worker, Data, Response>
   ) {
     this.isDynamicPool = this.pool.type === PoolType.DYNAMIC
+    this.choose.bind(this)
   }
 
-  /** {@inheritDoc} */
+  /** @inheritDoc */
   public abstract reset (): boolean
 
-  /** {@inheritDoc} */
-  public abstract choose (): Worker
+  /** @inheritDoc */
+  public abstract choose (): number
+
+  /** @inheritDoc */
+  public abstract remove (workerKey: number): boolean
 }