refactor: untangle worker choosing code from worker creation code

[poolifier.git] / src / pools / selection-strategies / less-used-worker-choice-strategy.ts

diff --git a/src/pools/selection-strategies/less-used-worker-choice-strategy.ts b/src/pools/selection-strategies/less-used-worker-choice-strategy.ts
index 833e605babc9cb0b2f1fcf46d4a823b291e5fa73..364c54a1d3b5d6d0a5a1c853221a247c15cdd1fa 100644 (file)
--- a/src/pools/selection-strategies/less-used-worker-choice-strategy.ts
+++ b/src/pools/selection-strategies/less-used-worker-choice-strategy.ts
@@ -1,5 +1,6 @@
 import type { IPoolWorker } from '../pool-worker'
 import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy'
+import type { IWorkerChoiceStrategy } from './selection-strategies-types'
 
 /**
  * Selects the less used worker.
@@ -9,31 +10,40 @@ import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy'
  * @typeParam Response - Type of response of execution. This can only be serializable data.
  */
 export class LessUsedWorkerChoiceStrategy<
-  Worker extends IPoolWorker,
-  Data,
-  Response
-> extends AbstractWorkerChoiceStrategy<Worker, Data, Response> {
-  /** {@inheritDoc} */
+    Worker extends IPoolWorker,
+    Data = unknown,
+    Response = unknown
+  >
+  extends AbstractWorkerChoiceStrategy<Worker, Data, Response>
+  implements IWorkerChoiceStrategy {
+  /** @inheritDoc */
   public reset (): boolean {
     return true
   }
 
-  /** {@inheritDoc} */
-  public choose (): Worker {
+  /** @inheritDoc */
+  public choose (): number {
+    const freeWorkerKey = this.pool.findFreeWorkerKey()
+    if (freeWorkerKey !== -1) {
+      return freeWorkerKey
+    }
     let minNumberOfTasks = Infinity
-    let lessUsedWorker!: Worker
-    for (const workerItem of this.pool.workers) {
-      const worker = workerItem.worker
-      const tasksUsage = this.pool.getWorkerTasksUsage(worker)
-      const workerTasks =
-        (tasksUsage?.run as number) + (tasksUsage?.running as number)
-      if (!this.isDynamicPool && workerTasks === 0) {
-        return worker
+    let lessUsedWorkerKey!: number
+    for (const [index, workerItem] of this.pool.workers.entries()) {
+      const tasksUsage = workerItem.tasksUsage
+      const workerTasks = tasksUsage.run + tasksUsage.running
+      if (workerTasks === 0) {
+        return index
       } else if (workerTasks < minNumberOfTasks) {
         minNumberOfTasks = workerTasks
-        lessUsedWorker = worker
+        lessUsedWorkerKey = index
       }
     }
-    return lessUsedWorker
+    return lessUsedWorkerKey
+  }
+
+  /** @inheritDoc */
+  public remove (workerKey: number): boolean {
+    return true
   }
 }