-import { cpus } from 'node:os'
-import type { IWorker } from '../worker'
-import type { IPool } from '../pool'
-import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils'
-import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy'
+import type { IWorker } from '../worker.js'
+import type { IPool } from '../pool.js'
+import { DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS } from '../../utils.js'
+import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy.js'
import type {
IWorkerChoiceStrategy,
- RequiredStatistics,
+ TaskStatisticsRequirements,
WorkerChoiceStrategyOptions
-} from './selection-strategies-types'
+} from './selection-strategies-types.js'
/**
* Selects the next worker with a weighted round robin scheduling algorithm.
* Loosely modeled after the weighted round robin queueing algorithm: https://en.wikipedia.org/wiki/Weighted_round_robin.
*
* @typeParam Worker - Type of worker which manages the strategy.
- * @typeParam Data - Type of data sent to the worker. This can only be serializable data.
- * @typeParam Response - Type of execution response. This can only be serializable data.
+ * @typeParam Data - Type of data sent to the worker. This can only be structured-cloneable data.
+ * @typeParam Response - Type of execution response. This can only be structured-cloneable data.
*/
export class WeightedRoundRobinWorkerChoiceStrategy<
Worker extends IWorker,
extends AbstractWorkerChoiceStrategy<Worker, Data, Response>
implements IWorkerChoiceStrategy {
/** @inheritDoc */
- public readonly requiredStatistics: RequiredStatistics = {
- runTime: true,
- avgRunTime: true,
- medRunTime: false,
- waitTime: false,
- avgWaitTime: false,
- medWaitTime: false
+ public readonly taskStatisticsRequirements: TaskStatisticsRequirements = {
+ runTime: {
+ aggregate: true,
+ average: true,
+ median: false
+ },
+ waitTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
+ elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS
}
/**
- * Worker node id where the current task will be submitted.
+ * Worker node virtual task runtime.
*/
- private currentWorkerNodeId: number = 0
- /**
- * Default worker weight.
- */
- private readonly defaultWorkerWeight: number
- /**
- * Worker virtual task runtime.
- */
- private workerVirtualTaskRunTime: number = 0
+ private workerNodeVirtualTaskRunTime: number = 0
/** @inheritDoc */
public constructor (
pool: IPool<Worker, Data, Response>,
- opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS
+ opts?: WorkerChoiceStrategyOptions
) {
super(pool, opts)
- this.setRequiredStatistics(this.opts)
- this.defaultWorkerWeight = this.computeDefaultWorkerWeight()
+ this.setTaskStatisticsRequirements(this.opts)
}
/** @inheritDoc */
public reset (): boolean {
- this.currentWorkerNodeId = 0
- this.workerVirtualTaskRunTime = 0
+ this.resetWorkerNodeKeyProperties()
+ this.workerNodeVirtualTaskRunTime = 0
return true
}
}
/** @inheritDoc */
- public choose (): number {
- const chosenWorkerNodeKey = this.currentWorkerNodeId
- const workerVirtualTaskRunTime = this.workerVirtualTaskRunTime
- const workerWeight =
- this.opts.weights?.[chosenWorkerNodeKey] ?? this.defaultWorkerWeight
- if (workerVirtualTaskRunTime < workerWeight) {
- this.workerVirtualTaskRunTime =
- workerVirtualTaskRunTime +
- this.getWorkerTaskRunTime(chosenWorkerNodeKey)
- } else {
- this.currentWorkerNodeId =
- this.currentWorkerNodeId === this.pool.workerNodes.length - 1
- ? 0
- : this.currentWorkerNodeId + 1
- this.workerVirtualTaskRunTime = 0
- }
- return chosenWorkerNodeKey
+ public choose (): number | undefined {
+ this.setPreviousWorkerNodeKey(this.nextWorkerNodeKey)
+ this.weightedRoundRobinNextWorkerNodeKey()
+ this.checkNextWorkerNodeReadiness()
+ return this.nextWorkerNodeKey
}
/** @inheritDoc */
public remove (workerNodeKey: number): boolean {
- if (this.currentWorkerNodeId === workerNodeKey) {
- if (this.pool.workerNodes.length === 0) {
- this.currentWorkerNodeId = 0
- } else if (this.currentWorkerNodeId > this.pool.workerNodes.length - 1) {
- this.currentWorkerNodeId = this.pool.workerNodes.length - 1
+ if (this.pool.workerNodes.length === 0) {
+ this.reset()
+ }
+ if (this.nextWorkerNodeKey === workerNodeKey) {
+ this.workerNodeVirtualTaskRunTime = 0
+ if (this.nextWorkerNodeKey > this.pool.workerNodes.length - 1) {
+ this.nextWorkerNodeKey = this.pool.workerNodes.length - 1
}
- this.workerVirtualTaskRunTime = 0
+ }
+ if (
+ this.previousWorkerNodeKey === workerNodeKey &&
+ this.previousWorkerNodeKey > this.pool.workerNodes.length - 1
+ ) {
+ this.previousWorkerNodeKey = this.pool.workerNodes.length - 1
}
return true
}
- private computeDefaultWorkerWeight (): number {
- let cpusCycleTimeWeight = 0
- for (const cpu of cpus()) {
- // CPU estimated cycle time
- const numberOfDigits = cpu.speed.toString().length - 1
- const cpuCycleTime = 1 / (cpu.speed / Math.pow(10, numberOfDigits))
- cpusCycleTimeWeight += cpuCycleTime * Math.pow(10, numberOfDigits)
+ private weightedRoundRobinNextWorkerNodeKey (): number | undefined {
+ const workerWeight =
+ // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+ this.opts!.weights![this.nextWorkerNodeKey ?? this.previousWorkerNodeKey]!
+ if (this.workerNodeVirtualTaskRunTime < workerWeight) {
+ this.workerNodeVirtualTaskRunTime =
+ this.workerNodeVirtualTaskRunTime +
+ this.getWorkerNodeTaskRunTime(
+ this.nextWorkerNodeKey ?? this.previousWorkerNodeKey
+ )
+ } else {
+ this.nextWorkerNodeKey =
+ this.nextWorkerNodeKey === this.pool.workerNodes.length - 1
+ ? 0
+ : (this.nextWorkerNodeKey ?? this.previousWorkerNodeKey) + 1
+ this.workerNodeVirtualTaskRunTime = 0
}
- return Math.round(cpusCycleTimeWeight / cpus().length)
+ return this.nextWorkerNodeKey
}
}