fix: ensure charging station uid is stable between firmware update

[e-mobility-charging-stations-simulator.git] / src / utils / CircularArray.ts

diff --git a/src/utils/CircularArray.ts b/src/utils/CircularArray.ts
index bf9553109f53bf8f2f9a687ab6cf9fadf13be3cb..439f0827fbe1d8afe5bfbe02054396715a1b2c28 100644 (file)
--- a/src/utils/CircularArray.ts
+++ b/src/utils/CircularArray.ts
@@ -1,6 +1,11 @@
-const DEFAULT_CIRCULAR_ARRAY_SIZE = 2000;
+// Copyright Jerome Benoit. 2021-2023. All Rights Reserved.
 
-export default class CircularArray<T> extends Array<T> {
+const DEFAULT_CIRCULAR_ARRAY_SIZE = 1024;
+
+/**
+ * Array with a maximum length shifting items when full.
+ */
+export class CircularArray<T> extends Array<T> {
   public size: number;
 
   constructor(size: number = DEFAULT_CIRCULAR_ARRAY_SIZE, ...items: T[]) {
@@ -25,18 +30,16 @@ export default class CircularArray<T> extends Array<T> {
     if (length > this.size) {
       super.splice(this.size, items.length);
     }
-    return length;
+    return this.length;
   }
 
   public concat(...items: (T | ConcatArray<T>)[]): CircularArray<T> {
-    const concatenatedCircularArray = super.concat(
-      items as T[]
-    ) as CircularArray<T>;
+    const concatenatedCircularArray = super.concat(items as T[]) as CircularArray<T>;
     concatenatedCircularArray.size = this.size;
     if (concatenatedCircularArray.length > concatenatedCircularArray.size) {
       concatenatedCircularArray.splice(
         0,
-        concatenatedCircularArray.length - this.size
+        concatenatedCircularArray.length - concatenatedCircularArray.size
       );
     }
     return concatenatedCircularArray;
@@ -44,7 +47,7 @@ export default class CircularArray<T> extends Array<T> {
 
   public splice(start: number, deleteCount?: number, ...items: T[]): T[] {
     let itemsRemoved: T[];
-    if (arguments.length >= 3 && typeof deleteCount !== 'undefined') {
+    if (arguments.length >= 3 && deleteCount !== undefined) {
       itemsRemoved = super.splice(start, deleteCount);
       // FIXME: that makes the items insert not in place
       this.push(...items);
@@ -77,8 +80,11 @@ export default class CircularArray<T> extends Array<T> {
   }
 
   private checkSize(size: number) {
+    if (!Number.isSafeInteger(size)) {
+      throw new TypeError(`Invalid circular array size: ${size} is not a safe integer`);
+    }
     if (size < 0) {
-      throw new RangeError('Invalid circular array size');
+      throw new RangeError(`Invalid circular array size: ${size} < 0`);
     }
   }
 }