test: refactor pool tests

[poolifier.git] / tests / pools / cluster / dynamic.test.js

diff --git a/tests/pools/cluster/dynamic.test.js b/tests/pools/cluster/dynamic.test.js
index 724c0c91348b974cd3b0696c9457640c93978c3e..a2b275fde298daf9465ba4b5399b420b54b76678 100644 (file)
--- a/tests/pools/cluster/dynamic.test.js
+++ b/tests/pools/cluster/dynamic.test.js
@@ -11,7 +11,7 @@ describe('Dynamic cluster pool test suite', () => {
     max,
     './tests/worker-files/cluster/testWorker.js',
     {
-      errorHandler: (e) => console.error(e)
+      errorHandler: e => console.error(e)
     }
   )
 
@@ -34,9 +34,7 @@ describe('Dynamic cluster pool test suite', () => {
     }
     expect(pool.workerNodes.length).toBeLessThanOrEqual(max)
     expect(pool.workerNodes.length).toBeGreaterThan(min)
-    // The `busy` event is triggered when the number of submitted tasks at once reach the max number of workers in the dynamic pool.
-    // So in total numberOfWorkers + 1 times for a loop submitting up to numberOfWorkers * 2 tasks to the dynamic pool.
-    expect(poolBusy).toBe(max + 1)
+    expect(poolBusy).toBe(1)
     const numberOfExitEvents = await waitWorkerEvents(pool, 'exit', max - min)
     expect(numberOfExitEvents).toBe(max - min)
   })
@@ -59,9 +57,14 @@ describe('Dynamic cluster pool test suite', () => {
 
   it('Shutdown test', async () => {
     const exitPromise = waitWorkerEvents(pool, 'exit', min)
+    let poolDestroy = 0
+    pool.emitter.on(PoolEvents.destroy, () => ++poolDestroy)
     await pool.destroy()
     const numberOfExitEvents = await exitPromise
+    expect(pool.started).toBe(false)
+    expect(pool.workerNodes.length).toBe(0)
     expect(numberOfExitEvents).toBe(min)
+    expect(poolDestroy).toBe(1)
   })
 
   it('Validation of inputs test', () => {
@@ -71,15 +74,15 @@ describe('Dynamic cluster pool test suite', () => {
   })
 
   it('Should work even without opts in input', async () => {
-    const pool1 = new DynamicClusterPool(
+    const pool = new DynamicClusterPool(
       min,
       max,
       './tests/worker-files/cluster/testWorker.js'
     )
-    const result = await pool1.execute()
+    const result = await pool.execute()
     expect(result).toStrictEqual({ ok: 1 })
     // We need to clean up the resources after our test
-    await pool1.destroy()
+    await pool.destroy()
   })
 
   it('Verify scale processes up and down is working when long executing task is used:hard', async () => {
@@ -88,7 +91,7 @@ describe('Dynamic cluster pool test suite', () => {
       max,
       './tests/worker-files/cluster/longRunningWorkerHardBehavior.js',
       {
-        errorHandler: (e) => console.error(e),
+        errorHandler: e => console.error(e),
         onlineHandler: () => console.info('long executing worker is online'),
         exitHandler: () => console.info('long executing worker exited')
       }
@@ -115,7 +118,7 @@ describe('Dynamic cluster pool test suite', () => {
       max,
       './tests/worker-files/cluster/longRunningWorkerSoftBehavior.js',
       {
-        errorHandler: (e) => console.error(e),
+        errorHandler: e => console.error(e),
         onlineHandler: () => console.info('long executing worker is online'),
         exitHandler: () => console.info('long executing worker exited')
       }