Check in UTs the error message thrown in worker-thread pool

[poolifier.git] / tests / pools / thread / fixed.test.js

diff --git a/tests/pools/thread/fixed.test.js b/tests/pools/thread/fixed.test.js
index 3401fde316130e4330f111fb0c421e2ad4833d4f..785c6e5d2d01c8801c0e34e1d33bc292bd543347 100644 (file)
--- a/tests/pools/thread/fixed.test.js
+++ b/tests/pools/thread/fixed.test.js
@@ -1,4 +1,4 @@
-const expect = require('expect')
+const { expect } = require('expect')
 const { FixedThreadPool } = require('../../../lib/index')
 const TestUtils = require('../../test-utils')
 const numberOfThreads = 10
@@ -22,16 +22,14 @@ const errorPool = new FixedThreadPool(
   1,
   './tests/worker-files/thread/errorWorker.js',
   {
-    errorHandler: e => console.error(e),
-    onlineHandler: () => console.log('worker is online')
+    errorHandler: e => console.error(e)
   }
 )
 const asyncErrorPool = new FixedThreadPool(
   1,
   './tests/worker-files/thread/asyncErrorWorker.js',
   {
-    errorHandler: e => console.error(e),
-    onlineHandler: () => console.log('worker is online')
+    errorHandler: e => console.error(e)
   }
 )
 const asyncPool = new FixedThreadPool(
@@ -76,7 +74,9 @@ describe('Fixed thread pool test suite', () => {
     for (let i = 0; i < numberOfThreads * 2; i++) {
       promises.push(pool.execute({ test: 'test' }))
     }
-    expect(poolBusy).toEqual(numberOfThreads)
+    // The `busy` event is triggered when the number of submitted tasks at once reach the number of fixed pool workers.
+    // So in total numberOfThreads + 1 times for a loop submitting up to numberOfThreads * 2 tasks to the fixed pool.
+    expect(poolBusy).toBe(numberOfThreads + 1)
   })
 
   it('Verify that is possible to have a worker that return undefined', async () => {
@@ -102,7 +102,8 @@ describe('Fixed thread pool test suite', () => {
     expect(inError).toBeDefined()
     expect(inError).toBeInstanceOf(Error)
     expect(inError.message).toBeDefined()
-    expect(typeof inError.message === 'string').toEqual(true)
+    expect(typeof inError.message === 'string').toBe(true)
+    expect(inError.message).toBe('Error Message from ThreadWorker')
   })
 
   it('Verify that error handling is working properly:async', async () => {
@@ -116,7 +117,8 @@ describe('Fixed thread pool test suite', () => {
     expect(inError).toBeDefined()
     expect(inError).toBeInstanceOf(Error)
     expect(inError.message).toBeDefined()
-    expect(typeof inError.message === 'string').toEqual(true)
+    expect(typeof inError.message === 'string').toBe(true)
+    expect(inError.message).toBe('Error Message from ThreadWorker:async')
   })
 
   it('Verify that async function is working properly', async () => {
@@ -132,8 +134,8 @@ describe('Fixed thread pool test suite', () => {
   it('Shutdown test', async () => {
     const exitPromise = TestUtils.waitExits(pool, numberOfThreads)
     await pool.destroy()
-    const res = await exitPromise
-    expect(res).toBe(numberOfThreads)
+    const numberOfExitEvents = await exitPromise
+    expect(numberOfExitEvents).toBe(numberOfThreads)
   })
 
   it('Should work even without opts in input', async () => {