refactor: silence sonar code smells

[poolifier.git] / tests / worker / abstract-worker.test.js

diff --git a/tests/worker/abstract-worker.test.js b/tests/worker/abstract-worker.test.js
index 6fd0ea2cad02f720c7de7392bbf9246259869ba0..0a920dd594f0e4e0578d35ce8ae25c1919820a85 100644 (file)
--- a/tests/worker/abstract-worker.test.js
+++ b/tests/worker/abstract-worker.test.js
@@ -1,7 +1,7 @@
 const { expect } = require('expect')
 const sinon = require('sinon')
 const { ClusterWorker, KillBehaviors, ThreadWorker } = require('../../lib')
-const { EMPTY_FUNCTION } = require('../../lib/utils')
+const { DEFAULT_TASK_NAME, EMPTY_FUNCTION } = require('../../lib/utils')
 
 describe('Abstract worker test suite', () => {
   class StubWorkerWithMainWorker extends ThreadWorker {
@@ -96,19 +96,22 @@ describe('Abstract worker test suite', () => {
 
   it('Verify that taskFunctions parameter with unique function is taken', () => {
     const worker = new ThreadWorker(() => {})
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(2)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
   })
 
-  it('Verify that taskFunctions parameter with multiple task functions contains function', () => {
+  it('Verify that taskFunctions parameter with multiple task functions is checked', () => {
     const fn1 = () => {
       return 1
     }
     const fn2 = ''
+    expect(() => new ThreadWorker({ '': fn1 })).toThrowError(
+      new TypeError('A taskFunctions parameter object key is an empty string')
+    )
     expect(() => new ThreadWorker({ fn1, fn2 })).toThrowError(
       new TypeError('A taskFunctions parameter object value is not a function')
     )
@@ -122,11 +125,11 @@ describe('Abstract worker test suite', () => {
       return 2
     }
     const worker = new ClusterWorker({ fn1, fn2 })
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(3)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
   })
@@ -178,7 +181,13 @@ describe('Abstract worker test suite', () => {
       return 2
     }
     const worker = new ClusterWorker({ fn1, fn2 })
-    expect(worker.hasTaskFunction('default')).toBe(true)
+    expect(() => worker.hasTaskFunction(0)).toThrowError(
+      new TypeError('name parameter is not a string')
+    )
+    expect(() => worker.hasTaskFunction('')).toThrowError(
+      new TypeError('name parameter is an empty string')
+    )
+    expect(worker.hasTaskFunction(DEFAULT_TASK_NAME)).toBe(true)
     expect(worker.hasTaskFunction('fn1')).toBe(true)
     expect(worker.hasTaskFunction('fn2')).toBe(true)
     expect(worker.hasTaskFunction('fn3')).toBe(false)
@@ -195,29 +204,38 @@ describe('Abstract worker test suite', () => {
       return 3
     }
     const worker = new ThreadWorker(fn1)
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(() => worker.addTaskFunction(0, fn1)).toThrowError(
+      new TypeError('name parameter is not a string')
+    )
+    expect(() => worker.addTaskFunction('', fn1)).toThrowError(
+      new TypeError('name parameter is an empty string')
+    )
+    expect(() => worker.addTaskFunction('fn3', '')).toThrowError(
+      new TypeError('fn parameter is not a function')
+    )
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(2)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
-    expect(() => worker.addTaskFunction('default', fn2)).toThrowError(
+    expect(() => worker.addTaskFunction(DEFAULT_TASK_NAME, fn2)).toThrowError(
       new Error('Cannot add a task function with the default reserved name')
     )
     worker.addTaskFunction('fn2', fn2)
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(3)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
     worker.addTaskFunction('fn1', fn1Replacement)
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(3)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
   })
@@ -230,18 +248,24 @@ describe('Abstract worker test suite', () => {
       return 2
     }
     const worker = new ClusterWorker({ fn1, fn2 })
+    expect(() => worker.removeTaskFunction(0, fn1)).toThrowError(
+      new TypeError('name parameter is not a string')
+    )
+    expect(() => worker.removeTaskFunction('', fn1)).toThrowError(
+      new TypeError('name parameter is an empty string')
+    )
     worker.getMainWorker = sinon.stub().returns({
       id: 1,
       send: sinon.stub().returns()
     })
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(3)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
-    expect(() => worker.removeTaskFunction('default')).toThrowError(
+    expect(() => worker.removeTaskFunction(DEFAULT_TASK_NAME)).toThrowError(
       new Error(
         'Cannot remove the task function with the default reserved name'
       )
@@ -252,7 +276,7 @@ describe('Abstract worker test suite', () => {
       )
     )
     worker.removeTaskFunction('fn2')
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeUndefined()
     expect(worker.taskFunctions.size).toBe(2)
@@ -267,7 +291,11 @@ describe('Abstract worker test suite', () => {
       return 2
     }
     const worker = new ClusterWorker({ fn1, fn2 })
-    expect(worker.listTaskFunctions()).toStrictEqual(['default', 'fn1', 'fn2'])
+    expect(worker.listTaskFunctions()).toStrictEqual([
+      DEFAULT_TASK_NAME,
+      'fn1',
+      'fn2'
+    ])
   })
 
   it('Verify that setDefaultTaskFunction() works', () => {
@@ -278,24 +306,35 @@ describe('Abstract worker test suite', () => {
       return 2
     }
     const worker = new ThreadWorker({ fn1, fn2 })
-    expect(worker.taskFunctions.get('default')).toBeInstanceOf(Function)
+    expect(() => worker.setDefaultTaskFunction(0, fn1)).toThrowError(
+      new TypeError('name parameter is not a string')
+    )
+    expect(() => worker.setDefaultTaskFunction('', fn1)).toThrowError(
+      new TypeError('name parameter is an empty string')
+    )
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function)
     expect(worker.taskFunctions.size).toBe(3)
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
-    expect(() => worker.setDefaultTaskFunction('default')).toThrowError(
+    expect(() => worker.setDefaultTaskFunction(DEFAULT_TASK_NAME)).toThrowError(
       new Error(
         'Cannot set the default task function reserved name as the default task function'
       )
     )
+    expect(() => worker.setDefaultTaskFunction('fn3')).toThrowError(
+      new Error(
+        'Cannot set the default task function to a non-existing task function'
+      )
+    )
     worker.setDefaultTaskFunction('fn1')
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn1')
     )
     worker.setDefaultTaskFunction('fn2')
-    expect(worker.taskFunctions.get('default')).toStrictEqual(
+    expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual(
       worker.taskFunctions.get('fn2')
     )
   })