X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;ds=sidebyside;f=.github%2Fworkflows%2Fci.yml;h=48e5cfb9a9de7e94d2fe1950d8f674fce2f63535;hb=1adaf7ac2ae157f7e3bec95f0f2430ea6dc039ef;hp=9b58017f19d7ec959e37f4b172e76456b4476f6f;hpb=12909bc982b50270d13fb6cea213c9f6296bbdf6;p=e-mobility-charging-stations-simulator.git

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9b58017f..48e5cfb9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -7,82 +7,133 @@ on:
   merge_group:
     branches: [main]
 jobs:
-  build:
-    runs-on: ${{ matrix.os }}
+  check-secrets:
+    runs-on: ubuntu-latest
+    outputs:
+      sonar-token-exists: ${{ steps.sonar-token.outputs.defined }}
+    steps:
+      - name: Check for SonarCloud Token Availability
+        id: sonar-token
+        shell: bash
+        run: |
+          if [ "${{ secrets.SONAR_TOKEN }}" != '' ]; then
+            echo "defined=true" >> $GITHUB_OUTPUT;
+          else
+            echo "defined=false" >> $GITHUB_OUTPUT;
+          fi
+  build-simulator:
+    needs: [check-secrets]
     strategy:
       matrix:
         os: [windows-latest, macos-latest, ubuntu-latest]
-        node: ['16.x', '18.x', '19.x']
+        node: ['20.x', 'latest']
+    name: Build simulator with Node ${{ matrix.node }} on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
+      - name: Dependency Review
+        if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: actions/dependency-review-action@v4
+        with:
+          base-ref: ${{ github.ref_name }}
+          head-ref: ${{ github.sha }}
+      - name: Pull Request Dependency Review
+        if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: actions/dependency-review-action@v4
+      - uses: pnpm/action-setup@v3
+        with:
+          version: 8
       - name: Setup node ${{ matrix.node }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
-      - name: corepack enable
-        run: corepack enable
+          cache: 'pnpm'
       - name: pnpm install
-        run: pnpm install
-      - name: pnpm run lint
-        run: pnpm run lint
-      - name: pnpm run build
-        run: pnpm run build --if-present
+        run: pnpm install --ignore-scripts --frozen-lockfile
+      - name: pnpm audit
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm audit --prod
+      - name: pnpm lint
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm lint
+      - name: pnpm build
+        run: pnpm build
       - name: pnpm test
         run: pnpm test
-      - name: pnpm run coverage
-        if: "github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
-        run: pnpm run coverage
+      - name: pnpm coverage
+        if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm coverage
       - name: SonarCloud Scan
-        if: "github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
-        uses: sonarsource/sonarcloud-github-action@master
+        if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: sonarsource/sonarcloud-github-action@v2.1.1
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
   build-dashboard:
+    needs: [check-secrets]
+    strategy:
+      matrix:
+        os: [windows-latest, macos-latest, ubuntu-latest]
+        node: ['18.x', '20.x', 'latest']
+    name: Build dashboard with Node ${{ matrix.node }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     defaults:
       run:
         working-directory: ui/web
-    strategy:
-      matrix:
-        os: [windows-latest, macos-latest, ubuntu-latest]
-        node: ['16.x', '18.x', '19.x']
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
+      - name: Dependency Review
+        if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: actions/dependency-review-action@v4
+        with:
+          base-ref: ${{ github.ref_name }}
+          head-ref: ${{ github.sha }}
+      - name: Pull Request Dependency Review
+        if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: actions/dependency-review-action@v4
+      - uses: pnpm/action-setup@v3
+        with:
+          version: 8
       - name: Setup node ${{ matrix.node }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
-      - name: npm clean-install
-        run: npm ci
-      - name: npm run lint
-        run: npm run lint
-      - name: npm run build
-        run: npm run build --if-present
-      - name: npm test
-        run: npm test
-      # - name: npm run coverage
-      #   if: "github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
-      #   run: npm run coverage
-      # - name: SonarCloud Scan
-      #   if: "github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
-      #   uses: sonarsource/sonarcloud-github-action@master
-      #   with:
-      #     projectBaseDir: ui/web
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
-      #     SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-  build-docker:
+          cache: 'pnpm'
+      - name: pnpm install
+        run: pnpm install --ignore-scripts --frozen-lockfile
+      - name: pnpm audit
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm audit --prod
+      - name: pnpm lint
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm lint
+      - name: pnpm build
+        run: pnpm build
+      - name: pnpm test
+        run: pnpm test
+      - name: pnpm coverage
+        if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        run: pnpm coverage
+      - name: SonarCloud Scan
+        if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
+        uses: sonarsource/sonarcloud-github-action@v2.1.1
+        with:
+          projectBaseDir: ui/web
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  build-docker-image:
     runs-on: ubuntu-latest
+    name: Build docker image
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Setup Docker Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
       - name: Build docker image
         run: |
           cd docker