X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;ds=sidebyside;f=src%2Fcharging-station%2Focpp%2FOCPPResponseService.ts;h=45a3e1f2d5822f5236e0266492935effd38f165d;hb=298be10c5c800e43b0b9dcd6c50f6d49e2cb786b;hp=a80bc2b730564d24110fbbc5026688ddf0e46df1;hpb=f5a1ff8ce8f87a149791c2c98fe7c5e8a20b5392;p=e-mobility-charging-stations-simulator.git

diff --git a/src/charging-station/ocpp/OCPPResponseService.ts b/src/charging-station/ocpp/OCPPResponseService.ts
index a80bc2b7..45a3e1f2 100644
--- a/src/charging-station/ocpp/OCPPResponseService.ts
+++ b/src/charging-station/ocpp/OCPPResponseService.ts
@@ -1,118 +1,87 @@
-import _Ajv, { type JSONSchemaType, type ValidateFunction } from 'ajv';
-import _ajvFormats from 'ajv-formats';
+import _Ajv, { type ValidateFunction } from 'ajv'
+import _ajvFormats from 'ajv-formats'
 
-import { OCPPServiceUtils } from './OCPPServiceUtils.js';
-import type { ChargingStation } from '../../charging-station/index.js';
-import { OCPPError } from '../../exception/index.js';
+import { OCPPServiceUtils } from './OCPPServiceUtils.js'
+import type { ChargingStation } from '../../charging-station/index.js'
+import { OCPPError } from '../../exception/index.js'
 import type {
   IncomingRequestCommand,
   JsonType,
   OCPPVersion,
-  RequestCommand,
-} from '../../types/index.js';
-import { logger } from '../../utils/index.js';
-type Ajv = _Ajv.default;
-const Ajv = _Ajv.default;
-const ajvFormats = _ajvFormats.default;
+  RequestCommand
+} from '../../types/index.js'
+import { Constants, logger } from '../../utils/index.js'
+type Ajv = _Ajv.default
+// eslint-disable-next-line @typescript-eslint/no-redeclare
+const Ajv = _Ajv.default
+const ajvFormats = _ajvFormats.default
 
-const moduleName = 'OCPPResponseService';
+const moduleName = 'OCPPResponseService'
 
 export abstract class OCPPResponseService {
-  private static instance: OCPPResponseService | null = null;
-
-  public jsonIncomingRequestResponseValidateFunctions: Map<
-    IncomingRequestCommand,
-    ValidateFunction<JsonType>
-  >;
-
-  private readonly version: OCPPVersion;
-  private readonly ajv: Ajv;
-  private jsonRequestValidateFunctions: Map<RequestCommand, ValidateFunction<JsonType>>;
-
-  public abstract jsonIncomingRequestResponseSchemas: Map<
-    IncomingRequestCommand,
-    JSONSchemaType<JsonType>
-  >;
+  private static instance: OCPPResponseService | null = null
+  private readonly version: OCPPVersion
+  protected readonly ajv: Ajv
+  protected readonly ajvIncomingRequest: Ajv
+  protected abstract jsonSchemasValidateFunction: Map<RequestCommand, ValidateFunction<JsonType>>
+  public abstract jsonSchemasIncomingRequestResponseValidateFunction: Map<
+  IncomingRequestCommand,
+  ValidateFunction<JsonType>
+  >
 
-  protected constructor(version: OCPPVersion) {
-    this.version = version;
+  protected constructor (version: OCPPVersion) {
+    this.version = version
     this.ajv = new Ajv({
       keywords: ['javaType'],
-      multipleOfPrecision: 2,
-    });
-    ajvFormats(this.ajv);
-    this.jsonRequestValidateFunctions = new Map<RequestCommand, ValidateFunction<JsonType>>();
-    this.jsonIncomingRequestResponseValidateFunctions = new Map<
-      IncomingRequestCommand,
-      ValidateFunction<JsonType>
-    >();
-    this.responseHandler = this.responseHandler.bind(this) as <
-      ReqType extends JsonType,
-      ResType extends JsonType,
-    >(
-      chargingStation: ChargingStation,
-      commandName: RequestCommand,
-      payload: ResType,
-      requestPayload: ReqType,
-    ) => Promise<void>;
-    this.validateResponsePayload = this.validateResponsePayload.bind(this) as <T extends JsonType>(
-      chargingStation: ChargingStation,
-      commandName: RequestCommand,
-      schema: JSONSchemaType<T>,
-      payload: T,
-    ) => boolean;
+      multipleOfPrecision: 2
+    })
+    ajvFormats(this.ajv)
+    this.ajvIncomingRequest = new Ajv({
+      keywords: ['javaType'],
+      multipleOfPrecision: 2
+    })
+    ajvFormats(this.ajvIncomingRequest)
+    this.responseHandler = this.responseHandler.bind(this)
+    this.validateResponsePayload = this.validateResponsePayload.bind(this)
   }
 
   public static getInstance<T extends OCPPResponseService>(this: new () => T): T {
     if (OCPPResponseService.instance === null) {
-      OCPPResponseService.instance = new this();
+      OCPPResponseService.instance = new this()
     }
-    return OCPPResponseService.instance as T;
+    return OCPPResponseService.instance as T
   }
 
   protected validateResponsePayload<T extends JsonType>(
     chargingStation: ChargingStation,
     commandName: RequestCommand,
-    schema: JSONSchemaType<T>,
-    payload: T,
+    payload: T
   ): boolean {
     if (chargingStation.stationInfo?.ocppStrictCompliance === false) {
-      return true;
+      return true
     }
-    const validate = this.getJsonRequestValidateFunction<T>(commandName, schema);
-    if (validate(payload)) {
-      return true;
+    const validate = this.jsonSchemasValidateFunction.get(commandName)
+    if (validate?.(payload) === true) {
+      return true
     }
     logger.error(
       `${chargingStation.logPrefix()} ${moduleName}.validateResponsePayload: Command '${commandName}' response PDU is invalid: %j`,
-      validate.errors,
-    );
+      validate?.errors
+    )
     throw new OCPPError(
-      OCPPServiceUtils.ajvErrorsToErrorType(validate.errors),
+      OCPPServiceUtils.ajvErrorsToErrorType(validate?.errors),
       'Response PDU is invalid',
       commandName,
-      JSON.stringify(validate.errors, undefined, 2),
-    );
+      JSON.stringify(validate?.errors, undefined, 2)
+    )
   }
 
-  protected emptyResponseHandler() {
-    /* This is intentional */
-  }
-
-  private getJsonRequestValidateFunction<T extends JsonType>(
-    commandName: RequestCommand,
-    schema: JSONSchemaType<T>,
-  ) {
-    if (this.jsonRequestValidateFunctions.has(commandName) === false) {
-      this.jsonRequestValidateFunctions.set(commandName, this.ajv.compile<T>(schema).bind(this));
-    }
-    return this.jsonRequestValidateFunctions.get(commandName)!;
-  }
+  protected emptyResponseHandler = Constants.EMPTY_FUNCTION
 
   public abstract responseHandler<ReqType extends JsonType, ResType extends JsonType>(
     chargingStation: ChargingStation,
     commandName: RequestCommand,
     payload: ResType,
-    requestPayload: ReqType,
-  ): Promise<void>;
+    requestPayload: ReqType
+  ): Promise<void>
 }