X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=.github%2Fworkflows%2Fci.yml;h=3419c5719e142d55a15ef939083623bd3cc4fa26;hb=059cf20e59d680db96e1d812dd6320ba9af55c1c;hp=112e3ac4ff57619c7bae99c4cf72843848c82229;hpb=1f82641b8caee6024addc4ec8f4c3215fca12cbb;p=poolifier.git

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 112e3ac4..3419c571 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -7,24 +7,25 @@ on:
     types: [opened, synchronize, reopened]
   merge_group:
     branches: [master]
-  workflow_dispatch:
-    inputs:
-      withBenchmark:
-        description: 'With Benchmark?'
-        default: false
+
+permissions:
+  contents: read
+  checks: read
 
 jobs:
   build:
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [windows-latest, macos-latest, ubuntu-latest]
         node: ['16.x', '18.x', '20.x']
 
+    name: Node.js ${{ matrix.node }} on ${{ matrix.os }}
+
+    runs-on: ${{ matrix.os }}
+
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis. This is needed for better sonar
 
@@ -33,35 +34,42 @@ jobs:
         with:
           version: 8
 
-      - name: Setup node ${{ matrix.node }}
+      - name: Setup Node.js ${{ matrix.node }}
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node }}
           cache: 'pnpm'
 
-      - name: Install
-        run: pnpm install
+      - name: Install Dependencies
+        run: pnpm install --ignore-scripts
 
       - name: Build
         run: pnpm build
 
       - name: Lint
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
         run: pnpm lint
 
       - name: Tests
         run: pnpm test
 
       - name: Coverage Report
-        if: "github.repository == 'poolifier/poolifier' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
         run: pnpm coverage
 
-      - name: Sonar Code Analysis
-        if: "github.repository == 'poolifier/poolifier' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x'"
-        uses: sonarsource/sonarcloud-github-action@v1.9.1
+      - name: Check for SonarCloud Token Availability
+        id: sonar-token
+        shell: bash
+        run: |
+          if [ "${{ secrets.SONAR_TOKEN }}" != '' ]; then
+            echo "available=true" >> $GITHUB_OUTPUT;
+          else
+            echo "available=false" >> $GITHUB_OUTPUT;
+          fi
+
+      - name: SonarCloud Code Analysis
+        if: ${{ steps.sonar-token.outputs.available == 'true' && github.repository == 'poolifier/poolifier' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
+        uses: sonarsource/sonarcloud-github-action@v2.0.2
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-
-      - name: Benchmark
-        if: github.event.inputs.withBenchmark
-        run: pnpm benchmark