X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=TP_13%2Fexo1%2Flib%2Farray.c;h=ec612c1f82bd769dee7883aca6228a96397ff91c;hb=475ee86d70921638c700bc0934441c7fe2c905d1;hp=c9a824676c26d89ca5acd337742cb57e8324b9ec;hpb=884e95575f85cb863b53910d203759a5cfc68d81;p=TD_C.git

diff --git a/TP_13/exo1/lib/array.c b/TP_13/exo1/lib/array.c
index c9a8246..ec612c1 100644
--- a/TP_13/exo1/lib/array.c
+++ b/TP_13/exo1/lib/array.c
@@ -1,43 +1,49 @@
 #include <stdlib.h>
+#include <stdio.h>
 
 #include "array.h"
 
-int create_tab(int tab[], unsigned tab_size) {
-    tab = malloc(sizeof(unsigned) * tab_size);
-    if (tab == NULL) {
-        return -1;
-    } else {
-        return 0;
+int* create_tab(int tab[], unsigned tab_size) {
+    tab = malloc(sizeof(int) * tab_size);
+    if (tab != NULL) {
+        /* initialize to zero the integer array */
+        for (unsigned i = 0; i < tab_size; i++) {
+            tab[i] = 0;
+        }
     }
+    return tab;
 }
 
 void free_tab(int tab[]) {
     free(tab);
 }
 
-/* we suppose both tab are already created */
-static void copy_tab(int src_tab[], int dest_tab[], unsigned min_tab_size, unsigned index_offset) {
-    /* FIXME: I think it's worth doing some sanity check on the array size */
-    for (unsigned i = 0; i < min_tab_size; i++) {
+/* we suppose both tabs are already created */
+static void copy_tab(int src_tab[], int dest_tab[], unsigned src_tab_size, unsigned index_offset) {
+    /* FIXME: I think it's worth doing some sanity checks on the array size:
+     * dest_tab_size >= src_tab_size */
+    if (src_tab == NULL || dest_tab == NULL) {
+        printf("please ensure you have created both arrays beforehand\n");
+        return;
+    }
+    for (unsigned i = 0; i < src_tab_size; i++) {
         dest_tab[i + index_offset] = src_tab[i];
     }
 }
 
-int concat_tab(int tab1[], unsigned tab_size1, int tab2[], unsigned tab_size2, int tab_dest[]) {
-    int rt = create_tab(tab_dest, tab_size1 + tab_size2);
+/* one must free the two source tabs in case they will be unused after to concatenation  */
+int* concat_tab(int tab1[], unsigned tab_size1, int tab2[], unsigned tab_size2) {
+    int* tab_dest = NULL;
+    tab_dest = create_tab(tab_dest, tab_size1 + tab_size2);
 
     copy_tab(tab1, tab_dest, tab_size1, 0);
     copy_tab(tab2, tab_dest, tab_size2, tab_size1);
-    return rt;
+    return tab_dest;
 }
 
-int resize_tab(int tab[], unsigned tab_size) {
-    tab = realloc(tab, sizeof(int) * tab_size);
-    if (tab == NULL) {
-        return -1;
-    } else {
-        return 0;
-    }
+int* resize_tab(int tab[], unsigned new_tab_size) {
+    tab = realloc(tab, sizeof(int) * new_tab_size);
+    return tab;
 }
 
 /* number of occurences of an element in an unsorted array  */