X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2FAutomaticTransactionGenerator.ts;h=3d1e8b1ccf2319dd694831d3792b337e60b7333d;hb=60400e2350178b24e06fc98e6f52cdb7317e03a3;hp=cdef826badef71331f21e68003a47c42841fd536;hpb=d9ac47efec22daef116af9fbdb3e7e01685e60fb;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/AutomaticTransactionGenerator.ts b/src/charging-station/AutomaticTransactionGenerator.ts index cdef826b..3d1e8b1c 100644 --- a/src/charging-station/AutomaticTransactionGenerator.ts +++ b/src/charging-station/AutomaticTransactionGenerator.ts @@ -1,103 +1,138 @@ -// Partial Copyright Jerome Benoit. 2021. All Rights Reserved. +// Partial Copyright Jerome Benoit. 2021-2023. All Rights Reserved. -import PerformanceStatistics from '../performance/PerformanceStatistics'; -import type { - AutomaticTransactionGeneratorConfiguration, - Status, -} from '../types/AutomaticTransactionGenerator'; -import { RequestCommand } from '../types/ocpp/Requests'; +import { AsyncResource } from 'node:async_hooks'; + +import { hoursToMilliseconds, secondsToMilliseconds } from 'date-fns'; + +import type { ChargingStation } from './ChargingStation'; +import { checkChargingStation } from './Helpers'; +import { IdTagsCache } from './IdTagsCache'; +import { OCPPServiceUtils } from './ocpp'; +import { BaseError } from '../exception'; +import { PerformanceStatistics } from '../performance'; import { AuthorizationStatus, - AuthorizeRequest, - AuthorizeResponse, - StartTransactionRequest, - StartTransactionResponse, + ConnectorStatusEnum, + RequestCommand, + type StartTransactionRequest, + type StartTransactionResponse, + type Status, StopTransactionReason, - StopTransactionResponse, -} from '../types/ocpp/Transaction'; -import Constants from '../utils/Constants'; -import logger from '../utils/Logger'; -import Utils from '../utils/Utils'; -import type ChargingStation from './ChargingStation'; + type StopTransactionResponse, +} from '../types'; +import { + Constants, + cloneObject, + formatDurationMilliSeconds, + getRandomInteger, + isNullOrUndefined, + logPrefix, + logger, + secureRandom, + sleep, +} from '../utils'; + +const moduleName = 'AutomaticTransactionGenerator'; -export default class AutomaticTransactionGenerator { +export class AutomaticTransactionGenerator extends AsyncResource { private static readonly instances: Map = new Map< string, AutomaticTransactionGenerator >(); public readonly connectorsStatus: Map; - public readonly configuration: AutomaticTransactionGeneratorConfiguration; public started: boolean; + private starting: boolean; + private stopping: boolean; private readonly chargingStation: ChargingStation; - private constructor( - automaticTransactionGeneratorConfiguration: AutomaticTransactionGeneratorConfiguration, - chargingStation: ChargingStation - ) { - this.configuration = automaticTransactionGeneratorConfiguration; + private constructor(chargingStation: ChargingStation) { + super(moduleName); + this.started = false; + this.starting = false; + this.stopping = false; this.chargingStation = chargingStation; this.connectorsStatus = new Map(); - this.stopConnectors(); - this.started = false; + this.initializeConnectorsStatus(); } public static getInstance( - automaticTransactionGeneratorConfiguration: AutomaticTransactionGeneratorConfiguration, - chargingStation: ChargingStation - ): AutomaticTransactionGenerator { - if (!AutomaticTransactionGenerator.instances.has(chargingStation.stationInfo.hashId)) { + chargingStation: ChargingStation, + ): AutomaticTransactionGenerator | undefined { + if (AutomaticTransactionGenerator.instances.has(chargingStation.stationInfo.hashId) === false) { AutomaticTransactionGenerator.instances.set( chargingStation.stationInfo.hashId, - new AutomaticTransactionGenerator( - automaticTransactionGeneratorConfiguration, - chargingStation - ) + new AutomaticTransactionGenerator(chargingStation), ); } return AutomaticTransactionGenerator.instances.get(chargingStation.stationInfo.hashId); } public start(): void { + if (checkChargingStation(this.chargingStation, this.logPrefix()) === false) { + return; + } if (this.started === true) { - logger.warn(`${this.logPrefix()} trying to start while already started`); + logger.warn(`${this.logPrefix()} is already started`); + return; + } + if (this.starting === true) { + logger.warn(`${this.logPrefix()} is already starting`); return; } + this.starting = true; this.startConnectors(); this.started = true; + this.starting = false; } public stop(): void { if (this.started === false) { - logger.warn(`${this.logPrefix()} trying to stop while not started`); + logger.warn(`${this.logPrefix()} is already stopped`); return; } + if (this.stopping === true) { + logger.warn(`${this.logPrefix()} is already stopping`); + return; + } + this.stopping = true; this.stopConnectors(); this.started = false; + this.stopping = false; } public startConnector(connectorId: number): void { - if (this.chargingStation.connectors.has(connectorId) === false) { - logger.warn(`${this.logPrefix(connectorId)} trying to start on non existing connector`); + if (checkChargingStation(this.chargingStation, this.logPrefix(connectorId)) === false) { return; } + if (this.connectorsStatus.has(connectorId) === false) { + logger.error(`${this.logPrefix(connectorId)} starting on non existing connector`); + throw new BaseError(`Connector ${connectorId} does not exist`); + } if (this.connectorsStatus.get(connectorId)?.start === false) { - // Avoid hogging the event loop with a busy loop - setImmediate(() => { - this.internalStartConnector(connectorId).catch(() => { - /* This is intentional */ - }); - }); + this.runInAsyncScope( + this.internalStartConnector.bind(this) as ( + this: AutomaticTransactionGenerator, + ...args: unknown[] + ) => Promise, + this, + connectorId, + ).catch(Constants.EMPTY_FUNCTION); } else if (this.connectorsStatus.get(connectorId)?.start === true) { - logger.warn(`${this.logPrefix(connectorId)} already started on connector`); + logger.warn(`${this.logPrefix(connectorId)} is already started on connector`); } } public stopConnector(connectorId: number): void { - this.connectorsStatus.set(connectorId, { - ...this.connectorsStatus.get(connectorId), - start: false, - }); + if (this.connectorsStatus.has(connectorId) === false) { + logger.error(`${this.logPrefix(connectorId)} stopping on non existing connector`); + throw new BaseError(`Connector ${connectorId} does not exist`); + } + if (this.connectorsStatus.get(connectorId)?.start === true) { + this.connectorsStatus.get(connectorId)!.start = false; + } else if (this.connectorsStatus.get(connectorId)?.start === false) { + logger.warn(`${this.logPrefix(connectorId)} is already stopped on connector`); + } } private startConnectors(): void { @@ -106,200 +141,307 @@ export default class AutomaticTransactionGenerator { this.connectorsStatus.size !== this.chargingStation.getNumberOfConnectors() ) { this.connectorsStatus.clear(); + this.initializeConnectorsStatus(); } - for (const connectorId of this.chargingStation.connectors.keys()) { - if (connectorId > 0) { - this.startConnector(connectorId); + if (this.chargingStation.hasEvses) { + for (const [evseId, evseStatus] of this.chargingStation.evses) { + if (evseId > 0) { + for (const connectorId of evseStatus.connectors.keys()) { + this.startConnector(connectorId); + } + } + } + } else { + for (const connectorId of this.chargingStation.connectors.keys()) { + if (connectorId > 0) { + this.startConnector(connectorId); + } } } } private stopConnectors(): void { - for (const connectorId of this.chargingStation.connectors.keys()) { - if (connectorId > 0) { - this.stopConnector(connectorId); + if (this.chargingStation.hasEvses) { + for (const [evseId, evseStatus] of this.chargingStation.evses) { + if (evseId > 0) { + for (const connectorId of evseStatus.connectors.keys()) { + this.stopConnector(connectorId); + } + } + } + } else { + for (const connectorId of this.chargingStation.connectors.keys()) { + if (connectorId > 0) { + this.stopConnector(connectorId); + } } } } private async internalStartConnector(connectorId: number): Promise { - this.initializeConnectorStatus(connectorId); + this.setStartConnectorStatus(connectorId); logger.info( - this.logPrefix(connectorId) + - ' started on connector and will run for ' + - Utils.formatDurationMilliSeconds( - this.connectorsStatus.get(connectorId).stopDate.getTime() - - this.connectorsStatus.get(connectorId).startDate.getTime() - ) + `${this.logPrefix( + connectorId, + )} started on connector and will run for ${formatDurationMilliSeconds( + this.connectorsStatus.get(connectorId)!.stopDate!.getTime() - + this.connectorsStatus.get(connectorId)!.startDate!.getTime(), + )}`, ); - while (this.connectorsStatus.get(connectorId).start === true) { - if (new Date() > this.connectorsStatus.get(connectorId).stopDate) { + while (this.connectorsStatus.get(connectorId)?.start === true) { + await this.waitChargingStationServiceInitialization(connectorId); + await this.waitChargingStationAvailable(connectorId); + await this.waitConnectorAvailable(connectorId); + if (!this.canStartConnector(connectorId)) { this.stopConnector(connectorId); break; } - if (!this.chargingStation.isInAcceptedState()) { - logger.error( - this.logPrefix(connectorId) + - ' entered in transaction loop while the charging station is not in accepted state' - ); - this.stopConnector(connectorId); - break; - } - if (!this.chargingStation.isChargingStationAvailable()) { - logger.info( - this.logPrefix(connectorId) + - ' entered in transaction loop while the charging station is unavailable' - ); - this.stopConnector(connectorId); - break; - } - if (!this.chargingStation.isConnectorAvailable(connectorId)) { - logger.info( - `${this.logPrefix( - connectorId - )} entered in transaction loop while the connector ${connectorId} is unavailable` - ); - this.stopConnector(connectorId); - break; - } - if (!this.chargingStation?.ocppRequestService) { - logger.info( - `${this.logPrefix( - connectorId - )} transaction loop waiting for charging station service to be initialized` - ); - do { - await Utils.sleep(Constants.CHARGING_STATION_ATG_INITIALIZATION_TIME); - } while (!this.chargingStation?.ocppRequestService); - } - const wait = - Utils.getRandomInteger( - this.configuration.maxDelayBetweenTwoTransactions, - this.configuration.minDelayBetweenTwoTransactions - ) * 1000; - logger.info( - this.logPrefix(connectorId) + ' waiting for ' + Utils.formatDurationMilliSeconds(wait) + const wait = secondsToMilliseconds( + getRandomInteger( + this.chargingStation.getAutomaticTransactionGeneratorConfiguration() + .maxDelayBetweenTwoTransactions, + this.chargingStation.getAutomaticTransactionGeneratorConfiguration() + .minDelayBetweenTwoTransactions, + ), ); - await Utils.sleep(wait); - const start = Utils.secureRandom(); - if (start < this.configuration.probabilityOfStart) { - this.connectorsStatus.get(connectorId).skippedConsecutiveTransactions = 0; + logger.info(`${this.logPrefix(connectorId)} waiting for ${formatDurationMilliSeconds(wait)}`); + await sleep(wait); + const start = secureRandom(); + if ( + start < + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().probabilityOfStart + ) { + this.connectorsStatus.get(connectorId)!.skippedConsecutiveTransactions = 0; // Start transaction const startResponse = await this.startTransaction(connectorId); if (startResponse?.idTagInfo?.status === AuthorizationStatus.ACCEPTED) { // Wait until end of transaction - const waitTrxEnd = - Utils.getRandomInteger(this.configuration.maxDuration, this.configuration.minDuration) * - 1000; - logger.info( - this.logPrefix(connectorId) + - ' transaction ' + - this.chargingStation.getConnectorStatus(connectorId).transactionId.toString() + - ' started and will stop in ' + - Utils.formatDurationMilliSeconds(waitTrxEnd) + const waitTrxEnd = secondsToMilliseconds( + getRandomInteger( + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().maxDuration, + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().minDuration, + ), ); - await Utils.sleep(waitTrxEnd); - // Stop transaction logger.info( - this.logPrefix(connectorId) + - ' stop transaction ' + - this.chargingStation.getConnectorStatus(connectorId).transactionId.toString() + `${this.logPrefix( + connectorId, + )} transaction started with id ${this.chargingStation.getConnectorStatus(connectorId) + ?.transactionId} and will stop in ${formatDurationMilliSeconds(waitTrxEnd)}`, ); + await sleep(waitTrxEnd); await this.stopTransaction(connectorId); } } else { - this.connectorsStatus.get(connectorId).skippedConsecutiveTransactions++; - this.connectorsStatus.get(connectorId).skippedTransactions++; + ++this.connectorsStatus.get(connectorId)!.skippedConsecutiveTransactions!; + ++this.connectorsStatus.get(connectorId)!.skippedTransactions!; logger.info( - this.logPrefix(connectorId) + - ' skipped consecutively ' + - this.connectorsStatus.get(connectorId).skippedConsecutiveTransactions.toString() + - '/' + - this.connectorsStatus.get(connectorId).skippedTransactions.toString() + - ' transaction(s)' + `${this.logPrefix(connectorId)} skipped consecutively ${this.connectorsStatus.get( + connectorId, + )?.skippedConsecutiveTransactions}/${this.connectorsStatus.get(connectorId) + ?.skippedTransactions} transaction(s)`, ); } - this.connectorsStatus.get(connectorId).lastRunDate = new Date(); + this.connectorsStatus.get(connectorId)!.lastRunDate = new Date(); } - this.connectorsStatus.get(connectorId).stoppedDate = new Date(); + this.connectorsStatus.get(connectorId)!.stoppedDate = new Date(); logger.info( - this.logPrefix(connectorId) + - ' stopped on connector and lasted for ' + - Utils.formatDurationMilliSeconds( - this.connectorsStatus.get(connectorId).stoppedDate.getTime() - - this.connectorsStatus.get(connectorId).startDate.getTime() - ) + `${this.logPrefix( + connectorId, + )} stopped on connector and lasted for ${formatDurationMilliSeconds( + this.connectorsStatus.get(connectorId)!.stoppedDate!.getTime() - + this.connectorsStatus.get(connectorId)!.startDate!.getTime(), + )}`, ); logger.debug( `${this.logPrefix(connectorId)} connector status: %j`, - this.connectorsStatus.get(connectorId) + this.connectorsStatus.get(connectorId), ); } - private initializeConnectorStatus(connectorId: number): void { - this.connectorsStatus.get(connectorId).authorizeRequests = - this?.connectorsStatus.get(connectorId)?.authorizeRequests ?? 0; - this.connectorsStatus.get(connectorId).acceptedAuthorizeRequests = - this?.connectorsStatus.get(connectorId)?.acceptedAuthorizeRequests ?? 0; - this.connectorsStatus.get(connectorId).rejectedAuthorizeRequests = - this?.connectorsStatus.get(connectorId)?.rejectedAuthorizeRequests ?? 0; - this.connectorsStatus.get(connectorId).startTransactionRequests = - this?.connectorsStatus.get(connectorId)?.startTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).acceptedStartTransactionRequests = - this?.connectorsStatus.get(connectorId)?.acceptedStartTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).rejectedStartTransactionRequests = - this?.connectorsStatus.get(connectorId)?.rejectedStartTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).stopTransactionRequests = - this?.connectorsStatus.get(connectorId)?.stopTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).acceptedStopTransactionRequests = - this?.connectorsStatus.get(connectorId)?.acceptedStopTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).rejectedStopTransactionRequests = - this?.connectorsStatus.get(connectorId)?.rejectedStopTransactionRequests ?? 0; - this.connectorsStatus.get(connectorId).skippedConsecutiveTransactions = 0; - this.connectorsStatus.get(connectorId).skippedTransactions = - this?.connectorsStatus.get(connectorId)?.skippedTransactions ?? 0; + private setStartConnectorStatus(connectorId: number): void { + this.connectorsStatus.get(connectorId)!.skippedConsecutiveTransactions = 0; const previousRunDuration = - this?.connectorsStatus.get(connectorId)?.startDate && - this?.connectorsStatus.get(connectorId)?.lastRunDate - ? this.connectorsStatus.get(connectorId).lastRunDate.getTime() - - this.connectorsStatus.get(connectorId).startDate.getTime() + this.connectorsStatus.get(connectorId)?.startDate && + this.connectorsStatus.get(connectorId)?.lastRunDate + ? this.connectorsStatus.get(connectorId)!.lastRunDate!.getTime() - + this.connectorsStatus.get(connectorId)!.startDate!.getTime() : 0; - this.connectorsStatus.get(connectorId).startDate = new Date(); - this.connectorsStatus.get(connectorId).stopDate = new Date( - this.connectorsStatus.get(connectorId).startDate.getTime() + - (this.configuration.stopAfterHours ?? - Constants.CHARGING_STATION_ATG_DEFAULT_STOP_AFTER_HOURS) * - 3600 * - 1000 - - previousRunDuration + this.connectorsStatus.get(connectorId)!.startDate = new Date(); + this.connectorsStatus.get(connectorId)!.stopDate = new Date( + this.connectorsStatus.get(connectorId)!.startDate!.getTime() + + hoursToMilliseconds( + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().stopAfterHours, + ) - + previousRunDuration, + ); + this.connectorsStatus.get(connectorId)!.start = true; + } + + private canStartConnector(connectorId: number): boolean { + if (new Date() > this.connectorsStatus.get(connectorId)!.stopDate!) { + return false; + } + if (this.chargingStation.inAcceptedState() === false) { + logger.error( + `${this.logPrefix( + connectorId, + )} entered in transaction loop while the charging station is not in accepted state`, + ); + return false; + } + if (this.chargingStation.isChargingStationAvailable() === false) { + logger.info( + `${this.logPrefix( + connectorId, + )} entered in transaction loop while the charging station is unavailable`, + ); + return false; + } + if (this.chargingStation.isConnectorAvailable(connectorId) === false) { + logger.info( + `${this.logPrefix( + connectorId, + )} entered in transaction loop while the connector ${connectorId} is unavailable`, + ); + return false; + } + if ( + this.chargingStation.getConnectorStatus(connectorId)?.status === + ConnectorStatusEnum.Unavailable + ) { + logger.info( + `${this.logPrefix( + connectorId, + )} entered in transaction loop while the connector ${connectorId} status is unavailable`, + ); + return false; + } + return true; + } + + private async waitChargingStationServiceInitialization(connectorId: number): Promise { + let logged = false; + while (!this.chargingStation?.ocppRequestService) { + if (!logged) { + logger.info( + `${this.logPrefix( + connectorId, + )} transaction loop waiting for charging station service to be initialized`, + ); + logged = true; + } + await sleep(Constants.CHARGING_STATION_ATG_INITIALIZATION_TIME); + } + } + + private async waitChargingStationAvailable(connectorId: number): Promise { + let logged = false; + while (!this.chargingStation.isChargingStationAvailable()) { + if (!logged) { + logger.info( + `${this.logPrefix( + connectorId, + )} transaction loop waiting for charging station to be available`, + ); + logged = true; + } + await sleep(Constants.CHARGING_STATION_ATG_AVAILABILITY_TIME); + } + } + + private async waitConnectorAvailable(connectorId: number): Promise { + let logged = false; + while (!this.chargingStation.isConnectorAvailable(connectorId)) { + if (!logged) { + logger.info( + `${this.logPrefix( + connectorId, + )} transaction loop waiting for connector ${connectorId} to be available`, + ); + logged = true; + } + await sleep(Constants.CHARGING_STATION_ATG_AVAILABILITY_TIME); + } + } + + private initializeConnectorsStatus(): void { + if (this.chargingStation.hasEvses) { + for (const [evseId, evseStatus] of this.chargingStation.evses) { + if (evseId > 0) { + for (const connectorId of evseStatus.connectors.keys()) { + this.connectorsStatus.set(connectorId, this.getConnectorStatus(connectorId)); + } + } + } + } else { + for (const connectorId of this.chargingStation.connectors.keys()) { + if (connectorId > 0) { + this.connectorsStatus.set(connectorId, this.getConnectorStatus(connectorId)); + } + } + } + } + + private getConnectorStatus(connectorId: number): Status { + const connectorStatus = this.chargingStation.getAutomaticTransactionGeneratorStatuses()?.[ + connectorId + ] + ? cloneObject( + this.chargingStation.getAutomaticTransactionGeneratorStatuses()![connectorId], + ) + : undefined; + this.resetConnectorStatus(connectorStatus); + return ( + connectorStatus ?? { + start: false, + authorizeRequests: 0, + acceptedAuthorizeRequests: 0, + rejectedAuthorizeRequests: 0, + startTransactionRequests: 0, + acceptedStartTransactionRequests: 0, + rejectedStartTransactionRequests: 0, + stopTransactionRequests: 0, + acceptedStopTransactionRequests: 0, + rejectedStopTransactionRequests: 0, + skippedConsecutiveTransactions: 0, + skippedTransactions: 0, + } ); - this.connectorsStatus.get(connectorId).start = true; + } + + private resetConnectorStatus(connectorStatus: Status | undefined): void { + delete connectorStatus?.startDate; + delete connectorStatus?.lastRunDate; + delete connectorStatus?.stopDate; + delete connectorStatus?.stoppedDate; + if ( + !this.started && + (connectorStatus?.start === true || + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().enable === false) + ) { + connectorStatus!.start = false; + } } private async startTransaction( - connectorId: number + connectorId: number, ): Promise { const measureId = 'StartTransaction with ATG'; const beginId = PerformanceStatistics.beginMeasure(measureId); - let startResponse: StartTransactionResponse; - if (this.chargingStation.hasAuthorizedTags()) { - const idTag = this.chargingStation.getRandomIdTag(); + let startResponse: StartTransactionResponse | undefined; + if (this.chargingStation.hasIdTags()) { + const idTag = IdTagsCache.getInstance().getIdTag( + this.chargingStation.getAutomaticTransactionGeneratorConfiguration().idTagDistribution!, + this.chargingStation, + connectorId, + ); const startTransactionLogMsg = `${this.logPrefix( - connectorId - )} start transaction for idTag '${idTag}'`; + connectorId, + )} start transaction with an idTag '${idTag}'`; if (this.getRequireAuthorize()) { - this.chargingStation.getConnectorStatus(connectorId).authorizeIdTag = idTag; - // Authorize idTag - const authorizeResponse: AuthorizeResponse = - await this.chargingStation.ocppRequestService.requestHandler< - AuthorizeRequest, - AuthorizeResponse - >(this.chargingStation, RequestCommand.AUTHORIZE, { - idTag, - }); - this.connectorsStatus.get(connectorId).authorizeRequests++; - if (authorizeResponse?.idTagInfo?.status === AuthorizationStatus.ACCEPTED) { - this.connectorsStatus.get(connectorId).acceptedAuthorizeRequests++; + ++this.connectorsStatus.get(connectorId)!.authorizeRequests!; + if (await OCPPServiceUtils.isIdTagAuthorized(this.chargingStation, connectorId, idTag)) { + ++this.connectorsStatus.get(connectorId)!.acceptedAuthorizeRequests!; logger.info(startTransactionLogMsg); // Start transaction startResponse = await this.chargingStation.ocppRequestService.requestHandler< @@ -313,7 +455,7 @@ export default class AutomaticTransactionGenerator { PerformanceStatistics.endMeasure(measureId, beginId); return startResponse; } - this.connectorsStatus.get(connectorId).rejectedAuthorizeRequests++; + ++this.connectorsStatus.get(connectorId)!.rejectedAuthorizeRequests!; PerformanceStatistics.endMeasure(measureId, beginId); return startResponse; } @@ -335,31 +477,38 @@ export default class AutomaticTransactionGenerator { StartTransactionRequest, StartTransactionResponse >(this.chargingStation, RequestCommand.START_TRANSACTION, { connectorId }); + this.handleStartTransactionResponse(connectorId, startResponse); PerformanceStatistics.endMeasure(measureId, beginId); return startResponse; } private async stopTransaction( connectorId: number, - reason: StopTransactionReason = StopTransactionReason.LOCAL - ): Promise { + reason = StopTransactionReason.LOCAL, + ): Promise { const measureId = 'StopTransaction with ATG'; const beginId = PerformanceStatistics.beginMeasure(measureId); - let stopResponse: StopTransactionResponse; + let stopResponse: StopTransactionResponse | undefined; if (this.chargingStation.getConnectorStatus(connectorId)?.transactionStarted === true) { + logger.info( + `${this.logPrefix( + connectorId, + )} stop transaction with id ${this.chargingStation.getConnectorStatus(connectorId) + ?.transactionId}`, + ); stopResponse = await this.chargingStation.stopTransactionOnConnector(connectorId, reason); - this.connectorsStatus.get(connectorId).stopTransactionRequests++; + ++this.connectorsStatus.get(connectorId)!.stopTransactionRequests!; if (stopResponse?.idTagInfo?.status === AuthorizationStatus.ACCEPTED) { - this.connectorsStatus.get(connectorId).acceptedStopTransactionRequests++; + ++this.connectorsStatus.get(connectorId)!.acceptedStopTransactionRequests!; } else { - this.connectorsStatus.get(connectorId).rejectedStopTransactionRequests++; + ++this.connectorsStatus.get(connectorId)!.rejectedStopTransactionRequests!; } } else { - const transactionId = this.chargingStation.getConnectorStatus(connectorId).transactionId; - logger.warn( - `${this.logPrefix(connectorId)} trying to stop a not started transaction${ - transactionId ? ' ' + transactionId.toString() : '' - }` + const transactionId = this.chargingStation.getConnectorStatus(connectorId)?.transactionId; + logger.debug( + `${this.logPrefix(connectorId)} stopping a not started transaction${ + !isNullOrUndefined(transactionId) ? ` with id ${transactionId}` : '' + }`, ); } PerformanceStatistics.endMeasure(measureId, beginId); @@ -367,27 +516,29 @@ export default class AutomaticTransactionGenerator { } private getRequireAuthorize(): boolean { - return this.configuration?.requireAuthorize ?? true; + return ( + this.chargingStation.getAutomaticTransactionGeneratorConfiguration()?.requireAuthorize ?? true + ); } - private logPrefix(connectorId?: number): string { - return Utils.logPrefix( + private logPrefix = (connectorId?: number): string => { + return logPrefix( ` ${this.chargingStation.stationInfo.chargingStationId} | ATG${ - connectorId !== undefined ? ` on connector #${connectorId.toString()}` : '' - }:` + !isNullOrUndefined(connectorId) ? ` on connector #${connectorId}` : '' + }:`, ); - } + }; private handleStartTransactionResponse( connectorId: number, - startResponse: StartTransactionResponse + startResponse: StartTransactionResponse, ): void { - this.connectorsStatus.get(connectorId).startTransactionRequests++; + ++this.connectorsStatus.get(connectorId)!.startTransactionRequests!; if (startResponse?.idTagInfo?.status === AuthorizationStatus.ACCEPTED) { - this.connectorsStatus.get(connectorId).acceptedStartTransactionRequests++; + ++this.connectorsStatus.get(connectorId)!.acceptedStartTransactionRequests!; } else { - logger.warn(this.logPrefix(connectorId) + ' start transaction rejected'); - this.connectorsStatus.get(connectorId).rejectedStartTransactionRequests++; + logger.warn(`${this.logPrefix(connectorId)} start transaction rejected`); + ++this.connectorsStatus.get(connectorId)!.rejectedStartTransactionRequests!; } } }