X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Focpp%2F1.6%2FOCPP16ResponseService.ts;h=68e9f7c66cae6febf94318a5a5523ef5ee4d6e3d;hb=411894569d4a0333a4e38e911a178520a69448cd;hp=3372e1036c1ce464e7e1700fb87cca114177170a;hpb=844e496b3482e49145467af3f74df54811e91cb6;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts b/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts index 3372e103..68e9f7c6 100644 --- a/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts +++ b/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts @@ -1,139 +1,286 @@ -// Partial Copyright Jerome Benoit. 2021. All Rights Reserved. +// Partial Copyright Jerome Benoit. 2021-2023. All Rights Reserved. -import fs from 'fs'; -import path from 'path'; -import { fileURLToPath } from 'url'; +import type { JSONSchemaType } from 'ajv'; -import { JSONSchemaType } from 'ajv'; - -import OCPPError from '../../../exception/OCPPError'; -import { JsonType } from '../../../types/JsonType'; -import { OCPP16ChargePointErrorCode } from '../../../types/ocpp/1.6/ChargePointErrorCode'; -import { OCPP16ChargePointStatus } from '../../../types/ocpp/1.6/ChargePointStatus'; -import { OCPP16StandardParametersKey } from '../../../types/ocpp/1.6/Configuration'; -import { - OCPP16MeterValuesRequest, - OCPP16MeterValuesResponse, -} from '../../../types/ocpp/1.6/MeterValues'; -import { - OCPP16BootNotificationRequest, - OCPP16RequestCommand, - OCPP16StatusNotificationRequest, -} from '../../../types/ocpp/1.6/Requests'; -import { - OCPP16BootNotificationResponse, - OCPP16HeartbeatResponse, - OCPP16RegistrationStatus, - OCPP16StatusNotificationResponse, -} from '../../../types/ocpp/1.6/Responses'; +import { type ChargingStation, ChargingStationConfigurationUtils } from '../../../charging-station'; +import { OCPPError } from '../../../exception'; import { + type ChangeAvailabilityResponse, + type ChangeConfigurationResponse, + type ClearChargingProfileResponse, + ErrorType, + type GenericResponse, + type GetConfigurationResponse, + type GetDiagnosticsResponse, + type JsonObject, + type JsonType, OCPP16AuthorizationStatus, - OCPP16AuthorizeRequest, - OCPP16AuthorizeResponse, - OCPP16StartTransactionRequest, - OCPP16StartTransactionResponse, - OCPP16StopTransactionRequest, - OCPP16StopTransactionResponse, -} from '../../../types/ocpp/1.6/Transaction'; -import { ErrorType } from '../../../types/ocpp/ErrorType'; -import { ResponseHandler } from '../../../types/ocpp/Responses'; -import logger from '../../../utils/Logger'; -import Utils from '../../../utils/Utils'; -import type ChargingStation from '../../ChargingStation'; -import { ChargingStationConfigurationUtils } from '../../ChargingStationConfigurationUtils'; -import { ChargingStationUtils } from '../../ChargingStationUtils'; -import OCPPResponseService from '../OCPPResponseService'; -import { OCPP16ServiceUtils } from './OCPP16ServiceUtils'; + type OCPP16AuthorizeRequest, + type OCPP16AuthorizeResponse, + type OCPP16BootNotificationRequest, + type OCPP16BootNotificationResponse, + OCPP16ChargePointErrorCode, + OCPP16ChargePointStatus, + type OCPP16DataTransferResponse, + type OCPP16DiagnosticsStatusNotificationResponse, + type OCPP16FirmwareStatusNotificationResponse, + type OCPP16GetCompositeScheduleResponse, + type OCPP16HeartbeatResponse, + OCPP16IncomingRequestCommand, + type OCPP16MeterValuesRequest, + type OCPP16MeterValuesResponse, + OCPP16RequestCommand, + OCPP16StandardParametersKey, + type OCPP16StartTransactionRequest, + type OCPP16StartTransactionResponse, + type OCPP16StatusNotificationRequest, + type OCPP16StatusNotificationResponse, + type OCPP16StopTransactionRequest, + type OCPP16StopTransactionResponse, + type OCPP16TriggerMessageResponse, + type OCPP16UpdateFirmwareResponse, + OCPPVersion, + RegistrationStatusEnumType, + type ResponseHandler, + type SetChargingProfileResponse, + type UnlockConnectorResponse, +} from '../../../types'; +import { Constants, Utils, logger } from '../../../utils'; +import { OCPP16ServiceUtils, OCPPResponseService } from '../internal'; const moduleName = 'OCPP16ResponseService'; -export default class OCPP16ResponseService extends OCPPResponseService { +export class OCPP16ResponseService extends OCPPResponseService { + public jsonIncomingRequestResponseSchemas: Map< + OCPP16IncomingRequestCommand, + JSONSchemaType + >; + private responseHandlers: Map; - private bootNotificationResponseJsonSchema: JSONSchemaType; - private heartbeatResponseJsonSchema: JSONSchemaType; - private authorizeResponseJsonSchema: JSONSchemaType; - private startTransactionResponseJsonSchema: JSONSchemaType; - private stopTransactionResponseJsonSchema: JSONSchemaType; - private statusNotificationResponseJsonSchema: JSONSchemaType; - private meterValuesResponseJsonSchema: JSONSchemaType; + private jsonSchemas: Map>; public constructor() { - if (new.target?.name === moduleName) { - throw new TypeError(`Cannot construct ${new.target?.name} instances directly`); - } - super(); + // if (new.target?.name === moduleName) { + // throw new TypeError(`Cannot construct ${new.target?.name} instances directly`); + // } + super(OCPPVersion.VERSION_16); this.responseHandlers = new Map([ [OCPP16RequestCommand.BOOT_NOTIFICATION, this.handleResponseBootNotification.bind(this)], - [OCPP16RequestCommand.HEARTBEAT, this.handleResponseHeartbeat.bind(this)], + [OCPP16RequestCommand.HEARTBEAT, this.emptyResponseHandler.bind(this)], [OCPP16RequestCommand.AUTHORIZE, this.handleResponseAuthorize.bind(this)], [OCPP16RequestCommand.START_TRANSACTION, this.handleResponseStartTransaction.bind(this)], [OCPP16RequestCommand.STOP_TRANSACTION, this.handleResponseStopTransaction.bind(this)], - [OCPP16RequestCommand.STATUS_NOTIFICATION, this.handleResponseStatusNotification.bind(this)], - [OCPP16RequestCommand.METER_VALUES, this.handleResponseMeterValues.bind(this)], + [OCPP16RequestCommand.STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], + [OCPP16RequestCommand.METER_VALUES, this.emptyResponseHandler.bind(this)], + [OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], + [OCPP16RequestCommand.DATA_TRANSFER, this.emptyResponseHandler.bind(this)], + [OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], + ]); + this.jsonSchemas = new Map>([ + [ + OCPP16RequestCommand.BOOT_NOTIFICATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/BootNotificationResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.HEARTBEAT, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/HeartbeatResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.AUTHORIZE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/AuthorizeResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.START_TRANSACTION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/StartTransactionResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.STOP_TRANSACTION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/StopTransactionResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.STATUS_NOTIFICATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/StatusNotificationResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.METER_VALUES, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/MeterValuesResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/DiagnosticsStatusNotificationResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.DATA_TRANSFER, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/DataTransferResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/FirmwareStatusNotificationResponse.json', + moduleName, + 'constructor' + ), + ], ]); - this.bootNotificationResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/BootNotificationResponse.json' + this.jsonIncomingRequestResponseSchemas = new Map([ + [ + OCPP16IncomingRequestCommand.RESET, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/ResetResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.CLEAR_CACHE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/ClearCacheResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.CHANGE_AVAILABILITY, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/ChangeAvailabilityResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.UNLOCK_CONNECTOR, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/UnlockConnectorResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.GET_CONFIGURATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/GetConfigurationResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.CHANGE_CONFIGURATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/ChangeConfigurationResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.GET_COMPOSITE_SCHEDULE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/GetCompositeScheduleResponse.json', + moduleName, + 'constructor' + ), + ], + [ + OCPP16IncomingRequestCommand.SET_CHARGING_PROFILE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/SetChargingProfileResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.heartbeatResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/HeartbeatResponse.json' + ], + [ + OCPP16IncomingRequestCommand.CLEAR_CHARGING_PROFILE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/ClearChargingProfileResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.authorizeResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/AuthorizeResponse.json' + ], + [ + OCPP16IncomingRequestCommand.REMOTE_START_TRANSACTION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/RemoteStartTransactionResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.startTransactionResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/StartTransactionResponse.json' + ], + [ + OCPP16IncomingRequestCommand.REMOTE_STOP_TRANSACTION, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/RemoteStopTransactionResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.stopTransactionResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/StopTransactionResponse.json' + ], + [ + OCPP16IncomingRequestCommand.GET_DIAGNOSTICS, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/GetDiagnosticsResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.statusNotificationResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/StatusNotificationResponse.json' + ], + [ + OCPP16IncomingRequestCommand.TRIGGER_MESSAGE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/TriggerMessageResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; - this.meterValuesResponseJsonSchema = JSON.parse( - fs.readFileSync( - path.resolve( - path.dirname(fileURLToPath(import.meta.url)), - '../../../assets/json-schemas/ocpp/1.6/MeterValuesResponse.json' + ], + [ + OCPP16IncomingRequestCommand.DATA_TRANSFER, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/DataTransferResponse.json', + moduleName, + 'constructor' ), - 'utf8' - ) - ) as JSONSchemaType; + ], + [ + OCPP16IncomingRequestCommand.UPDATE_FIRMWARE, + OCPP16ServiceUtils.parseJsonSchemaFile( + '../../../assets/json-schemas/ocpp/1.6/UpdateFirmwareResponse.json', + moduleName, + 'constructor' + ), + ], + ]); + this.validatePayload.bind(this); } public async responseHandler( @@ -142,22 +289,29 @@ export default class OCPP16ResponseService extends OCPPResponseService { payload: JsonType, requestPayload: JsonType ): Promise { - if (chargingStation.isRegistered() || commandName === OCPP16RequestCommand.BOOT_NOTIFICATION) { + if ( + chargingStation.isRegistered() === true || + commandName === OCPP16RequestCommand.BOOT_NOTIFICATION + ) { if ( - this.responseHandlers.has(commandName) && - ChargingStationUtils.isRequestCommandSupported(commandName, chargingStation) + this.responseHandlers.has(commandName) === true && + OCPP16ServiceUtils.isRequestCommandSupported(chargingStation, commandName) === true ) { try { + this.validatePayload(chargingStation, commandName, payload); await this.responseHandlers.get(commandName)(chargingStation, payload, requestPayload); } catch (error) { - logger.error(chargingStation.logPrefix() + ' Handle request response error: %j', error); + logger.error( + `${chargingStation.logPrefix()} ${moduleName}.responseHandler: Handle response error:`, + error + ); throw error; } } else { // Throw exception throw new OCPPError( ErrorType.NOT_IMPLEMENTED, - `${commandName} is not implemented to handle request response PDU ${JSON.stringify( + `${commandName} is not implemented to handle response PDU ${JSON.stringify( payload, null, 2 @@ -169,28 +323,41 @@ export default class OCPP16ResponseService extends OCPPResponseService { } else { throw new OCPPError( ErrorType.SECURITY_ERROR, - `${commandName} cannot be issued to handle request response PDU ${JSON.stringify( + `${commandName} cannot be issued to handle response PDU ${JSON.stringify( payload, null, 2 - )} while the charging station is not registered on the central server. `, + )} while the charging station is not registered on the central server.`, + commandName, + payload + ); + } + } + + private validatePayload( + chargingStation: ChargingStation, + commandName: OCPP16RequestCommand, + payload: JsonType + ): boolean { + if (this.jsonSchemas.has(commandName) === true) { + return this.validateResponsePayload( + chargingStation, commandName, + this.jsonSchemas.get(commandName), payload ); } + logger.warn( + `${chargingStation.logPrefix()} ${moduleName}.validatePayload: No JSON schema found for command '${commandName}' PDU validation` + ); + return false; } private handleResponseBootNotification( chargingStation: ChargingStation, payload: OCPP16BootNotificationResponse ): void { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.BOOT_NOTIFICATION, - this.bootNotificationResponseJsonSchema, - payload - ); - if (payload.status === OCPP16RegistrationStatus.ACCEPTED) { + if (payload.status === RegistrationStatusEnumType.ACCEPTED) { ChargingStationConfigurationUtils.addConfigurationKey( chargingStation, OCPP16StandardParametersKey.HeartbeatInterval, @@ -205,49 +372,28 @@ export default class OCPP16ResponseService extends OCPPResponseService { { visible: false }, { overwrite: true, save: true } ); - chargingStation.heartbeatSetInterval - ? chargingStation.restartHeartbeat() - : chargingStation.startHeartbeat(); + OCPP16ServiceUtils.startHeartbeatInterval(chargingStation, payload.interval); } - if (Object.values(OCPP16RegistrationStatus).includes(payload.status)) { + if (Object.values(RegistrationStatusEnumType).includes(payload.status)) { const logMsg = `${chargingStation.logPrefix()} Charging station in '${ payload.status }' state on the central server`; - payload.status === OCPP16RegistrationStatus.REJECTED + payload.status === RegistrationStatusEnumType.REJECTED ? logger.warn(logMsg) : logger.info(logMsg); } else { logger.error( - chargingStation.logPrefix() + - ' Charging station boot notification response received: %j with undefined registration status', + `${chargingStation.logPrefix()} Charging station boot notification response received: %j with undefined registration status`, payload ); } } - private handleResponseHeartbeat( - chargingStation: ChargingStation, - payload: OCPP16HeartbeatResponse - ): void { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.HEARTBEAT, - this.heartbeatResponseJsonSchema, - payload - ); - } - private handleResponseAuthorize( chargingStation: ChargingStation, payload: OCPP16AuthorizeResponse, requestPayload: OCPP16AuthorizeRequest ): void { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.AUTHORIZE, - this.authorizeResponseJsonSchema, - payload - ); let authorizeConnectorId: number; for (const connectorId of chargingStation.connectors.keys()) { if ( @@ -258,20 +404,24 @@ export default class OCPP16ResponseService extends OCPPResponseService { break; } } + const authorizeConnectorIdDefined = authorizeConnectorId !== undefined; if (payload.idTagInfo.status === OCPP16AuthorizationStatus.ACCEPTED) { - chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = true; + authorizeConnectorIdDefined && + (chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = true); logger.debug( - `${chargingStation.logPrefix()} IdTag ${ - requestPayload.idTag - } authorized on connector ${authorizeConnectorId}` + `${chargingStation.logPrefix()} IdTag '${requestPayload.idTag}' accepted${ + authorizeConnectorIdDefined ? ` on connector ${authorizeConnectorId}` : '' + }` ); } else { - chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = false; - delete chargingStation.getConnectorStatus(authorizeConnectorId).authorizeIdTag; + if (authorizeConnectorIdDefined) { + chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = false; + delete chargingStation.getConnectorStatus(authorizeConnectorId)?.authorizeIdTag; + } logger.debug( - `${chargingStation.logPrefix()} IdTag ${requestPayload.idTag} refused with status '${ + `${chargingStation.logPrefix()} IdTag '${requestPayload.idTag}' rejected with status '${ payload.idTagInfo.status - }' on connector ${authorizeConnectorId}` + }'${authorizeConnectorIdDefined ? ` on connector ${authorizeConnectorId}` : ''}` ); } } @@ -281,12 +431,6 @@ export default class OCPP16ResponseService extends OCPPResponseService { payload: OCPP16StartTransactionResponse, requestPayload: OCPP16StartTransactionRequest ): Promise { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.START_TRANSACTION, - this.startTransactionResponseJsonSchema, - payload - ); const connectorId = requestPayload.connectorId; let transactionConnectorId: number; @@ -296,94 +440,81 @@ export default class OCPP16ResponseService extends OCPPResponseService { break; } } - if (!transactionConnectorId) { + if (Utils.isNullOrUndefined(transactionConnectorId)) { logger.error( - chargingStation.logPrefix() + - ' Trying to start a transaction on a non existing connector Id ' + - connectorId.toString() + `${chargingStation.logPrefix()} Trying to start a transaction on a non existing connector Id ${connectorId.toString()}` ); return; } if ( - chargingStation.getConnectorStatus(connectorId).transactionRemoteStarted && - chargingStation.getAuthorizeRemoteTxRequests() && - chargingStation.getLocalAuthListEnabled() && - chargingStation.hasAuthorizedTags() && - !chargingStation.getConnectorStatus(connectorId).idTagLocalAuthorized + chargingStation.getConnectorStatus(connectorId)?.transactionRemoteStarted === true && + chargingStation.getAuthorizeRemoteTxRequests() === true && + chargingStation.getLocalAuthListEnabled() === true && + chargingStation.hasIdTags() && + chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized === false ) { logger.error( - chargingStation.logPrefix() + - ' Trying to start a transaction with a not local authorized idTag ' + - chargingStation.getConnectorStatus(connectorId).localAuthorizeIdTag + - ' on connector Id ' + - connectorId.toString() + `${chargingStation.logPrefix()} Trying to start a transaction with a not local authorized idTag ${ + chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag + } on connector Id ${connectorId.toString()}` ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId).transactionRemoteStarted && - chargingStation.getAuthorizeRemoteTxRequests() && - chargingStation.getMayAuthorizeAtRemoteStart() && - !chargingStation.getConnectorStatus(connectorId).idTagLocalAuthorized && - !chargingStation.getConnectorStatus(connectorId).idTagAuthorized + chargingStation.getConnectorStatus(connectorId)?.transactionRemoteStarted === true && + chargingStation.getAuthorizeRemoteTxRequests() === true && + chargingStation.getMustAuthorizeAtRemoteStart() === true && + chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized === false && + chargingStation.getConnectorStatus(connectorId)?.idTagAuthorized === false ) { logger.error( - chargingStation.logPrefix() + - ' Trying to start a transaction with a not authorized idTag ' + - chargingStation.getConnectorStatus(connectorId).authorizeIdTag + - ' on connector Id ' + - connectorId.toString() + `${chargingStation.logPrefix()} Trying to start a transaction with a not authorized idTag ${ + chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag + } on connector Id ${connectorId.toString()}` ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId).idTagAuthorized && - chargingStation.getConnectorStatus(connectorId).authorizeIdTag !== requestPayload.idTag + chargingStation.getConnectorStatus(connectorId)?.idTagAuthorized && + chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag !== requestPayload.idTag ) { logger.error( - chargingStation.logPrefix() + - ' Trying to start a transaction with an idTag ' + - requestPayload.idTag + - ' different from the authorize request one ' + - chargingStation.getConnectorStatus(connectorId).authorizeIdTag + - ' on connector Id ' + - connectorId.toString() + `${chargingStation.logPrefix()} Trying to start a transaction with an idTag ${ + requestPayload.idTag + } different from the authorize request one ${ + chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag + } on connector Id ${connectorId.toString()}` ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId).idTagLocalAuthorized && - chargingStation.getConnectorStatus(connectorId).localAuthorizeIdTag !== requestPayload.idTag + chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized && + chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag !== requestPayload.idTag ) { logger.error( - chargingStation.logPrefix() + - ' Trying to start a transaction with an idTag ' + - requestPayload.idTag + - ' different from the local authorized one ' + - chargingStation.getConnectorStatus(connectorId).localAuthorizeIdTag + - ' on connector Id ' + - connectorId.toString() + `${chargingStation.logPrefix()} Trying to start a transaction with an idTag ${ + requestPayload.idTag + } different from the local authorized one ${ + chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag + } on connector Id ${connectorId.toString()}` ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } - if (chargingStation.getConnectorStatus(connectorId)?.transactionStarted) { + if (chargingStation.getConnectorStatus(connectorId)?.transactionStarted === true) { logger.debug( - chargingStation.logPrefix() + - ' Trying to start a transaction on an already used connector ' + - connectorId.toString() + - ': %j', + `${chargingStation.logPrefix()} Trying to start a transaction on an already used connector ${connectorId.toString()}: %j`, chargingStation.getConnectorStatus(connectorId) ); return; } if ( chargingStation.getConnectorStatus(connectorId)?.status !== - OCPP16ChargePointStatus.AVAILABLE && - chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.PREPARING + OCPP16ChargePointStatus.Available && + chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.Preparing ) { logger.error( `${chargingStation.logPrefix()} Trying to start a transaction on connector ${connectorId.toString()} with status ${ @@ -392,14 +523,14 @@ export default class OCPP16ResponseService extends OCPPResponseService { ); return; } - if (!Number.isInteger(payload.transactionId)) { - logger.warn( - `${chargingStation.logPrefix()} Trying to start a transaction on connector ${connectorId.toString()} with a non integer transaction Id ${ - payload.transactionId - }, converting to integer` - ); - payload.transactionId = Utils.convertToInt(payload.transactionId); - } + // if (!Number.isInteger(payload.transactionId)) { + // logger.warn( + // `${chargingStation.logPrefix()} Trying to start a transaction on connector ${connectorId.toString()} with a non integer transaction Id ${ + // payload.transactionId + // }, converting to integer` + // ); + // payload.transactionId = Utils.convertToInt(payload.transactionId); + // } if (payload.idTagInfo?.status === OCPP16AuthorizationStatus.ACCEPTED) { chargingStation.getConnectorStatus(connectorId).transactionStarted = true; @@ -428,20 +559,14 @@ export default class OCPP16ResponseService extends OCPPResponseService { OCPP16StatusNotificationResponse >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { connectorId, - status: OCPP16ChargePointStatus.CHARGING, + status: OCPP16ChargePointStatus.Charging, errorCode: OCPP16ChargePointErrorCode.NO_ERROR, }); - chargingStation.getConnectorStatus(connectorId).status = OCPP16ChargePointStatus.CHARGING; + chargingStation.getConnectorStatus(connectorId).status = OCPP16ChargePointStatus.Charging; logger.info( - chargingStation.logPrefix() + - ' Transaction ' + - payload.transactionId.toString() + - ' STARTED on ' + - chargingStation.stationInfo.chargingStationId + - '#' + - connectorId.toString() + - ' for idTag ' + - requestPayload.idTag + `${chargingStation.logPrefix()} Transaction ${payload.transactionId.toString()} STARTED on ${ + chargingStation.stationInfo.chargingStationId + }#${connectorId.toString()} for idTag '${requestPayload.idTag}'` ); if (chargingStation.stationInfo.powerSharedByConnectors) { chargingStation.powerDivider++; @@ -455,17 +580,13 @@ export default class OCPP16ResponseService extends OCPPResponseService { connectorId, configuredMeterValueSampleInterval ? Utils.convertToInt(configuredMeterValueSampleInterval.value) * 1000 - : 60000 + : Constants.DEFAULT_METER_VALUES_INTERVAL ); } else { logger.warn( - chargingStation.logPrefix() + - ' Starting transaction id ' + - payload.transactionId.toString() + - " REJECTED with status '" + - payload?.idTagInfo?.status + - "', idTag " + - requestPayload.idTag + `${chargingStation.logPrefix()} Starting transaction id ${payload.transactionId.toString()} REJECTED with status '${ + payload.idTagInfo?.status + }', idTag '${requestPayload.idTag}'` ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); } @@ -477,17 +598,17 @@ export default class OCPP16ResponseService extends OCPPResponseService { ): Promise { chargingStation.resetConnectorStatus(connectorId); if ( - chargingStation.getConnectorStatus(connectorId).status !== OCPP16ChargePointStatus.AVAILABLE + chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.Available ) { await chargingStation.ocppRequestService.requestHandler< OCPP16StatusNotificationRequest, OCPP16StatusNotificationResponse >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { connectorId, - status: OCPP16ChargePointStatus.AVAILABLE, + status: OCPP16ChargePointStatus.Available, errorCode: OCPP16ChargePointErrorCode.NO_ERROR, }); - chargingStation.getConnectorStatus(connectorId).status = OCPP16ChargePointStatus.AVAILABLE; + chargingStation.getConnectorStatus(connectorId).status = OCPP16ChargePointStatus.Available; } } @@ -496,113 +617,74 @@ export default class OCPP16ResponseService extends OCPPResponseService { payload: OCPP16StopTransactionResponse, requestPayload: OCPP16StopTransactionRequest ): Promise { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.STOP_TRANSACTION, - this.stopTransactionResponseJsonSchema, - payload - ); const transactionConnectorId = chargingStation.getConnectorIdByTransactionId( requestPayload.transactionId ); - if (!transactionConnectorId) { + if (Utils.isNullOrUndefined(transactionConnectorId)) { logger.error( - chargingStation.logPrefix() + - ' Trying to stop a non existing transaction ' + - requestPayload.transactionId.toString() + `${chargingStation.logPrefix()} Trying to stop a non existing transaction ${requestPayload.transactionId.toString()}` ); return; } - if (payload.idTagInfo?.status === OCPP16AuthorizationStatus.ACCEPTED) { - chargingStation.getBeginEndMeterValues() && - !chargingStation.getOcppStrictCompliance() && - chargingStation.getOutOfOrderEndMeterValues() && - (await chargingStation.ocppRequestService.requestHandler< - OCPP16MeterValuesRequest, - OCPP16MeterValuesResponse - >(chargingStation, OCPP16RequestCommand.METER_VALUES, { - connectorId: transactionConnectorId, - transactionId: requestPayload.transactionId, - meterValue: [ - OCPP16ServiceUtils.buildTransactionEndMeterValue( - chargingStation, - transactionConnectorId, - requestPayload.meterStop - ), - ], - })); - if ( - !chargingStation.isChargingStationAvailable() || - !chargingStation.isConnectorAvailable(transactionConnectorId) - ) { - await chargingStation.ocppRequestService.requestHandler< - OCPP16StatusNotificationRequest, - OCPP16StatusNotificationResponse - >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { - connectorId: transactionConnectorId, - status: OCPP16ChargePointStatus.UNAVAILABLE, - errorCode: OCPP16ChargePointErrorCode.NO_ERROR, - }); - chargingStation.getConnectorStatus(transactionConnectorId).status = - OCPP16ChargePointStatus.UNAVAILABLE; - } else { - await chargingStation.ocppRequestService.requestHandler< - OCPP16BootNotificationRequest, - OCPP16BootNotificationResponse - >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { - connectorId: transactionConnectorId, - status: OCPP16ChargePointStatus.AVAILABLE, - errorCode: OCPP16ChargePointErrorCode.NO_ERROR, - }); - chargingStation.getConnectorStatus(transactionConnectorId).status = - OCPP16ChargePointStatus.AVAILABLE; - } - if (chargingStation.stationInfo.powerSharedByConnectors) { - chargingStation.powerDivider--; - } - logger.info( - chargingStation.logPrefix() + - ' Transaction ' + - requestPayload.transactionId.toString() + - ' STOPPED on ' + - chargingStation.stationInfo.chargingStationId + - '#' + - transactionConnectorId.toString() - ); - chargingStation.resetConnectorStatus(transactionConnectorId); + chargingStation.getBeginEndMeterValues() === true && + chargingStation.getOcppStrictCompliance() === false && + chargingStation.getOutOfOrderEndMeterValues() === true && + (await chargingStation.ocppRequestService.requestHandler< + OCPP16MeterValuesRequest, + OCPP16MeterValuesResponse + >(chargingStation, OCPP16RequestCommand.METER_VALUES, { + connectorId: transactionConnectorId, + transactionId: requestPayload.transactionId, + meterValue: [ + OCPP16ServiceUtils.buildTransactionEndMeterValue( + chargingStation, + transactionConnectorId, + requestPayload.meterStop + ), + ], + })); + if ( + chargingStation.isChargingStationAvailable() === false || + chargingStation.isConnectorAvailable(transactionConnectorId) === false + ) { + await chargingStation.ocppRequestService.requestHandler< + OCPP16StatusNotificationRequest, + OCPP16StatusNotificationResponse + >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { + connectorId: transactionConnectorId, + status: OCPP16ChargePointStatus.Unavailable, + errorCode: OCPP16ChargePointErrorCode.NO_ERROR, + }); + chargingStation.getConnectorStatus(transactionConnectorId).status = + OCPP16ChargePointStatus.Unavailable; } else { - logger.warn( - chargingStation.logPrefix() + - ' Stopping transaction id ' + - requestPayload.transactionId.toString() + - " REJECTED with status '" + - payload.idTagInfo?.status + - "'" - ); + await chargingStation.ocppRequestService.requestHandler< + OCPP16BootNotificationRequest, + OCPP16BootNotificationResponse + >(chargingStation, OCPP16RequestCommand.STATUS_NOTIFICATION, { + connectorId: transactionConnectorId, + status: OCPP16ChargePointStatus.Available, + errorCode: OCPP16ChargePointErrorCode.NO_ERROR, + }); + chargingStation.getConnectorStatus(transactionConnectorId).status = + OCPP16ChargePointStatus.Available; + } + if (chargingStation.stationInfo.powerSharedByConnectors) { + chargingStation.powerDivider--; + } + chargingStation.resetConnectorStatus(transactionConnectorId); + const logMsg = `${chargingStation.logPrefix()} Transaction ${requestPayload.transactionId.toString()} STOPPED on ${ + chargingStation.stationInfo.chargingStationId + }#${transactionConnectorId?.toString()} with status '${ + payload.idTagInfo?.status ?? 'undefined' + }'`; + if ( + Utils.isNullOrUndefined(payload.idTagInfo) || + payload.idTagInfo?.status === OCPP16AuthorizationStatus.ACCEPTED + ) { + logger.info(logMsg); + } else { + logger.warn(logMsg); } - } - - private handleResponseStatusNotification( - chargingStation: ChargingStation, - payload: OCPP16StatusNotificationResponse - ): void { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.STATUS_NOTIFICATION, - this.statusNotificationResponseJsonSchema, - payload - ); - } - - private handleResponseMeterValues( - chargingStation: ChargingStation, - payload: OCPP16MeterValuesResponse - ): void { - this.validateResponsePayload( - chargingStation, - OCPP16RequestCommand.METER_VALUES, - this.meterValuesResponseJsonSchema, - payload - ); } }