X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Focpp%2F1.6%2FOCPP16ResponseService.ts;h=6dcc5d5d2cf5f916f68838321ecb940075fdd6d4;hb=4190ce4e00f15beb8160ed04e496875e10bd2828;hp=743455ff8ae783d86611b06272ddba8c7b9e8dee;hpb=54ebb82c196c3b5cf81e6ed4ab8a65fd96ed2f5d;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts b/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts index 743455ff..6dcc5d5d 100644 --- a/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts +++ b/src/charging-station/ocpp/1.6/OCPP16ResponseService.ts @@ -3,16 +3,18 @@ import { parentPort } from 'node:worker_threads'; import type { JSONSchemaType } from 'ajv'; +import { secondsToMilliseconds } from 'date-fns'; +import { OCPP16ServiceUtils } from './OCPP16ServiceUtils'; import { type ChargingStation, - ChargingStationConfigurationUtils, - ChargingStationUtils, - MessageChannelUtils, + addConfigurationKey, + getConfigurationKey, + hasReservationExpired, + resetConnectorStatus, } from '../../../charging-station'; import { OCPPError } from '../../../exception'; import { - type ChangeAvailabilityResponse, type ChangeConfigurationResponse, type ClearChargingProfileResponse, ErrorType, @@ -25,6 +27,7 @@ import { type OCPP16AuthorizeRequest, type OCPP16AuthorizeResponse, type OCPP16BootNotificationResponse, + type OCPP16ChangeAvailabilityResponse, OCPP16ChargePointStatus, type OCPP16DataTransferResponse, type OCPP16DiagnosticsStatusNotificationResponse, @@ -35,6 +38,7 @@ import { type OCPP16MeterValuesRequest, type OCPP16MeterValuesResponse, OCPP16RequestCommand, + type OCPP16ReserveNowResponse, OCPP16StandardParametersKey, type OCPP16StartTransactionRequest, type OCPP16StartTransactionResponse, @@ -45,12 +49,19 @@ import { type OCPP16UpdateFirmwareResponse, OCPPVersion, RegistrationStatusEnumType, + ReservationTerminationReason, type ResponseHandler, type SetChargingProfileResponse, type UnlockConnectorResponse, } from '../../../types'; -import { Constants, Utils, logger } from '../../../utils'; -import { OCPP16ServiceUtils, OCPPResponseService } from '../internal'; +import { + Constants, + buildUpdatedMessage, + convertToInt, + isNullOrUndefined, + logger, +} from '../../../utils'; +import { OCPPResponseService } from '../OCPPResponseService'; const moduleName = 'OCPP16ResponseService'; @@ -69,96 +80,114 @@ export class OCPP16ResponseService extends OCPPResponseService { // } super(OCPPVersion.VERSION_16); this.responseHandlers = new Map([ - [OCPP16RequestCommand.BOOT_NOTIFICATION, this.handleResponseBootNotification.bind(this)], - [OCPP16RequestCommand.HEARTBEAT, this.emptyResponseHandler.bind(this)], - [OCPP16RequestCommand.AUTHORIZE, this.handleResponseAuthorize.bind(this)], - [OCPP16RequestCommand.START_TRANSACTION, this.handleResponseStartTransaction.bind(this)], - [OCPP16RequestCommand.STOP_TRANSACTION, this.handleResponseStopTransaction.bind(this)], - [OCPP16RequestCommand.STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], - [OCPP16RequestCommand.METER_VALUES, this.emptyResponseHandler.bind(this)], - [OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], - [OCPP16RequestCommand.DATA_TRANSFER, this.emptyResponseHandler.bind(this)], - [OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, this.emptyResponseHandler.bind(this)], + [ + OCPP16RequestCommand.BOOT_NOTIFICATION, + this.handleResponseBootNotification.bind(this) as ResponseHandler, + ], + [OCPP16RequestCommand.HEARTBEAT, this.emptyResponseHandler.bind(this) as ResponseHandler], + [OCPP16RequestCommand.AUTHORIZE, this.handleResponseAuthorize.bind(this) as ResponseHandler], + [ + OCPP16RequestCommand.START_TRANSACTION, + this.handleResponseStartTransaction.bind(this) as ResponseHandler, + ], + [ + OCPP16RequestCommand.STOP_TRANSACTION, + this.handleResponseStopTransaction.bind(this) as ResponseHandler, + ], + [ + OCPP16RequestCommand.STATUS_NOTIFICATION, + this.emptyResponseHandler.bind(this) as ResponseHandler, + ], + [OCPP16RequestCommand.METER_VALUES, this.emptyResponseHandler.bind(this) as ResponseHandler], + [ + OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, + this.emptyResponseHandler.bind(this) as ResponseHandler, + ], + [OCPP16RequestCommand.DATA_TRANSFER, this.emptyResponseHandler.bind(this) as ResponseHandler], + [ + OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, + this.emptyResponseHandler.bind(this) as ResponseHandler, + ], ]); this.jsonSchemas = new Map>([ [ OCPP16RequestCommand.BOOT_NOTIFICATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/BootNotificationResponse.json', + 'assets/json-schemas/ocpp/1.6/BootNotificationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.HEARTBEAT, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/HeartbeatResponse.json', + 'assets/json-schemas/ocpp/1.6/HeartbeatResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.AUTHORIZE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/AuthorizeResponse.json', + 'assets/json-schemas/ocpp/1.6/AuthorizeResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.START_TRANSACTION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/StartTransactionResponse.json', + 'assets/json-schemas/ocpp/1.6/StartTransactionResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.STOP_TRANSACTION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/StopTransactionResponse.json', + 'assets/json-schemas/ocpp/1.6/StopTransactionResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.STATUS_NOTIFICATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/StatusNotificationResponse.json', + 'assets/json-schemas/ocpp/1.6/StatusNotificationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.METER_VALUES, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/MeterValuesResponse.json', + 'assets/json-schemas/ocpp/1.6/MeterValuesResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.DIAGNOSTICS_STATUS_NOTIFICATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/DiagnosticsStatusNotificationResponse.json', + 'assets/json-schemas/ocpp/1.6/DiagnosticsStatusNotificationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.DATA_TRANSFER, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/DataTransferResponse.json', + 'assets/json-schemas/ocpp/1.6/DataTransferResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16RequestCommand.FIRMWARE_STATUS_NOTIFICATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/FirmwareStatusNotificationResponse.json', + 'assets/json-schemas/ocpp/1.6/FirmwareStatusNotificationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], ]); @@ -166,136 +195,152 @@ export class OCPP16ResponseService extends OCPPResponseService { [ OCPP16IncomingRequestCommand.RESET, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/ResetResponse.json', + 'assets/json-schemas/ocpp/1.6/ResetResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.CLEAR_CACHE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/ClearCacheResponse.json', + 'assets/json-schemas/ocpp/1.6/ClearCacheResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.CHANGE_AVAILABILITY, - OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/ChangeAvailabilityResponse.json', + OCPP16ServiceUtils.parseJsonSchemaFile( + 'assets/json-schemas/ocpp/1.6/ChangeAvailabilityResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.UNLOCK_CONNECTOR, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/UnlockConnectorResponse.json', + 'assets/json-schemas/ocpp/1.6/UnlockConnectorResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.GET_CONFIGURATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/GetConfigurationResponse.json', + 'assets/json-schemas/ocpp/1.6/GetConfigurationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.CHANGE_CONFIGURATION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/ChangeConfigurationResponse.json', + 'assets/json-schemas/ocpp/1.6/ChangeConfigurationResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.GET_COMPOSITE_SCHEDULE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/GetCompositeScheduleResponse.json', + 'assets/json-schemas/ocpp/1.6/GetCompositeScheduleResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.SET_CHARGING_PROFILE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/SetChargingProfileResponse.json', + 'assets/json-schemas/ocpp/1.6/SetChargingProfileResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.CLEAR_CHARGING_PROFILE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/ClearChargingProfileResponse.json', + 'assets/json-schemas/ocpp/1.6/ClearChargingProfileResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.REMOTE_START_TRANSACTION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/RemoteStartTransactionResponse.json', + 'assets/json-schemas/ocpp/1.6/RemoteStartTransactionResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.REMOTE_STOP_TRANSACTION, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/RemoteStopTransactionResponse.json', + 'assets/json-schemas/ocpp/1.6/RemoteStopTransactionResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.GET_DIAGNOSTICS, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/GetDiagnosticsResponse.json', + 'assets/json-schemas/ocpp/1.6/GetDiagnosticsResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.TRIGGER_MESSAGE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/TriggerMessageResponse.json', + 'assets/json-schemas/ocpp/1.6/TriggerMessageResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.DATA_TRANSFER, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/DataTransferResponse.json', + 'assets/json-schemas/ocpp/1.6/DataTransferResponse.json', moduleName, - 'constructor' + 'constructor', ), ], [ OCPP16IncomingRequestCommand.UPDATE_FIRMWARE, OCPP16ServiceUtils.parseJsonSchemaFile( - '../../../assets/json-schemas/ocpp/1.6/UpdateFirmwareResponse.json', + 'assets/json-schemas/ocpp/1.6/UpdateFirmwareResponse.json', + moduleName, + 'constructor', + ), + ], + [ + OCPP16IncomingRequestCommand.RESERVE_NOW, + OCPP16ServiceUtils.parseJsonSchemaFile( + 'assets/json-schemas/ocpp/1.6/ReserveNowResponse.json', moduleName, - 'constructor' + 'constructor', + ), + ], + [ + OCPP16IncomingRequestCommand.CANCEL_RESERVATION, + OCPP16ServiceUtils.parseJsonSchemaFile( + 'assets/json-schemas/ocpp/1.6/CancelReservationResponse.json', + moduleName, + 'constructor', ), ], ]); this.validatePayload = this.validatePayload.bind(this) as ( chargingStation: ChargingStation, commandName: OCPP16RequestCommand, - payload: JsonType + payload: JsonType, ) => boolean; } - public async responseHandler( + public async responseHandler( chargingStation: ChargingStation, commandName: OCPP16RequestCommand, - payload: JsonType, - requestPayload: JsonType + payload: ResType, + requestPayload: ReqType, ): Promise { if ( chargingStation.isRegistered() === true || @@ -307,11 +352,11 @@ export class OCPP16ResponseService extends OCPPResponseService { ) { try { this.validatePayload(chargingStation, commandName, payload); - await this.responseHandlers.get(commandName)(chargingStation, payload, requestPayload); + await this.responseHandlers.get(commandName)!(chargingStation, payload, requestPayload); } catch (error) { logger.error( `${chargingStation.logPrefix()} ${moduleName}.responseHandler: Handle response error:`, - error + error, ); throw error; } @@ -322,10 +367,10 @@ export class OCPP16ResponseService extends OCPPResponseService { `${commandName} is not implemented to handle response PDU ${JSON.stringify( payload, null, - 2 + 2, )}`, commandName, - payload + payload, ); } } else { @@ -334,10 +379,10 @@ export class OCPP16ResponseService extends OCPPResponseService { `${commandName} cannot be issued to handle response PDU ${JSON.stringify( payload, null, - 2 + 2, )} while the charging station is not registered on the central server.`, commandName, - payload + payload, ); } } @@ -345,40 +390,40 @@ export class OCPP16ResponseService extends OCPPResponseService { private validatePayload( chargingStation: ChargingStation, commandName: OCPP16RequestCommand, - payload: JsonType + payload: JsonType, ): boolean { if (this.jsonSchemas.has(commandName) === true) { return this.validateResponsePayload( chargingStation, commandName, - this.jsonSchemas.get(commandName), - payload + this.jsonSchemas.get(commandName)!, + payload, ); } logger.warn( - `${chargingStation.logPrefix()} ${moduleName}.validatePayload: No JSON schema found for command '${commandName}' PDU validation` + `${chargingStation.logPrefix()} ${moduleName}.validatePayload: No JSON schema found for command '${commandName}' PDU validation`, ); return false; } private handleResponseBootNotification( chargingStation: ChargingStation, - payload: OCPP16BootNotificationResponse + payload: OCPP16BootNotificationResponse, ): void { if (payload.status === RegistrationStatusEnumType.ACCEPTED) { - ChargingStationConfigurationUtils.addConfigurationKey( + addConfigurationKey( chargingStation, OCPP16StandardParametersKey.HeartbeatInterval, payload.interval.toString(), {}, - { overwrite: true, save: true } + { overwrite: true, save: true }, ); - ChargingStationConfigurationUtils.addConfigurationKey( + addConfigurationKey( chargingStation, OCPP16StandardParametersKey.HeartBeatInterval, payload.interval.toString(), { visible: false }, - { overwrite: true, save: true } + { overwrite: true, save: true }, ); OCPP16ServiceUtils.startHeartbeatInterval(chargingStation, payload.interval); } @@ -392,7 +437,7 @@ export class OCPP16ResponseService extends OCPPResponseService { } else { logger.error( `${chargingStation.logPrefix()} Charging station boot notification response received: %j with undefined registration status`, - payload + payload, ); } } @@ -400,36 +445,52 @@ export class OCPP16ResponseService extends OCPPResponseService { private handleResponseAuthorize( chargingStation: ChargingStation, payload: OCPP16AuthorizeResponse, - requestPayload: OCPP16AuthorizeRequest + requestPayload: OCPP16AuthorizeRequest, ): void { - let authorizeConnectorId: number; - for (const connectorId of chargingStation.connectors.keys()) { - if ( - connectorId > 0 && - chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag === requestPayload.idTag - ) { - authorizeConnectorId = connectorId; - break; + let authorizeConnectorId: number | undefined; + if (chargingStation.hasEvses) { + for (const [evseId, evseStatus] of chargingStation.evses) { + if (evseId > 0) { + for (const [connectorId, connectorStatus] of evseStatus.connectors) { + if (connectorStatus?.authorizeIdTag === requestPayload.idTag) { + authorizeConnectorId = connectorId; + break; + } + } + } + } + } else { + for (const connectorId of chargingStation.connectors.keys()) { + if ( + connectorId > 0 && + chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag === requestPayload.idTag + ) { + authorizeConnectorId = connectorId; + break; + } } } - const authorizeConnectorIdDefined = !Utils.isNullOrUndefined(authorizeConnectorId); + const authorizeConnectorStatus = chargingStation.getConnectorStatus(authorizeConnectorId!); + const authorizeConnectorIdDefined = !isNullOrUndefined(authorizeConnectorId); if (payload.idTagInfo.status === OCPP16AuthorizationStatus.ACCEPTED) { - authorizeConnectorIdDefined && - (chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = true); + if (authorizeConnectorIdDefined) { + // authorizeConnectorStatus!.authorizeIdTag = requestPayload.idTag; + authorizeConnectorStatus!.idTagAuthorized = true; + } logger.debug( `${chargingStation.logPrefix()} idTag '${requestPayload.idTag}' accepted${ authorizeConnectorIdDefined ? ` on connector id ${authorizeConnectorId}` : '' - }` + }`, ); } else { if (authorizeConnectorIdDefined) { - chargingStation.getConnectorStatus(authorizeConnectorId).idTagAuthorized = false; - delete chargingStation.getConnectorStatus(authorizeConnectorId)?.authorizeIdTag; + authorizeConnectorStatus!.idTagAuthorized = false; + delete authorizeConnectorStatus?.authorizeIdTag; } logger.debug( `${chargingStation.logPrefix()} idTag '${requestPayload.idTag}' rejected with status '${ payload.idTagInfo.status - }'${authorizeConnectorIdDefined ? ` on connector id ${authorizeConnectorId}` : ''}` + }'${authorizeConnectorIdDefined ? ` on connector id ${authorizeConnectorId}` : ''}`, ); } } @@ -437,114 +498,145 @@ export class OCPP16ResponseService extends OCPPResponseService { private async handleResponseStartTransaction( chargingStation: ChargingStation, payload: OCPP16StartTransactionResponse, - requestPayload: OCPP16StartTransactionRequest + requestPayload: OCPP16StartTransactionRequest, ): Promise { - const connectorId = requestPayload.connectorId; - if (connectorId === 0 || !chargingStation.connectors.has(connectorId)) { + const { connectorId } = requestPayload; + if (connectorId === 0 || chargingStation.hasConnector(connectorId) === false) { logger.error( - `${chargingStation.logPrefix()} Trying to start a transaction on a non existing connector id ${connectorId.toString()}` + `${chargingStation.logPrefix()} Trying to start a transaction on a non existing connector id ${connectorId}`, ); return; } + const connectorStatus = chargingStation.getConnectorStatus(connectorId); if ( - chargingStation.getConnectorStatus(connectorId)?.transactionRemoteStarted === true && + connectorStatus?.transactionRemoteStarted === true && chargingStation.getAuthorizeRemoteTxRequests() === true && chargingStation.getLocalAuthListEnabled() === true && - chargingStation.hasIdTags() && - chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized === false + chargingStation.hasIdTags() === true && + connectorStatus?.idTagLocalAuthorized === false ) { logger.error( - `${chargingStation.logPrefix()} Trying to start a transaction with a not local authorized idTag ${ - chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag - } on connector id ${connectorId.toString()}` + `${chargingStation.logPrefix()} Trying to start a transaction with a not local authorized idTag ${connectorStatus?.localAuthorizeIdTag} on connector id ${connectorId}`, ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId)?.transactionRemoteStarted === true && + connectorStatus?.transactionRemoteStarted === true && chargingStation.getAuthorizeRemoteTxRequests() === true && - chargingStation.getMustAuthorizeAtRemoteStart() === true && - chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized === false && - chargingStation.getConnectorStatus(connectorId)?.idTagAuthorized === false + chargingStation.getRemoteAuthorization() === true && + connectorStatus?.idTagLocalAuthorized === false && + connectorStatus?.idTagAuthorized === false ) { logger.error( - `${chargingStation.logPrefix()} Trying to start a transaction with a not authorized idTag ${ - chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag - } on connector id ${connectorId.toString()}` + `${chargingStation.logPrefix()} Trying to start a transaction with a not authorized idTag ${connectorStatus?.authorizeIdTag} on connector id ${connectorId}`, ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId)?.idTagAuthorized && - chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag !== requestPayload.idTag + connectorStatus?.idTagAuthorized && + connectorStatus?.authorizeIdTag !== requestPayload.idTag ) { logger.error( `${chargingStation.logPrefix()} Trying to start a transaction with an idTag ${ requestPayload.idTag - } different from the authorize request one ${ - chargingStation.getConnectorStatus(connectorId)?.authorizeIdTag - } on connector id ${connectorId.toString()}` + } different from the authorize request one ${connectorStatus?.authorizeIdTag} on connector id ${connectorId}`, ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } if ( - chargingStation.getConnectorStatus(connectorId)?.idTagLocalAuthorized && - chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag !== requestPayload.idTag + connectorStatus?.idTagLocalAuthorized && + connectorStatus?.localAuthorizeIdTag !== requestPayload.idTag ) { logger.error( `${chargingStation.logPrefix()} Trying to start a transaction with an idTag ${ requestPayload.idTag - } different from the local authorized one ${ - chargingStation.getConnectorStatus(connectorId)?.localAuthorizeIdTag - } on connector id ${connectorId.toString()}` + } different from the local authorized one ${connectorStatus?.localAuthorizeIdTag} on connector id ${connectorId}`, ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); return; } - if (chargingStation.getConnectorStatus(connectorId)?.transactionStarted === true) { - logger.debug( - `${chargingStation.logPrefix()} Trying to start a transaction on an already used connector id ${connectorId.toString()}: %j`, - chargingStation.getConnectorStatus(connectorId) + if (connectorStatus?.transactionStarted === true) { + logger.error( + `${chargingStation.logPrefix()} Trying to start a transaction on an already used connector id ${connectorId} by idTag ${connectorStatus?.transactionIdTag}}`, ); return; } + if (chargingStation.hasEvses) { + for (const [evseId, evseStatus] of chargingStation.evses) { + if (evseStatus.connectors.size > 1) { + for (const [id, status] of evseStatus.connectors) { + if (id !== connectorId && status?.transactionStarted === true) { + logger.error( + `${chargingStation.logPrefix()} Trying to start a transaction on an already used evse id ${evseId} by connector id ${id} with idTag ${status?.transactionIdTag}}`, + ); + await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); + return; + } + } + } + } + } if ( - chargingStation.getConnectorStatus(connectorId)?.status !== - OCPP16ChargePointStatus.Available && - chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.Preparing + connectorStatus?.status !== OCPP16ChargePointStatus.Available && + connectorStatus?.status !== OCPP16ChargePointStatus.Preparing ) { logger.error( - `${chargingStation.logPrefix()} Trying to start a transaction on connector id ${connectorId.toString()} with status ${ - chargingStation.getConnectorStatus(connectorId)?.status - }` + `${chargingStation.logPrefix()} Trying to start a transaction on connector id ${connectorId} with status ${connectorStatus?.status}`, ); return; } - if (!Number.isInteger(payload.transactionId)) { + if (!Number.isSafeInteger(payload.transactionId)) { logger.warn( - `${chargingStation.logPrefix()} Trying to start a transaction on connector id ${connectorId.toString()} with a non integer transaction id ${ + `${chargingStation.logPrefix()} Trying to start a transaction on connector id ${connectorId} with a non integer transaction id ${ payload.transactionId - }, converting to integer` + }, converting to integer`, ); - payload.transactionId = Utils.convertToInt(payload.transactionId); + payload.transactionId = convertToInt(payload.transactionId); } if (payload.idTagInfo?.status === OCPP16AuthorizationStatus.ACCEPTED) { - chargingStation.getConnectorStatus(connectorId).transactionStarted = true; - chargingStation.getConnectorStatus(connectorId).transactionId = payload.transactionId; - chargingStation.getConnectorStatus(connectorId).transactionIdTag = requestPayload.idTag; - chargingStation.getConnectorStatus( - connectorId - ).transactionEnergyActiveImportRegisterValue = 0; - chargingStation.getConnectorStatus(connectorId).transactionBeginMeterValue = + connectorStatus.transactionStarted = true; + connectorStatus.transactionStart = requestPayload.timestamp; + connectorStatus.transactionId = payload.transactionId; + connectorStatus.transactionIdTag = requestPayload.idTag; + connectorStatus.transactionEnergyActiveImportRegisterValue = 0; + connectorStatus.transactionBeginMeterValue = OCPP16ServiceUtils.buildTransactionBeginMeterValue( chargingStation, connectorId, - requestPayload.meterStart + requestPayload.meterStart, ); + if (requestPayload.reservationId) { + const reservation = chargingStation.getReservationBy( + 'reservationId', + requestPayload.reservationId, + )!; + if (reservation.idTag !== requestPayload.idTag) { + logger.warn( + `${chargingStation.logPrefix()} Reserved transaction ${ + payload.transactionId + } started with a different idTag ${requestPayload.idTag} than the reservation one ${ + reservation.idTag + }`, + ); + } + if (hasReservationExpired(reservation)) { + logger.warn( + `${chargingStation.logPrefix()} Reserved transaction ${ + payload.transactionId + } started with expired reservation ${ + requestPayload.reservationId + } (expiry date: ${reservation.expiryDate.toISOString()}))`, + ); + } + await chargingStation.removeReservation( + reservation, + ReservationTerminationReason.TRANSACTION_STARTED, + ); + } chargingStation.getBeginEndMeterValues() && (await chargingStation.ocppRequestService.requestHandler< OCPP16MeterValuesRequest, @@ -552,37 +644,44 @@ export class OCPP16ResponseService extends OCPPResponseService { >(chargingStation, OCPP16RequestCommand.METER_VALUES, { connectorId, transactionId: payload.transactionId, - meterValue: [chargingStation.getConnectorStatus(connectorId).transactionBeginMeterValue], - })); + meterValue: [connectorStatus.transactionBeginMeterValue], + } as OCPP16MeterValuesRequest)); await OCPP16ServiceUtils.sendAndSetConnectorStatus( chargingStation, connectorId, - OCPP16ChargePointStatus.Charging + OCPP16ChargePointStatus.Charging, ); logger.info( - `${chargingStation.logPrefix()} Transaction with id ${payload.transactionId.toString()} STARTED on ${ + `${chargingStation.logPrefix()} Transaction with id ${payload.transactionId} STARTED on ${ chargingStation.stationInfo.chargingStationId - }#${connectorId.toString()} for idTag '${requestPayload.idTag}'` + }#${connectorId} for idTag '${requestPayload.idTag}'`, ); if (chargingStation.stationInfo.powerSharedByConnectors) { - chargingStation.powerDivider++; + ++chargingStation.powerDivider; } - const configuredMeterValueSampleInterval = - ChargingStationConfigurationUtils.getConfigurationKey( - chargingStation, - OCPP16StandardParametersKey.MeterValueSampleInterval - ); + const configuredMeterValueSampleInterval = getConfigurationKey( + chargingStation, + OCPP16StandardParametersKey.MeterValueSampleInterval, + ); chargingStation.startMeterValues( connectorId, configuredMeterValueSampleInterval - ? Utils.convertToInt(configuredMeterValueSampleInterval.value) * 1000 - : Constants.DEFAULT_METER_VALUES_INTERVAL + ? secondsToMilliseconds(convertToInt(configuredMeterValueSampleInterval.value)) + : Constants.DEFAULT_METER_VALUES_INTERVAL, ); } else { logger.warn( - `${chargingStation.logPrefix()} Starting transaction with id ${payload.transactionId.toString()} REJECTED with status '${ - payload.idTagInfo?.status - }', idTag '${requestPayload.idTag}'` + `${chargingStation.logPrefix()} Starting transaction with id ${ + payload.transactionId + } REJECTED on ${ + chargingStation.stationInfo.chargingStationId + }#${connectorId} with status '${payload.idTagInfo?.status}', idTag '${ + requestPayload.idTag + }'${ + OCPP16ServiceUtils.hasReservation(chargingStation, connectorId, requestPayload.idTag) + ? `, reservationId '${requestPayload.reservationId}'` + : '' + }`, ); await this.resetConnectorOnStartTransactionError(chargingStation, connectorId); } @@ -590,33 +689,34 @@ export class OCPP16ResponseService extends OCPPResponseService { private async resetConnectorOnStartTransactionError( chargingStation: ChargingStation, - connectorId: number + connectorId: number, ): Promise { - ChargingStationUtils.resetConnectorStatus(chargingStation.getConnectorStatus(connectorId)); + const connectorStatus = chargingStation.getConnectorStatus(connectorId); + resetConnectorStatus(connectorStatus!); chargingStation.stopMeterValues(connectorId); - parentPort?.postMessage(MessageChannelUtils.buildUpdatedMessage(chargingStation)); - if ( - chargingStation.getConnectorStatus(connectorId)?.status !== OCPP16ChargePointStatus.Available - ) { + if (connectorStatus?.status !== OCPP16ChargePointStatus.Available) { await OCPP16ServiceUtils.sendAndSetConnectorStatus( chargingStation, connectorId, - OCPP16ChargePointStatus.Available + OCPP16ChargePointStatus.Available, ); } + parentPort?.postMessage(buildUpdatedMessage(chargingStation)); } private async handleResponseStopTransaction( chargingStation: ChargingStation, payload: OCPP16StopTransactionResponse, - requestPayload: OCPP16StopTransactionRequest + requestPayload: OCPP16StopTransactionRequest, ): Promise { const transactionConnectorId = chargingStation.getConnectorIdByTransactionId( - requestPayload.transactionId + requestPayload.transactionId, ); - if (Utils.isNullOrUndefined(transactionConnectorId)) { + if (isNullOrUndefined(transactionConnectorId)) { logger.error( - `${chargingStation.logPrefix()} Trying to stop a non existing transaction with id ${requestPayload.transactionId.toString()}` + `${chargingStation.logPrefix()} Trying to stop a non existing transaction with id ${ + requestPayload.transactionId + }`, ); return; } @@ -632,42 +732,40 @@ export class OCPP16ResponseService extends OCPPResponseService { meterValue: [ OCPP16ServiceUtils.buildTransactionEndMeterValue( chargingStation, - transactionConnectorId, - requestPayload.meterStop + transactionConnectorId!, + requestPayload.meterStop, ), ], })); if ( chargingStation.isChargingStationAvailable() === false || - chargingStation.isConnectorAvailable(transactionConnectorId) === false + chargingStation.isConnectorAvailable(transactionConnectorId!) === false ) { await OCPP16ServiceUtils.sendAndSetConnectorStatus( chargingStation, - transactionConnectorId, - OCPP16ChargePointStatus.Unavailable + transactionConnectorId!, + OCPP16ChargePointStatus.Unavailable, ); } else { await OCPP16ServiceUtils.sendAndSetConnectorStatus( chargingStation, - transactionConnectorId, - OCPP16ChargePointStatus.Available + transactionConnectorId!, + OCPP16ChargePointStatus.Available, ); } if (chargingStation.stationInfo.powerSharedByConnectors) { chargingStation.powerDivider--; } - ChargingStationUtils.resetConnectorStatus( - chargingStation.getConnectorStatus(transactionConnectorId) - ); - chargingStation.stopMeterValues(transactionConnectorId); - parentPort?.postMessage(MessageChannelUtils.buildUpdatedMessage(chargingStation)); - const logMsg = `${chargingStation.logPrefix()} Transaction with id ${requestPayload.transactionId.toString()} STOPPED on ${ + resetConnectorStatus(chargingStation.getConnectorStatus(transactionConnectorId!)!); + chargingStation.stopMeterValues(transactionConnectorId!); + parentPort?.postMessage(buildUpdatedMessage(chargingStation)); + const logMsg = `${chargingStation.logPrefix()} Transaction with id ${ + requestPayload.transactionId + } STOPPED on ${ chargingStation.stationInfo.chargingStationId - }#${transactionConnectorId?.toString()} with status '${ - payload.idTagInfo?.status ?? 'undefined' - }'`; + }#${transactionConnectorId} with status '${payload.idTagInfo?.status ?? 'undefined'}'`; if ( - Utils.isNullOrUndefined(payload.idTagInfo) || + isNullOrUndefined(payload.idTagInfo) || payload.idTagInfo?.status === OCPP16AuthorizationStatus.ACCEPTED ) { logger.info(logMsg);