X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Focpp%2FOCPPIncomingRequestService.ts;h=b7ab8ef66382b1ac0e799294eccca7f676480855;hb=a82d03296ad3232474c9f769e02c840bb87d0178;hp=bca4809e8d38a2af5fc00ae66d619f73d182d742;hpb=01f4001e733ebc61423d3023d87b1399b6afa215;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ocpp/OCPPIncomingRequestService.ts b/src/charging-station/ocpp/OCPPIncomingRequestService.ts index bca4809e..b7ab8ef6 100644 --- a/src/charging-station/ocpp/OCPPIncomingRequestService.ts +++ b/src/charging-station/ocpp/OCPPIncomingRequestService.ts @@ -3,8 +3,9 @@ import { AsyncResource } from 'node:async_hooks'; import Ajv, { type JSONSchemaType } from 'ajv'; import ajvFormats from 'ajv-formats'; -import { OCPPConstants, OCPPServiceUtils } from './internal'; -import { type ChargingStation, ChargingStationUtils } from '../../charging-station'; +import { OCPPConstants } from './OCPPConstants'; +import { OCPPServiceUtils } from './OCPPServiceUtils'; +import { type ChargingStation, getIdTagsFile } from '../../charging-station'; import { OCPPError } from '../../exception'; import type { ClearCacheResponse, @@ -14,7 +15,7 @@ import type { JsonType, OCPPVersion, } from '../../types'; -import { logger } from '../../utils'; +import { logger, setDefaultErrorParams } from '../../utils'; const moduleName = 'OCPPIncomingRequestService'; @@ -32,8 +33,24 @@ export abstract class OCPPIncomingRequestService extends AsyncResource { multipleOfPrecision: 2, }); ajvFormats(this.ajv); - this.incomingRequestHandler.bind(this); - this.validateIncomingRequestPayload.bind(this); + this.incomingRequestHandler = this.incomingRequestHandler.bind(this) as < + ReqType extends JsonType, + // eslint-disable-next-line @typescript-eslint/no-unused-vars + ResType extends JsonType, + >( + chargingStation: ChargingStation, + messageId: string, + commandName: IncomingRequestCommand, + commandPayload: ReqType, + ) => Promise; + this.validateIncomingRequestPayload = this.validateIncomingRequestPayload.bind(this) as < + T extends JsonType, + >( + chargingStation: ChargingStation, + commandName: IncomingRequestCommand, + schema: JSONSchemaType, + payload: T, + ) => boolean; } public static getInstance(this: new () => T): T { @@ -43,15 +60,16 @@ export abstract class OCPPIncomingRequestService extends AsyncResource { return OCPPIncomingRequestService.instance as T; } - protected handleIncomingRequestError( + protected handleIncomingRequestError( chargingStation: ChargingStation, commandName: IncomingRequestCommand, error: Error, - params: HandleErrorParams = { throwError: true } + params: HandleErrorParams = { throwError: true, consoleOut: false }, ): T | undefined { + setDefaultErrorParams(params); logger.error( `${chargingStation.logPrefix()} ${moduleName}.handleIncomingRequestError: Incoming request command '${commandName}' error:`, - error + error, ); if (!params?.throwError && params?.errorResponse) { return params?.errorResponse; @@ -68,9 +86,9 @@ export abstract class OCPPIncomingRequestService extends AsyncResource { chargingStation: ChargingStation, commandName: IncomingRequestCommand, schema: JSONSchemaType, - payload: T + payload: T, ): boolean { - if (chargingStation.getPayloadSchemaValidation() === false) { + if (chargingStation.getOcppStrictCompliance() === false) { return true; } const validate = this.ajv.compile(schema); @@ -79,27 +97,28 @@ export abstract class OCPPIncomingRequestService extends AsyncResource { } logger.error( `${chargingStation.logPrefix()} ${moduleName}.validateIncomingRequestPayload: Command '${commandName}' incoming request PDU is invalid: %j`, - validate.errors + validate.errors, ); throw new OCPPError( - OCPPServiceUtils.ajvErrorsToErrorType(validate.errors), + OCPPServiceUtils.ajvErrorsToErrorType(validate.errors!), 'Incoming request PDU is invalid', commandName, - JSON.stringify(validate.errors, null, 2) + JSON.stringify(validate.errors, null, 2), ); } protected handleRequestClearCache(chargingStation: ChargingStation): ClearCacheResponse { - chargingStation.authorizedTagsCache.deleteAuthorizedTags( - ChargingStationUtils.getAuthorizationFile(chargingStation.stationInfo) - ); - return OCPPConstants.OCPP_RESPONSE_ACCEPTED; + if (chargingStation.idTagsCache.deleteIdTags(getIdTagsFile(chargingStation.stationInfo)!)) { + return OCPPConstants.OCPP_RESPONSE_ACCEPTED; + } + return OCPPConstants.OCPP_RESPONSE_REJECTED; } - public abstract incomingRequestHandler( + // eslint-disable-next-line @typescript-eslint/no-unused-vars + public abstract incomingRequestHandler( chargingStation: ChargingStation, messageId: string, commandName: IncomingRequestCommand, - commandPayload: JsonType + commandPayload: ReqType, ): Promise; }