X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Focpp%2FOCPPServiceUtils.ts;h=f5bbe1602290dbba4699600570c46a76a10c44f4;hb=88499f52f95a8030eb2186b918fac160b95e58a5;hp=a9c5c562ea18c47e4d88470ca2a54831736af31a;hpb=e0fda4811c974718613467174702af152d1c3eea;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ocpp/OCPPServiceUtils.ts b/src/charging-station/ocpp/OCPPServiceUtils.ts index a9c5c562..f5bbe160 100644 --- a/src/charging-station/ocpp/OCPPServiceUtils.ts +++ b/src/charging-station/ocpp/OCPPServiceUtils.ts @@ -227,20 +227,23 @@ export class OCPPServiceUtils { connectorId: number, idTag: string, ): Promise { - let authorized = false; - if (OCPPServiceUtils.isIdTagLocalAuthorized(chargingStation, idTag)) { + if (!chargingStation.getLocalAuthListEnabled() && !chargingStation.getRemoteAuthorization()) { + logger.warn( + `${chargingStation.logPrefix()} The charging station expects to authorize RFID tags but nor local authorization nor remote authorization are enabled. Misbehavior may occur`, + ); + } + if ( + chargingStation.getLocalAuthListEnabled() === true && + OCPPServiceUtils.isIdTagLocalAuthorized(chargingStation, idTag) + ) { const connectorStatus: ConnectorStatus = chargingStation.getConnectorStatus(connectorId)!; connectorStatus.localAuthorizeIdTag = idTag; connectorStatus.idTagLocalAuthorized = true; - authorized = true; - } else if (chargingStation.getMustAuthorizeAtRemoteStart()) { - authorized = await OCPPServiceUtils.isIdTagRemoteAuthorized( - chargingStation, - connectorId, - idTag, - ); + return true; + } else if (chargingStation.getRemoteAuthorization()) { + return await OCPPServiceUtils.isIdTagRemoteAuthorized(chargingStation, connectorId, idTag); } - return authorized; + return false; } protected static checkConnectorStatusTransition( @@ -424,7 +427,6 @@ export class OCPPServiceUtils { private static isIdTagLocalAuthorized(chargingStation: ChargingStation, idTag: string): boolean { return ( - chargingStation.getLocalAuthListEnabled() === true && chargingStation.hasIdTags() === true && isNotEmptyString( chargingStation.idTagsCache