X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Fui-server%2FUIWebSocketServer.ts;h=c067fb362a8c8b717312bcff35a049135aac2a23;hb=cfa257f5b0065aa6e4a7263cf21fc8305466303a;hp=bb80c60a18c8f642b6483bcc5f961096348c9dcd;hpb=daa6505e2b79f2413b52a60774d78278a11b70b7;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ui-server/UIWebSocketServer.ts b/src/charging-station/ui-server/UIWebSocketServer.ts index bb80c60a..c067fb36 100644 --- a/src/charging-station/ui-server/UIWebSocketServer.ts +++ b/src/charging-station/ui-server/UIWebSocketServer.ts @@ -38,7 +38,6 @@ export default class UIWebSocketServer extends AbstractUIServer { ); ws.close(WebSocketCloseEventStatusCode.CLOSE_PROTOCOL_ERROR); } - this.sockets.add(ws); this.registerProtocolVersionUIService(version); ws.on('message', (rawData) => { const request = this.validateRawDataRequest(rawData); @@ -46,10 +45,11 @@ export default class UIWebSocketServer extends AbstractUIServer { ws.close(WebSocketCloseEventStatusCode.CLOSE_INVALID_PAYLOAD); return; } - const [messageId, procedureName, payload] = request as ProtocolRequest; + const [requestId] = request as ProtocolRequest; + this.responseHandlers.set(requestId, ws); this.uiServices .get(version) - .requestHandler(this.buildProtocolRequest(messageId, procedureName, payload)) + .requestHandler(request) .catch(() => { /* Error caught by AbstractUIService */ }); @@ -58,7 +58,6 @@ export default class UIWebSocketServer extends AbstractUIServer { logger.error(`${this.logPrefix(moduleName, 'start.ws.onerror')} WebSocket error:`, error); }); ws.on('close', (code, reason) => { - this.sockets.delete(ws); logger.debug( `${this.logPrefix( moduleName, @@ -94,8 +93,21 @@ export default class UIWebSocketServer extends AbstractUIServer { } public sendResponse(response: ProtocolResponse): void { - // TODO: send response only to the client that sent the request - this.broadcastToClients(JSON.stringify(response)); + const responseId = response[0]; + if (this.responseHandlers.has(responseId)) { + const ws = this.responseHandlers.get(responseId) as WebSocket; + if (ws?.readyState === WebSocket.OPEN) { + ws.send(JSON.stringify(response)); + } + this.responseHandlers.delete(responseId); + } else { + logger.error( + `${this.logPrefix( + moduleName, + 'sendResponse' + )} Response for unknown request id: ${responseId}` + ); + } } public logPrefix(modName?: string, methodName?: string, prefixSuffix?: string): string { @@ -115,18 +127,6 @@ export default class UIWebSocketServer extends AbstractUIServer { } } - private authenticate(req: IncomingMessage, next: (err?: Error) => void): void { - if (this.isBasicAuthEnabled() === true) { - if (this.isValidBasicAuth(req) === false) { - next(new Error('Unauthorized')); - } else { - next(); - } - } else { - next(); - } - } - private validateRawDataRequest(rawData: RawData): ProtocolRequest | false { // logger.debug( // `${this.logPrefix(