X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fcharging-station%2Fui-server%2FUIWebSocketServer.ts;h=e322ef8db9901889344e41f9b97d41d1616c7bb3;hb=0b0ca54f0a74240531646827584b7c2738aa7ea1;hp=e217305f2e1e42f9644ad25f1467aceab57fa12b;hpb=78202038ffd2aca15aa97f45bc66ba42f40f2ec4;p=e-mobility-charging-stations-simulator.git diff --git a/src/charging-station/ui-server/UIWebSocketServer.ts b/src/charging-station/ui-server/UIWebSocketServer.ts index e217305f..e322ef8d 100644 --- a/src/charging-station/ui-server/UIWebSocketServer.ts +++ b/src/charging-station/ui-server/UIWebSocketServer.ts @@ -1,20 +1,30 @@ -import type { IncomingMessage } from 'http'; -import type internal from 'stream'; +import type { IncomingMessage } from 'node:http'; +import type { Duplex } from 'node:stream'; import { StatusCodes } from 'http-status-codes'; -import WebSocket, { type RawData, WebSocketServer } from 'ws'; +import { type RawData, WebSocket, WebSocketServer } from 'ws'; import { AbstractUIServer } from './AbstractUIServer'; import { UIServerUtils } from './UIServerUtils'; -import type { UIServerConfiguration } from '../../types/ConfigurationData'; -import type { ProtocolRequest, ProtocolResponse } from '../../types/UIProtocol'; -import { WebSocketCloseEventStatusCode } from '../../types/WebSocket'; -import logger from '../../utils/Logger'; -import Utils from '../../utils/Utils'; +import { + type ProtocolRequest, + type ProtocolResponse, + type UIServerConfiguration, + WebSocketCloseEventStatusCode, +} from '../../types'; +import { + Constants, + getWebSocketCloseEventStatusString, + isNotEmptyString, + isNullOrUndefined, + logPrefix, + logger, + validateUUID, +} from '../../utils'; const moduleName = 'UIWebSocketServer'; -export default class UIWebSocketServer extends AbstractUIServer { +export class UIWebSocketServer extends AbstractUIServer { private readonly webSocketServer: WebSocketServer; public constructor(protected readonly uiServerConfiguration: UIServerConfiguration) { @@ -32,8 +42,8 @@ export default class UIWebSocketServer extends AbstractUIServer { logger.error( `${this.logPrefix( moduleName, - 'start.server.onconnection' - )} Unsupported UI protocol version: '${ws.protocol}'` + 'start.server.onconnection', + )} Unsupported UI protocol version: '${ws.protocol}'`, ); ws.close(WebSocketCloseEventStatusCode.CLOSE_PROTOCOL_ERROR); } @@ -49,10 +59,13 @@ export default class UIWebSocketServer extends AbstractUIServer { this.responseHandlers.set(requestId, ws); this.uiServices .get(version) - .requestHandler(request) - .catch(() => { - /* Error caught by AbstractUIService */ - }); + ?.requestHandler(request) + .then((protocolResponse?: ProtocolResponse) => { + if (!isNullOrUndefined(protocolResponse)) { + this.sendResponse(protocolResponse!); + } + }) + .catch(Constants.EMPTY_FUNCTION); }); ws.on('error', (error) => { logger.error(`${this.logPrefix(moduleName, 'start.ws.onerror')} WebSocket error:`, error); @@ -61,45 +74,42 @@ export default class UIWebSocketServer extends AbstractUIServer { logger.debug( `${this.logPrefix( moduleName, - 'start.ws.onclose' - )} WebSocket closed: '${Utils.getWebSocketCloseEventStatusString( - code - )}' - '${reason.toString()}'` + 'start.ws.onclose', + )} WebSocket closed: '${getWebSocketCloseEventStatusString( + code, + )}' - '${reason.toString()}'`, ); }); }); // eslint-disable-next-line @typescript-eslint/no-unused-vars - this.httpServer.on('connect', (req: IncomingMessage, socket: internal.Duplex, head: Buffer) => { + this.httpServer.on('connect', (req: IncomingMessage, socket: Duplex, head: Buffer) => { if (req.headers?.connection !== 'Upgrade' || req.headers?.upgrade !== 'websocket') { socket.write(`HTTP/1.1 ${StatusCodes.BAD_REQUEST} Bad Request\r\n\r\n`); socket.destroy(); } }); - this.httpServer.on( - 'upgrade', - (req: IncomingMessage, socket: internal.Duplex, head: Buffer): void => { - this.authenticate(req, (err) => { - if (err) { - socket.write(`HTTP/1.1 ${StatusCodes.UNAUTHORIZED} Unauthorized\r\n\r\n`); - socket.destroy(); - return; - } - try { - this.webSocketServer.handleUpgrade(req, socket, head, (ws: WebSocket) => { - this.webSocketServer.emit('connection', ws, req); - }); - } catch (error) { - logger.error( - `${this.logPrefix( - moduleName, - 'start.httpServer.on.upgrade' - )} Error at handling connection upgrade:`, - error - ); - } - }); - } - ); + this.httpServer.on('upgrade', (req: IncomingMessage, socket: Duplex, head: Buffer): void => { + this.authenticate(req, (err) => { + if (err) { + socket.write(`HTTP/1.1 ${StatusCodes.UNAUTHORIZED} Unauthorized\r\n\r\n`); + socket.destroy(); + return; + } + try { + this.webSocketServer.handleUpgrade(req, socket, head, (ws: WebSocket) => { + this.webSocketServer.emit('connection', ws, req); + }); + } catch (error) { + logger.error( + `${this.logPrefix( + moduleName, + 'start.httpServer.on.upgrade', + )} Error at handling connection upgrade:`, + error, + ); + } + }); + }); this.startHttpServer(); } @@ -108,9 +118,9 @@ export default class UIWebSocketServer extends AbstractUIServer { } public sendResponse(response: ProtocolResponse): void { - const responseId = response[0]; + const responseId = response?.[0]; try { - if (this.responseHandlers.has(responseId)) { + if (this.hasResponseHandler(responseId)) { const ws = this.responseHandlers.get(responseId) as WebSocket; if (ws?.readyState === WebSocket.OPEN) { ws.send(JSON.stringify(response)); @@ -118,41 +128,41 @@ export default class UIWebSocketServer extends AbstractUIServer { logger.error( `${this.logPrefix( moduleName, - 'sendResponse' - )} Error at sending response id '${responseId}', WebSocket is not open: ${ - ws?.readyState - }` + 'sendResponse', + )} Error at sending response id '${responseId}', WebSocket is not open: ${ws?.readyState}`, ); } } else { logger.error( `${this.logPrefix( moduleName, - 'sendResponse' - )} Response for unknown request id: ${responseId}` + 'sendResponse', + )} Response for unknown request id: ${responseId}`, ); } } catch (error) { logger.error( `${this.logPrefix( moduleName, - 'sendResponse' + 'sendResponse', )} Error at sending response id '${responseId}':`, - error + error, ); } finally { this.responseHandlers.delete(responseId); } } - public logPrefix(modName?: string, methodName?: string, prefixSuffix?: string): string { + public logPrefix = (modName?: string, methodName?: string, prefixSuffix?: string): string => { const logMsgPrefix = prefixSuffix ? `UI WebSocket Server ${prefixSuffix}` : 'UI WebSocket Server'; const logMsg = - modName && methodName ? ` ${logMsgPrefix} | ${modName}.${methodName}:` : ` ${logMsgPrefix} |`; - return Utils.logPrefix(logMsg); - } + isNotEmptyString(modName) && isNotEmptyString(methodName) + ? ` ${logMsgPrefix} | ${modName}.${methodName}:` + : ` ${logMsgPrefix} |`; + return logPrefix(logMsg); + }; private broadcastToClients(message: string): void { for (const client of this.webSocketServer.clients) { @@ -166,19 +176,21 @@ export default class UIWebSocketServer extends AbstractUIServer { // logger.debug( // `${this.logPrefix( // moduleName, - // 'validateRawDataRequest' - // )} Raw data received in string format: ${rawData.toString()}` + // 'validateRawDataRequest', + // // eslint-disable-next-line @typescript-eslint/no-base-to-string + // )} Raw data received in string format: ${rawData.toString()}`, // ); + // eslint-disable-next-line @typescript-eslint/no-base-to-string const request = JSON.parse(rawData.toString()) as ProtocolRequest; if (Array.isArray(request) === false) { logger.error( `${this.logPrefix( moduleName, - 'validateRawDataRequest' + 'validateRawDataRequest', )} UI protocol request is not an array:`, - request + request, ); return false; } @@ -186,18 +198,18 @@ export default class UIWebSocketServer extends AbstractUIServer { if (request.length !== 3) { logger.error( `${this.logPrefix(moduleName, 'validateRawDataRequest')} UI protocol request is malformed:`, - request + request, ); return false; } - if (Utils.validateUUID(request[0]) === false) { + if (validateUUID(request?.[0]) === false) { logger.error( `${this.logPrefix( moduleName, - 'validateRawDataRequest' + 'validateRawDataRequest', )} UI protocol request UUID field is invalid:`, - request + request, ); return false; }