X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Flib%2Fraop.c;h=f3cc399b6a5f99fc13e5a9d97e0973ddec7bc812;hb=c5f6526802d1bf48635941f564552ef059dbc1f4;hp=65830d6483e432b9bd55bc62c4c6caa39e15e4db;hpb=1d0adde592594882b70c2bec3c6e11445205423d;p=deb_shairplay.git

diff --git a/src/lib/raop.c b/src/lib/raop.c
index 65830d6..f3cc399 100644
--- a/src/lib/raop.c
+++ b/src/lib/raop.c
@@ -203,15 +203,17 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 		data = http_request_get_data(request, &datalen);
 		if (data) {
 			sdp_t *sdp;
-			const char *remotestr, *fmtpstr, *aeskeystr, *aesivstr;
+			const char *remotestr, *rtpmapstr, *fmtpstr, *aeskeystr, *aesivstr;
 
 			sdp = sdp_init(data, datalen);
 			remotestr = sdp_get_connection(sdp);
+			rtpmapstr = sdp_get_rtpmap(sdp);
 			fmtpstr = sdp_get_fmtp(sdp);
 			aeskeystr = sdp_get_rsaaeskey(sdp);
 			aesivstr = sdp_get_aesiv(sdp);
 
 			logger_log(conn->raop->logger, LOGGER_DEBUG, "connection: %s", remotestr);
+			logger_log(conn->raop->logger, LOGGER_DEBUG, "rtpmap: %s", rtpmapstr);
 			logger_log(conn->raop->logger, LOGGER_DEBUG, "fmtp: %s", fmtpstr);
 			logger_log(conn->raop->logger, LOGGER_DEBUG, "rsaaeskey: %s", aeskeystr);
 			logger_log(conn->raop->logger, LOGGER_DEBUG, "aesiv: %s", aesivstr);
@@ -226,7 +228,11 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 				raop_rtp_destroy(conn->raop_rtp);
 				conn->raop_rtp = NULL;
 			}
-			conn->raop_rtp = raop_rtp_init(raop->logger, &raop->callbacks, remotestr, fmtpstr, aeskey, aesiv);
+			conn->raop_rtp = raop_rtp_init(raop->logger, &raop->callbacks, remotestr, rtpmapstr, fmtpstr, aeskey, aesiv);
+			if (!conn->raop_rtp) {
+				logger_log(conn->raop->logger, LOGGER_ERR, "Error initializing the audio decoder");
+				http_response_set_disconnect(res, 1);
+			}
 			sdp_destroy(sdp);
 		}
 	} else if (!strcmp(method, "SETUP")) {
@@ -264,7 +270,12 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 			}
 			free(original);
 		}
-		raop_rtp_start(conn->raop_rtp, use_udp, remote_cport, remote_tport, &cport, &tport, &dport);
+		if (conn->raop_rtp) {
+			raop_rtp_start(conn->raop_rtp, use_udp, remote_cport, remote_tport, &cport, &tport, &dport);
+		} else {
+			logger_log(conn->raop->logger, LOGGER_ERR, "RAOP not initialized at SETUP, playing will fail!");
+			http_response_set_disconnect(res, 1);
+		}
 
 		memset(buffer, 0, sizeof(buffer));
 		if (use_udp) {
@@ -296,14 +307,24 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 					sscanf(datastr+8, "%f", &vol);
 					raop_rtp_set_volume(conn->raop_rtp, vol);
 				}
+			} else if (!conn->raop_rtp) {
+				logger_log(conn->raop->logger, LOGGER_WARNING, "RAOP not initialized at SET_PARAMETER volume");
 			}
 			free(datastr);
 		} else if (!strcmp(content_type, "image/jpeg")) {
 			logger_log(conn->raop->logger, LOGGER_INFO, "Got image data of %d bytes", datalen);
-			raop_rtp_set_coverart(conn->raop_rtp, data, datalen);
+			if (conn->raop_rtp) {
+				raop_rtp_set_coverart(conn->raop_rtp, data, datalen);
+			} else {
+				logger_log(conn->raop->logger, LOGGER_WARNING, "RAOP not initialized at SET_PARAMETER coverart");
+			}
 		} else if (!strcmp(content_type, "application/x-dmap-tagged")) {
 			logger_log(conn->raop->logger, LOGGER_INFO, "Got metadata of %d bytes", datalen);
-			raop_rtp_set_metadata(conn->raop_rtp, data, datalen);
+			if (conn->raop_rtp) {
+				raop_rtp_set_metadata(conn->raop_rtp, data, datalen);
+			} else {
+				logger_log(conn->raop->logger, LOGGER_WARNING, "RAOP not initialized at SET_PARAMETER metadata");
+			}
 		}
 	} else if (!strcmp(method, "FLUSH")) {
 		const char *rtpinfo;
@@ -318,6 +339,8 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 		}
 		if (conn->raop_rtp) {
 			raop_rtp_flush(conn->raop_rtp, next_seq);
+		} else {
+			logger_log(conn->raop->logger, LOGGER_WARNING, "RAOP not initialized at FLUSH");
 		}
 	} else if (!strcmp(method, "TEARDOWN")) {
 		http_response_add_header(res, "Connection", "close");
@@ -330,7 +353,7 @@ conn_request(void *ptr, http_request_t *request, http_response_t **response)
 	}
 	http_response_finish(res, NULL, 0);
 
-	logger_log(conn->raop->logger, LOGGER_DEBUG, "Got request %s with URL %s", method, http_request_get_url(request));
+	logger_log(conn->raop->logger, LOGGER_DEBUG, "Handled request %s with URL %s", method, http_request_get_url(request));
 	*response = res;
 }
 
@@ -390,7 +413,7 @@ raop_init(int max_clients, raop_callbacks_t *callbacks, const char *pemkey, int
 	httpd_cbs.conn_destroy = &conn_destroy;
 
 	/* Initialize the http daemon */
-	httpd = httpd_init(raop->logger, &httpd_cbs, max_clients, 1);
+	httpd = httpd_init(raop->logger, &httpd_cbs, max_clients);
 	if (!httpd) {
 		free(raop);
 		return NULL;