X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Fabstract-worker-choice-strategy.ts;h=f064c2e0838e0a68b1a809648c457308cf107eb4;hb=c3c5b1b661042ee1e3f8d04a01974dcfe7bd6a82;hp=9aabdfd29d3a512df229b7b28bcfe631eaae2804;hpb=138d29a820e8a61d10ba03fe42c5d77596ef788c;p=poolifier.git diff --git a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts index 9aabdfd2..f064c2e0 100644 --- a/src/pools/selection-strategies/abstract-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/abstract-worker-choice-strategy.ts @@ -1,9 +1,10 @@ +import { cpus } from 'node:os' import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils' import type { IPool } from '../pool' import type { IWorker } from '../worker' import type { IWorkerChoiceStrategy, - RequiredStatistics, + TaskStatistics, WorkerChoiceStrategyOptions } from './selection-strategies-types' @@ -24,10 +25,14 @@ export abstract class AbstractWorkerChoiceStrategy< */ private toggleFindLastFreeWorkerNodeKey: boolean = false /** @inheritDoc */ - public readonly requiredStatistics: RequiredStatistics = { + public readonly taskStatistics: TaskStatistics = { runTime: false, avgRunTime: false, - medRunTime: false + medRunTime: false, + waitTime: false, + avgWaitTime: false, + medWaitTime: false, + elu: false } /** @@ -43,22 +48,22 @@ export abstract class AbstractWorkerChoiceStrategy< this.choose = this.choose.bind(this) } - protected checkOptions (opts: WorkerChoiceStrategyOptions): void { - if (this.requiredStatistics.avgRunTime && opts.medRunTime === true) { - this.requiredStatistics.avgRunTime = false - this.requiredStatistics.medRunTime = opts.medRunTime as boolean + protected setTaskStatistics (opts: WorkerChoiceStrategyOptions): void { + if (this.taskStatistics.avgRunTime && opts.medRunTime === true) { + this.taskStatistics.avgRunTime = false + this.taskStatistics.medRunTime = opts.medRunTime as boolean } - if (this.requiredStatistics.medRunTime && opts.medRunTime === false) { - this.requiredStatistics.avgRunTime = true - this.requiredStatistics.medRunTime = opts.medRunTime as boolean + if (this.taskStatistics.medRunTime && opts.medRunTime === false) { + this.taskStatistics.avgRunTime = true + this.taskStatistics.medRunTime = opts.medRunTime as boolean } - if ( - opts.weights != null && - Object.keys(opts.weights).length < this.pool.size - ) { - throw new Error( - 'Worker choice strategy options must have a weight for each worker node.' - ) + if (this.taskStatistics.avgWaitTime && opts.medWaitTime === true) { + this.taskStatistics.avgWaitTime = false + this.taskStatistics.medWaitTime = opts.medWaitTime as boolean + } + if (this.taskStatistics.medWaitTime && opts.medWaitTime === false) { + this.taskStatistics.avgWaitTime = true + this.taskStatistics.medWaitTime = opts.medWaitTime as boolean } } @@ -66,7 +71,7 @@ export abstract class AbstractWorkerChoiceStrategy< public abstract reset (): boolean /** @inheritDoc */ - public abstract update (): boolean + public abstract update (workerNodeKey: number): boolean /** @inheritDoc */ public abstract choose (): number @@ -77,7 +82,7 @@ export abstract class AbstractWorkerChoiceStrategy< /** @inheritDoc */ public setOptions (opts: WorkerChoiceStrategyOptions): void { opts = opts ?? DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS - this.checkOptions(opts) + this.setTaskStatistics(opts) this.opts = opts } @@ -95,6 +100,45 @@ export abstract class AbstractWorkerChoiceStrategy< return this.findFirstFreeWorkerNodeKey() } + /** + * Gets the worker task runtime. + * If the task statistics wants `avgRunTime`, the average runtime is returned. + * If the task statistics wants `medRunTime`, the median runtime is returned. + * + * @param workerNodeKey - The worker node key. + * @returns The worker task runtime. + */ + protected getWorkerTaskRunTime (workerNodeKey: number): number { + return this.taskStatistics.medRunTime + ? this.pool.workerNodes[workerNodeKey].workerUsage.runTime.median + : this.pool.workerNodes[workerNodeKey].workerUsage.runTime.average + } + + /** + * Gets the worker task wait time. + * If the task statistics wants `avgWaitTime`, the average wait time is returned. + * If the task statistics wants `medWaitTime`, the median wait time is returned. + * + * @param workerNodeKey - The worker node key. + * @returns The worker task wait time. + */ + protected getWorkerWaitTime (workerNodeKey: number): number { + return this.taskStatistics.medWaitTime + ? this.pool.workerNodes[workerNodeKey].workerUsage.runTime.median + : this.pool.workerNodes[workerNodeKey].workerUsage.runTime.average + } + + protected computeDefaultWorkerWeight (): number { + let cpusCycleTimeWeight = 0 + for (const cpu of cpus()) { + // CPU estimated cycle time + const numberOfDigits = cpu.speed.toString().length - 1 + const cpuCycleTime = 1 / (cpu.speed / Math.pow(10, numberOfDigits)) + cpusCycleTimeWeight += cpuCycleTime * Math.pow(10, numberOfDigits) + } + return Math.round(cpusCycleTimeWeight / cpus().length) + } + /** * Finds the first free worker node key based on the number of tasks the worker has applied. * @@ -106,7 +150,7 @@ export abstract class AbstractWorkerChoiceStrategy< */ private findFirstFreeWorkerNodeKey (): number { return this.pool.workerNodes.findIndex(workerNode => { - return workerNode.tasksUsage?.running === 0 + return workerNode.workerUsage.tasks.executing === 0 }) } @@ -122,11 +166,17 @@ export abstract class AbstractWorkerChoiceStrategy< private findLastFreeWorkerNodeKey (): number { // It requires node >= 18.0.0: // return this.workerNodes.findLastIndex(workerNode => { - // return workerNode.tasksUsage?.running === 0 + // return workerNode.workerUsage.tasks.executing === 0 // }) - for (let i = this.pool.workerNodes.length - 1; i >= 0; i--) { - if (this.pool.workerNodes[i].tasksUsage?.running === 0) { - return i + for ( + let workerNodeKey = this.pool.workerNodes.length - 1; + workerNodeKey >= 0; + workerNodeKey-- + ) { + if ( + this.pool.workerNodes[workerNodeKey].workerUsage.tasks.executing === 0 + ) { + return workerNodeKey } } return -1