X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Ffair-share-worker-choice-strategy.ts;h=7b3ad3f7516f2b9522aca6acf3ec6b0356aabac3;hb=d262e04c193ce648ddd6c0cb1dfaeb9264928c8c;hp=e26f6b8f5953dff0b3d6dc1d59469977ab264494;hpb=f7edd2ec05d1d8b8cc9e83016e85784fa0e987f1;p=poolifier.git diff --git a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts index e26f6b8f..7b3ad3f7 100644 --- a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts @@ -2,10 +2,11 @@ import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils' import type { IPool } from '../pool' import type { IWorker } from '../worker' import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy' -import type { - IWorkerChoiceStrategy, - RequiredStatistics, - WorkerChoiceStrategyOptions +import { + type IWorkerChoiceStrategy, + Measurements, + type TaskStatisticsRequirements, + type WorkerChoiceStrategyOptions } from './selection-strategies-types' /** @@ -24,10 +25,22 @@ export class FairShareWorkerChoiceStrategy< extends AbstractWorkerChoiceStrategy implements IWorkerChoiceStrategy { /** @inheritDoc */ - public readonly requiredStatistics: RequiredStatistics = { - runTime: true, - avgRunTime: true, - medRunTime: false + public readonly taskStatisticsRequirements: TaskStatisticsRequirements = { + runTime: { + aggregate: true, + average: true, + median: false + }, + waitTime: { + aggregate: false, + average: false, + median: false + }, + elu: { + aggregate: true, + average: true, + median: false + } } /** @@ -41,7 +54,7 @@ export class FairShareWorkerChoiceStrategy< opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS ) { super(pool, opts) - this.setRequiredStatistics(this.opts) + this.setTaskStatisticsRequirements(this.opts) } /** @inheritDoc */ @@ -59,7 +72,6 @@ export class FairShareWorkerChoiceStrategy< /** @inheritDoc */ public choose (): number { let minWorkerVirtualTaskEndTimestamp = Infinity - let chosenWorkerNodeKey!: number for (const [workerNodeKey] of this.pool.workerNodes.entries()) { if (this.workersVirtualTaskEndTimestamp[workerNodeKey] == null) { this.computeWorkerVirtualTaskEndTimestamp(workerNodeKey) @@ -68,10 +80,10 @@ export class FairShareWorkerChoiceStrategy< this.workersVirtualTaskEndTimestamp[workerNodeKey] if (workerVirtualTaskEndTimestamp < minWorkerVirtualTaskEndTimestamp) { minWorkerVirtualTaskEndTimestamp = workerVirtualTaskEndTimestamp - chosenWorkerNodeKey = workerNodeKey + this.nextWorkerNodeId = workerNodeKey } } - return chosenWorkerNodeKey + return this.nextWorkerNodeId } /** @inheritDoc */ @@ -97,9 +109,11 @@ export class FairShareWorkerChoiceStrategy< workerNodeKey: number, workerVirtualTaskStartTimestamp: number ): number { - return ( - workerVirtualTaskStartTimestamp + this.getWorkerTaskRunTime(workerNodeKey) - ) + const workerTaskRunTime = + this.opts.measurement === Measurements.elu + ? this.getWorkerTaskElu(workerNodeKey) + : this.getWorkerTaskRunTime(workerNodeKey) + return workerVirtualTaskStartTimestamp + workerTaskRunTime } private getWorkerVirtualTaskStartTimestamp (workerNodeKey: number): number {