X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Ffair-share-worker-choice-strategy.ts;h=e1d123a994aa77f5d41ce10ccf2a4f3584b6c926;hb=12ae3210477b0c54380db24470ff3b0e78926bd8;hp=16d5a7be1dd60ca213a873c1571f8335948ac826;hpb=17393ac83cbf0eacf68ea9efb0a577cc30a5c685;p=poolifier.git diff --git a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts index 16d5a7be..e1d123a9 100644 --- a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts @@ -1,4 +1,4 @@ -import type { IPoolWorker } from '../pool-worker' +import type { IWorker } from '../worker' import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy' import type { IWorkerChoiceStrategy, @@ -22,7 +22,7 @@ interface WorkerVirtualTaskTimestamp { * @typeParam Response - Type of response of execution. This can only be serializable data. */ export class FairShareWorkerChoiceStrategy< - Worker extends IPoolWorker, + Worker extends IWorker, Data = unknown, Response = unknown > @@ -31,11 +31,12 @@ export class FairShareWorkerChoiceStrategy< /** @inheritDoc */ public readonly requiredStatistics: RequiredStatistics = { runTime: true, - avgRunTime: true + avgRunTime: true, + medRunTime: false } /** - * Worker last virtual task execution timestamp. + * Worker last virtual task execution timestamp. */ private readonly workerLastVirtualTaskTimestamp: Map< number, @@ -51,8 +52,8 @@ export class FairShareWorkerChoiceStrategy< /** @inheritDoc */ public choose (): number { let minWorkerVirtualTaskEndTimestamp = Infinity - let chosenWorkerKey!: number - for (const [index] of this.pool.workers.entries()) { + let chosenWorkerNodeKey!: number + for (const [index] of this.pool.workerNodes.entries()) { this.computeWorkerLastVirtualTaskTimestamp(index) const workerLastVirtualTaskEndTimestamp = this.workerLastVirtualTaskTimestamp.get(index)?.end ?? 0 @@ -60,38 +61,39 @@ export class FairShareWorkerChoiceStrategy< workerLastVirtualTaskEndTimestamp < minWorkerVirtualTaskEndTimestamp ) { minWorkerVirtualTaskEndTimestamp = workerLastVirtualTaskEndTimestamp - chosenWorkerKey = index + chosenWorkerNodeKey = index } } - return chosenWorkerKey + return chosenWorkerNodeKey } /** @inheritDoc */ - public remove (workerKey: number): boolean { - const workerDeleted = this.workerLastVirtualTaskTimestamp.delete(workerKey) + public remove (workerNodeKey: number): boolean { + const deleted = this.workerLastVirtualTaskTimestamp.delete(workerNodeKey) for (const [key, value] of this.workerLastVirtualTaskTimestamp.entries()) { - if (key > workerKey) { + if (key > workerNodeKey) { this.workerLastVirtualTaskTimestamp.set(key - 1, value) } } - return workerDeleted + return deleted } /** * Computes worker last virtual task timestamp. * - * @param workerKey - The worker key. + * @param workerNodeKey - The worker node key. */ - private computeWorkerLastVirtualTaskTimestamp (workerKey: number): void { + private computeWorkerLastVirtualTaskTimestamp (workerNodeKey: number): void { const workerVirtualTaskStartTimestamp = Math.max( - Date.now(), - this.workerLastVirtualTaskTimestamp.get(workerKey)?.end ?? -Infinity + performance.now(), + this.workerLastVirtualTaskTimestamp.get(workerNodeKey)?.end ?? -Infinity ) - this.workerLastVirtualTaskTimestamp.set(workerKey, { + const workerVirtualTaskTRunTime = this.requiredStatistics.medRunTime + ? this.pool.workerNodes[workerNodeKey].tasksUsage.medRunTime + : this.pool.workerNodes[workerNodeKey].tasksUsage.avgRunTime + this.workerLastVirtualTaskTimestamp.set(workerNodeKey, { start: workerVirtualTaskStartTimestamp, - end: - workerVirtualTaskStartTimestamp + - (this.pool.workers[workerKey].tasksUsage.avgRunTime ?? 0) + end: workerVirtualTaskStartTimestamp + (workerVirtualTaskTRunTime ?? 0) }) } }