X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Finterleaved-weighted-round-robin-worker-choice-strategy.ts;h=7d77a21db5340bcd68a72e731f07ef01de76898b;hb=230fcf18603f74badb3446048ed9feaf24afa54a;hp=24f7ac9a4cec4c151774c74b8ecaa6f50f23f02a;hpb=720b5f8fb8094639055da32ed9b9139ded4450ac;p=poolifier.git diff --git a/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts b/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts index 24f7ac9a..7d77a21d 100644 --- a/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts @@ -1,11 +1,9 @@ -import { cpus } from 'node:os' import type { IWorker } from '../worker' import type { IPool } from '../pool' import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils' import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy' import type { IWorkerChoiceStrategy, - RequiredStatistics, WorkerChoiceStrategyOptions } from './selection-strategies-types' @@ -23,13 +21,6 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< > extends AbstractWorkerChoiceStrategy implements IWorkerChoiceStrategy { - /** @inheritDoc */ - public readonly requiredStatistics: RequiredStatistics = { - runTime: true, - avgRunTime: true, - medRunTime: false - } - /** * Worker node id where the current task will be submitted. */ @@ -54,7 +45,7 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS ) { super(pool, opts) - this.checkOptions(this.opts) + this.setTaskStatisticsRequirements(this.opts) this.defaultWorkerWeight = this.computeDefaultWorkerWeight() this.roundWeights = this.getRoundWeights() } @@ -76,9 +67,9 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< let roundId: number | undefined let workerNodeId: number | undefined for ( - let round = this.currentRoundId; - round < this.roundWeights.length; - round++ + let roundIndex = this.currentRoundId; + roundIndex < this.roundWeights.length; + roundIndex++ ) { for ( let workerNodeKey = this.currentWorkerNodeId; @@ -87,8 +78,8 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< ) { const workerWeight = this.opts.weights?.[workerNodeKey] ?? this.defaultWorkerWeight - if (workerWeight >= this.roundWeights[round]) { - roundId = round + if (workerWeight >= this.roundWeights[roundIndex]) { + roundId = roundIndex workerNodeId = workerNodeKey break } @@ -131,17 +122,6 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< this.roundWeights = this.getRoundWeights() } - private computeDefaultWorkerWeight (): number { - let cpusCycleTimeWeight = 0 - for (const cpu of cpus()) { - // CPU estimated cycle time - const numberOfDigits = cpu.speed.toString().length - 1 - const cpuCycleTime = 1 / (cpu.speed / Math.pow(10, numberOfDigits)) - cpusCycleTimeWeight += cpuCycleTime * Math.pow(10, numberOfDigits) - } - return Math.round(cpusCycleTimeWeight / cpus().length) - } - private getRoundWeights (): number[] { if (this.opts.weights == null) { return [this.defaultWorkerWeight]