X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Finterleaved-weighted-round-robin-worker-choice-strategy.ts;h=85f3148374e5b0c5cf932425772779839f217ca0;hb=2c039e4373e86714cdf27e77440b12ee8eb2e4db;hp=7248f03a90ae8f9ec599eb3c062eb6349337c95c;hpb=0bbf65c3768b86f989056de36de0199d6e35562a;p=poolifier.git diff --git a/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts b/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts index 7248f03a..85f31483 100644 --- a/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts @@ -4,6 +4,7 @@ import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils' import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy' import type { IWorkerChoiceStrategy, + StrategyPolicy, WorkerChoiceStrategyOptions } from './selection-strategies-types' @@ -21,15 +22,16 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< > extends AbstractWorkerChoiceStrategy implements IWorkerChoiceStrategy { + /** @inheritDoc */ + public readonly strategyPolicy: StrategyPolicy = { + useDynamicWorker: true + } + /** - * Worker node id where the current task will be submitted. - */ - private currentWorkerNodeId: number = 0 - /** - * Current round id. + * Round id. * This is used to determine the current round weight. */ - private currentRoundId: number = 0 + private roundId: number = 0 /** * Round weights. */ @@ -45,15 +47,15 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS ) { super(pool, opts) - this.setRequiredStatistics(this.opts) + this.setTaskStatisticsRequirements(this.opts) this.defaultWorkerWeight = this.computeDefaultWorkerWeight() this.roundWeights = this.getRoundWeights() } /** @inheritDoc */ public reset (): boolean { - this.currentWorkerNodeId = 0 - this.currentRoundId = 0 + this.nextWorkerNodeId = 0 + this.roundId = 0 return true } @@ -67,12 +69,12 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< let roundId: number | undefined let workerNodeId: number | undefined for ( - let roundIndex = this.currentRoundId; + let roundIndex = this.roundId; roundIndex < this.roundWeights.length; roundIndex++ ) { for ( - let workerNodeKey = this.currentWorkerNodeId; + let workerNodeKey = this.nextWorkerNodeId; workerNodeKey < this.pool.workerNodes.length; workerNodeKey++ ) { @@ -85,32 +87,28 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy< } } } - this.currentRoundId = roundId ?? 0 - this.currentWorkerNodeId = workerNodeId ?? 0 - const chosenWorkerNodeKey = this.currentWorkerNodeId - if (this.currentWorkerNodeId === this.pool.workerNodes.length - 1) { - this.currentWorkerNodeId = 0 - this.currentRoundId = - this.currentRoundId === this.roundWeights.length - 1 - ? 0 - : this.currentRoundId + 1 + this.roundId = roundId ?? 0 + this.nextWorkerNodeId = workerNodeId ?? 0 + const chosenWorkerNodeKey = this.nextWorkerNodeId + if (this.nextWorkerNodeId === this.pool.workerNodes.length - 1) { + this.nextWorkerNodeId = 0 + this.roundId = + this.roundId === this.roundWeights.length - 1 ? 0 : this.roundId + 1 } else { - this.currentWorkerNodeId = this.currentWorkerNodeId + 1 + this.nextWorkerNodeId = this.nextWorkerNodeId + 1 } return chosenWorkerNodeKey } /** @inheritDoc */ public remove (workerNodeKey: number): boolean { - if (this.currentWorkerNodeId === workerNodeKey) { + if (this.nextWorkerNodeId === workerNodeKey) { if (this.pool.workerNodes.length === 0) { - this.currentWorkerNodeId = 0 - } else if (this.currentWorkerNodeId > this.pool.workerNodes.length - 1) { - this.currentWorkerNodeId = this.pool.workerNodes.length - 1 - this.currentRoundId = - this.currentRoundId === this.roundWeights.length - 1 - ? 0 - : this.currentRoundId + 1 + this.nextWorkerNodeId = 0 + } else if (this.nextWorkerNodeId > this.pool.workerNodes.length - 1) { + this.nextWorkerNodeId = this.pool.workerNodes.length - 1 + this.roundId = + this.roundId === this.roundWeights.length - 1 ? 0 : this.roundId + 1 } } return true