X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Fleast-elu-worker-choice-strategy.ts;h=54d0e7cb054de064d8f9dfbfe074df5f1ba5bbf6;hb=98e72cda1ce363322fc7ae868b66dec89a1ad74c;hp=eca5a1cf541eca5d25102cacf821a08b556ad894;hpb=d33be4309c69e39da5e81479e40b1a5ec7078bd5;p=poolifier.git diff --git a/src/pools/selection-strategies/least-elu-worker-choice-strategy.ts b/src/pools/selection-strategies/least-elu-worker-choice-strategy.ts index eca5a1cf..54d0e7cb 100644 --- a/src/pools/selection-strategies/least-elu-worker-choice-strategy.ts +++ b/src/pools/selection-strategies/least-elu-worker-choice-strategy.ts @@ -1,4 +1,7 @@ -import { DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS } from '../../utils' +import { + DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS, + DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS +} from '../../utils' import type { IPool } from '../pool' import type { IWorker } from '../worker' import { AbstractWorkerChoiceStrategy } from './abstract-worker-choice-strategy' @@ -12,8 +15,8 @@ import type { * Selects the worker with the least ELU. * * @typeParam Worker - Type of worker which manages the strategy. - * @typeParam Data - Type of data sent to the worker. This can only be serializable data. - * @typeParam Response - Type of execution response. This can only be serializable data. + * @typeParam Data - Type of data sent to the worker. This can only be structured-cloneable data. + * @typeParam Response - Type of execution response. This can only be structured-cloneable data. */ export class LeastEluWorkerChoiceStrategy< Worker extends IWorker, @@ -24,16 +27,8 @@ export class LeastEluWorkerChoiceStrategy< implements IWorkerChoiceStrategy { /** @inheritDoc */ public readonly taskStatisticsRequirements: TaskStatisticsRequirements = { - runTime: { - aggregate: false, - average: false, - median: false - }, - waitTime: { - aggregate: false, - average: false, - median: false - }, + runTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS, + waitTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS, elu: { aggregate: true, average: false, @@ -57,23 +52,23 @@ export class LeastEluWorkerChoiceStrategy< /** @inheritDoc */ public update (): boolean { + return true + } + + /** @inheritDoc */ + public choose (): number { let minWorkerElu = Infinity for (const [workerNodeKey, workerNode] of this.pool.workerNodes.entries()) { - const workerUsage = workerNode.workerUsage - const workerElu = workerUsage.elu?.active.aggregate ?? 0 + const workerUsage = workerNode.usage + const workerElu = workerUsage.elu?.active?.aggregate ?? 0 if (workerElu === 0) { this.nextWorkerNodeId = workerNodeKey - return true + break } else if (workerElu < minWorkerElu) { minWorkerElu = workerElu this.nextWorkerNodeId = workerNodeKey } } - return true - } - - /** @inheritDoc */ - public choose (): number { return this.nextWorkerNodeId }