X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fpools%2Fselection-strategies%2Fworker-choice-strategy-context.ts;h=a3e3379c9ac461fc7cd16c2d32bb8735ca2d50ff;hb=46e29227a97fe04f886969199f1c14338af50543;hp=7729f4f73a4c19b61c0fa718f889639279bcfed9;hpb=968a2e8ca7bfc81d61b5ffc820a6a76bf44b202f;p=poolifier.git diff --git a/src/pools/selection-strategies/worker-choice-strategy-context.ts b/src/pools/selection-strategies/worker-choice-strategy-context.ts index 7729f4f7..a3e3379c 100644 --- a/src/pools/selection-strategies/worker-choice-strategy-context.ts +++ b/src/pools/selection-strategies/worker-choice-strategy-context.ts @@ -34,6 +34,11 @@ export class WorkerChoiceStrategyContext< IWorkerChoiceStrategy > + /** + * The number of times the worker choice strategy in the context has been retried. + */ + private choiceRetriesCount = 0 + /** * Worker choice strategy context constructor. * @@ -44,8 +49,9 @@ export class WorkerChoiceStrategyContext< public constructor ( pool: IPool, private workerChoiceStrategy: WorkerChoiceStrategy = WorkerChoiceStrategies.ROUND_ROBIN, - opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS + private opts: WorkerChoiceStrategyOptions = DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS ) { + this.opts = { ...DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS, ...opts } this.execute = this.execute.bind(this) this.workerChoiceStrategies = new Map< WorkerChoiceStrategy, @@ -119,7 +125,7 @@ export class WorkerChoiceStrategyContext< } /** - * Gets the worker choice strategy task statistics requirements in the context. + * Gets the worker choice strategy in the context task statistics requirements. * * @returns The task statistics requirements. */ @@ -146,7 +152,7 @@ export class WorkerChoiceStrategyContext< } /** - * Updates the worker node key in the worker choice strategy internals in the context. + * Updates the worker node key in the worker choice strategy in the context internals. * * @returns `true` if the update is successful, `false` otherwise. */ @@ -159,10 +165,10 @@ export class WorkerChoiceStrategyContext< } /** - * Executes the worker choice strategy algorithm in the context. + * Executes the worker choice strategy in the context algorithm. * * @returns The key of the worker node. - * @throws {@link Error} If the worker node key is null or undefined. + * @throws {@link https://nodejs.org/api/errors.html#class-error} If the worker node key is null or undefined. */ public execute (): number { const workerNodeKey = ( @@ -170,16 +176,25 @@ export class WorkerChoiceStrategyContext< this.workerChoiceStrategy ) as IWorkerChoiceStrategy ).choose() - if (workerNodeKey == null) { - throw new Error('Worker node key chosen is null or undefined') + if ( + workerNodeKey == null && + this.choiceRetriesCount < (this.opts.choiceRetries as number) + ) { + this.choiceRetriesCount++ + return this.execute() + } else if (workerNodeKey == null) { + throw new TypeError( + `Worker node key chosen is null or undefined after ${this.choiceRetriesCount} retries` + ) } + this.choiceRetriesCount = 0 return workerNodeKey } /** * Removes the worker node key from the worker choice strategy in the context. * - * @param workerNodeKey - The key of the worker node. + * @param workerNodeKey - The worker node key. * @returns `true` if the removal is successful, `false` otherwise. */ public remove (workerNodeKey: number): boolean { @@ -196,6 +211,7 @@ export class WorkerChoiceStrategyContext< * @param opts - The worker choice strategy options. */ public setOptions (opts: WorkerChoiceStrategyOptions): void { + this.opts = { ...DEFAULT_WORKER_CHOICE_STRATEGY_OPTIONS, ...opts } for (const workerChoiceStrategy of this.workerChoiceStrategies.values()) { workerChoiceStrategy.setOptions(opts) }