X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=src%2Fworker%2Fabstract-worker.ts;h=3a81e0f847f753ea55a7630d45a72fd08ec18a85;hb=b8f3418c31a95b3b90a88ce07a34c9046a376fc3;hp=54358ee64b58adfb1a4f9275f53a04185ea878e8;hpb=473c717a499d52ce8a069c43ee168b70cb5701f1;p=poolifier.git

diff --git a/src/worker/abstract-worker.ts b/src/worker/abstract-worker.ts
index 54358ee6..3a81e0f8 100644
--- a/src/worker/abstract-worker.ts
+++ b/src/worker/abstract-worker.ts
@@ -12,9 +12,9 @@ const DEFAULT_KILL_BEHAVIOR: KillBehavior = KillBehaviors.SOFT
 /**
  * Base class that implements some shared logic for all poolifier workers.
  *
- * @template MainWorker Type of main worker.
- * @template Data Type of data this worker receives from pool's execution. This can only be serializable data.
- * @template Response Type of response the worker sends back to the main worker. This can only be serializable data.
+ * @typeParam MainWorker - Type of main worker.
+ * @typeParam Data - Type of data this worker receives from pool's execution. This can only be serializable data.
+ * @typeParam Response - Type of response the worker sends back to the main worker. This can only be serializable data.
  */
 export abstract class AbstractWorker<
   MainWorker extends Worker | MessagePort,
@@ -36,11 +36,11 @@ export abstract class AbstractWorker<
   /**
    * Constructs a new poolifier worker.
    *
-   * @param type The type of async event.
-   * @param isMain Whether this is the main worker or not.
-   * @param fn Function processed by the worker when the pool's `execution` function is invoked.
-   * @param mainWorker Reference to main worker.
-   * @param opts Options for the worker.
+   * @param type - The type of async event.
+   * @param isMain - Whether this is the main worker or not.
+   * @param fn - Function processed by the worker when the pool's `execution` function is invoked.
+   * @param mainWorker - Reference to main worker.
+   * @param opts - Options for the worker.
    */
   public constructor (
     type: string,
@@ -65,7 +65,7 @@ export abstract class AbstractWorker<
     this.checkWorkerOptions(this.opts)
     this.lastTaskTimestamp = Date.now()
     // Keep the worker active
-    if (isMain === false) {
+    if (!isMain) {
       this.aliveInterval = setInterval(
         this.checkAlive.bind(this),
         (this.opts.maxInactiveTime ?? DEFAULT_MAX_INACTIVE_TIME) / 2
@@ -95,25 +95,28 @@ export abstract class AbstractWorker<
       this.mainWorker = value.parent
     } else if (value.kill !== undefined) {
       // Here is time to kill this worker, just clearing the interval
-      if (this.aliveInterval) clearInterval(this.aliveInterval)
+      if (this.aliveInterval != null) clearInterval(this.aliveInterval)
       this.emitDestroy()
     }
   }
 
-  private checkWorkerOptions (opts: WorkerOptions) {
+  private checkWorkerOptions (opts: WorkerOptions): void {
     this.opts.killBehavior = opts.killBehavior ?? DEFAULT_KILL_BEHAVIOR
     this.opts.maxInactiveTime =
       opts.maxInactiveTime ?? DEFAULT_MAX_INACTIVE_TIME
-    this.opts.async = !!opts.async
+    this.opts.async = opts.async ?? false
   }
 
   /**
    * Checks if the `fn` parameter is passed to the constructor.
    *
-   * @param fn The function that should be defined.
+   * @param fn - The function that should be defined.
    */
   private checkFunctionInput (fn: (data: Data) => Response): void {
-    if (!fn) throw new Error('fn parameter is mandatory')
+    if (fn == null) throw new Error('fn parameter is mandatory')
+    if (typeof fn !== 'function') {
+      throw new TypeError('fn parameter is not a function')
+    }
   }
 
   /**
@@ -122,7 +125,7 @@ export abstract class AbstractWorker<
    * @returns Reference to the main worker.
    */
   protected getMainWorker (): MainWorker {
-    if (!this.mainWorker) {
+    if (this.mainWorker == null) {
       throw new Error('Main worker was not set')
     }
     return this.mainWorker
@@ -131,7 +134,7 @@ export abstract class AbstractWorker<
   /**
    * Sends a message to the main worker.
    *
-   * @param message The response message.
+   * @param message - The response message.
    */
   protected abstract sendToMainWorker (message: MessageValue<Response>): void
 
@@ -150,7 +153,7 @@ export abstract class AbstractWorker<
   /**
    * Handles an error and convert it to a string so it can be sent back to the main worker.
    *
-   * @param e The error raised by the worker.
+   * @param e - The error raised by the worker.
    * @returns Message of the error.
    */
   protected handleError (e: Error | string): string {
@@ -160,8 +163,8 @@ export abstract class AbstractWorker<
   /**
    * Runs the given function synchronously.
    *
-   * @param fn Function that will be executed.
-   * @param value Input data for the given function.
+   * @param fn - Function that will be executed.
+   * @param value - Input data for the given function.
    */
   protected run (
     fn: (data?: Data) => Response,
@@ -183,8 +186,8 @@ export abstract class AbstractWorker<
   /**
    * Runs the given function asynchronously.
    *
-   * @param fn Function that will be executed.
-   * @param value Input data for the given function.
+   * @param fn - Function that will be executed.
+   * @param value - Input data for the given function.
    */
   protected runAsync (
     fn: (data?: Data) => Promise<Response>,