X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=tests%2Fpools%2Fselection-strategies%2Fworker-choice-strategy-context.test.js;h=23d954c9f13159940e542c8774a3d22feefeaaad;hb=594bfb844b5eb66cf533715a6ddad1799b1f5f8f;hp=9380a038800abcb246c532240717940fe735e79f;hpb=168c526f6e6913506e56f7d5107335c3d3d42938;p=poolifier.git diff --git a/tests/pools/selection-strategies/worker-choice-strategy-context.test.js b/tests/pools/selection-strategies/worker-choice-strategy-context.test.js index 9380a038..23d954c9 100644 --- a/tests/pools/selection-strategies/worker-choice-strategy-context.test.js +++ b/tests/pools/selection-strategies/worker-choice-strategy-context.test.js @@ -23,9 +23,6 @@ const { const { WeightedRoundRobinWorkerChoiceStrategy } = require('../../../lib/pools/selection-strategies/weighted-round-robin-worker-choice-strategy') -const { - DynamicPoolWorkerChoiceStrategy -} = require('../../../lib/pools/selection-strategies/dynamic-pool-worker-choice-strategy') describe('Worker choice strategy context test suite', () => { const min = 1 @@ -53,6 +50,15 @@ describe('Worker choice strategy context test suite', () => { await dynamicPool.destroy() }) + it('Verify that constructor() initializes the context with all the available worker choice strategies', () => { + const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( + fixedPool + ) + expect(workerChoiceStrategyContext.workerChoiceStrategies.size).toBe( + Object.keys(WorkerChoiceStrategies).length + ) + }) + it('Verify that execute() return the worker chosen by the strategy with fixed pool', () => { const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool @@ -60,15 +66,23 @@ describe('Worker choice strategy context test suite', () => { const WorkerChoiceStrategyStub = sinon.createStubInstance( RoundRobinWorkerChoiceStrategy, { - choose: sinon.stub().returns('worker') + choose: sinon.stub().returns(0) } ) - workerChoiceStrategyContext.workerChoiceStrategy = WorkerChoiceStrategyStub - const chosenWorker = workerChoiceStrategyContext.execute() + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + WorkerChoiceStrategies.ROUND_ROBIN + ) + workerChoiceStrategyContext.workerChoiceStrategies.set( + workerChoiceStrategyContext.workerChoiceStrategy, + WorkerChoiceStrategyStub + ) + const chosenWorkerKey = workerChoiceStrategyContext.execute() expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().choose.calledOnce + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategyContext.workerChoiceStrategy + ).choose.calledOnce ).toBe(true) - expect(chosenWorker).toBe('worker') + expect(chosenWorkerKey).toBe(0) }) it('Verify that execute() return the worker chosen by the strategy with dynamic pool', () => { @@ -78,149 +92,248 @@ describe('Worker choice strategy context test suite', () => { const WorkerChoiceStrategyStub = sinon.createStubInstance( RoundRobinWorkerChoiceStrategy, { - choose: sinon.stub().returns('worker') + choose: sinon.stub().returns(0) } ) - workerChoiceStrategyContext.workerChoiceStrategy = WorkerChoiceStrategyStub - const chosenWorker = workerChoiceStrategyContext.execute() + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + WorkerChoiceStrategies.ROUND_ROBIN + ) + workerChoiceStrategyContext.workerChoiceStrategies.set( + workerChoiceStrategyContext.workerChoiceStrategy, + WorkerChoiceStrategyStub + ) + const chosenWorkerKey = workerChoiceStrategyContext.execute() expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().choose.calledOnce + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategyContext.workerChoiceStrategy + ).choose.calledOnce ).toBe(true) - expect(chosenWorker).toBe('worker') + expect(chosenWorkerKey).toBe(0) }) it('Verify that setWorkerChoiceStrategy() works with ROUND_ROBIN and fixed pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.ROUND_ROBIN const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.ROUND_ROBIN + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(false) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) + ).toBeInstanceOf(RoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy ) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(RoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with ROUND_ROBIN and dynamic pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.ROUND_ROBIN const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( dynamicPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.ROUND_ROBIN - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() - ).toBeInstanceOf(DynamicPoolWorkerChoiceStrategy) + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(true) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) + ).toBeInstanceOf(RoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().workerChoiceStrategy + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(RoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with LESS_USED and fixed pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.LESS_USED const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.LESS_USED - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(false) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(LessUsedWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with LESS_USED and dynamic pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.LESS_USED const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( dynamicPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.LESS_USED - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() - ).toBeInstanceOf(DynamicPoolWorkerChoiceStrategy) + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(true) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().workerChoiceStrategy + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(LessUsedWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with LESS_BUSY and fixed pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.LESS_BUSY const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.LESS_BUSY - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(false) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(LessBusyWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with LESS_BUSY and dynamic pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.LESS_BUSY const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( dynamicPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.LESS_BUSY - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() - ).toBeInstanceOf(DynamicPoolWorkerChoiceStrategy) + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(true) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().workerChoiceStrategy + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(LessBusyWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with FAIR_SHARE and fixed pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.FAIR_SHARE const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.FAIR_SHARE - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(false) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(FairShareWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with FAIR_SHARE and dynamic pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.FAIR_SHARE const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( dynamicPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.FAIR_SHARE - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() - ).toBeInstanceOf(DynamicPoolWorkerChoiceStrategy) + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(true) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().workerChoiceStrategy + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(FairShareWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with WEIGHTED_ROUND_ROBIN and fixed pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.WEIGHTED_ROUND_ROBIN const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( fixedPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.WEIGHTED_ROUND_ROBIN - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(false) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) + expect( + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(WeightedRoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) it('Verify that setWorkerChoiceStrategy() works with WEIGHTED_ROUND_ROBIN and dynamic pool', () => { + const workerChoiceStrategy = WorkerChoiceStrategies.WEIGHTED_ROUND_ROBIN const workerChoiceStrategyContext = new WorkerChoiceStrategyContext( dynamicPool ) - workerChoiceStrategyContext.setWorkerChoiceStrategy( - WorkerChoiceStrategies.WEIGHTED_ROUND_ROBIN - ) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy() - ).toBeInstanceOf(DynamicPoolWorkerChoiceStrategy) + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ).isDynamicPool + ).toBe(true) + workerChoiceStrategyContext.setWorkerChoiceStrategy(workerChoiceStrategy) expect( - workerChoiceStrategyContext.getWorkerChoiceStrategy().workerChoiceStrategy + workerChoiceStrategyContext.workerChoiceStrategies.get( + workerChoiceStrategy + ) ).toBeInstanceOf(WeightedRoundRobinWorkerChoiceStrategy) + expect(workerChoiceStrategyContext.workerChoiceStrategy).toBe( + workerChoiceStrategy + ) }) })