X-Git-Url: https://git.piment-noir.org/?a=blobdiff_plain;f=tests%2Fworker%2Fabstract-worker.test.js;h=1b055217b3e6405b59bf492980e578b1c600ef78;hb=84a043a28a08e9d50af78a98250fe7ccfecb3b65;hp=0a920dd594f0e4e0578d35ce8ae25c1919820a85;hpb=6cd5248f7b289828220cac63f8fe77d021c572e9;p=poolifier.git diff --git a/tests/worker/abstract-worker.test.js b/tests/worker/abstract-worker.test.js index 0a920dd5..1b055217 100644 --- a/tests/worker/abstract-worker.test.js +++ b/tests/worker/abstract-worker.test.js @@ -7,7 +7,7 @@ describe('Abstract worker test suite', () => { class StubWorkerWithMainWorker extends ThreadWorker { constructor (fn, opts) { super(fn, opts) - this.mainWorker = undefined + delete this.mainWorker } } @@ -17,10 +17,52 @@ describe('Abstract worker test suite', () => { it('Verify worker options default values', () => { const worker = new ThreadWorker(() => {}) - expect(worker.opts.maxInactiveTime).toStrictEqual(60000) - expect(worker.opts.killBehavior).toBe(KillBehaviors.SOFT) - expect(worker.opts.killHandler).toStrictEqual(EMPTY_FUNCTION) - expect(worker.opts.async).toBe(undefined) + expect(worker.opts).toStrictEqual({ + killBehavior: KillBehaviors.SOFT, + maxInactiveTime: 60000, + killHandler: EMPTY_FUNCTION + }) + }) + + it('Verify that worker options are checked at worker creation', () => { + expect(() => new ClusterWorker(() => {}, '')).toThrowError( + new TypeError('opts worker options parameter is not a plain object') + ) + expect( + () => new ClusterWorker(() => {}, { killBehavior: '' }) + ).toThrowError(new TypeError("killBehavior option '' is not valid")) + expect(() => new ClusterWorker(() => {}, { killBehavior: 0 })).toThrowError( + new TypeError("killBehavior option '0' is not valid") + ) + expect( + () => new ThreadWorker(() => {}, { maxInactiveTime: '' }) + ).toThrowError(new TypeError('maxInactiveTime option is not an integer')) + expect( + () => new ThreadWorker(() => {}, { maxInactiveTime: 0.5 }) + ).toThrowError(new TypeError('maxInactiveTime option is not an integer')) + expect( + () => new ThreadWorker(() => {}, { maxInactiveTime: 0 }) + ).toThrowError( + new TypeError( + 'maxInactiveTime option is not a positive integer greater or equal than 5' + ) + ) + expect( + () => new ThreadWorker(() => {}, { maxInactiveTime: 4 }) + ).toThrowError( + new TypeError( + 'maxInactiveTime option is not a positive integer greater or equal than 5' + ) + ) + expect(() => new ThreadWorker(() => {}, { killHandler: '' })).toThrowError( + new TypeError('killHandler option is not a function') + ) + expect(() => new ThreadWorker(() => {}, { killHandler: 0 })).toThrowError( + new TypeError('killHandler option is not a function') + ) + expect(() => new ThreadWorker(() => {}, { async: true })).toThrowError( + new TypeError('async option is deprecated') + ) }) it('Verify that worker options are set at worker creation', () => { @@ -28,20 +70,20 @@ describe('Abstract worker test suite', () => { console.info('Worker received kill message') } const worker = new ClusterWorker(() => {}, { + killBehavior: KillBehaviors.HARD, maxInactiveTime: 6000, + killHandler + }) + expect(worker.opts).toStrictEqual({ killBehavior: KillBehaviors.HARD, - killHandler, - async: true + maxInactiveTime: 6000, + killHandler }) - expect(worker.opts.maxInactiveTime).toStrictEqual(6000) - expect(worker.opts.killBehavior).toBe(KillBehaviors.HARD) - expect(worker.opts.killHandler).toStrictEqual(killHandler) - expect(worker.opts.async).toBe(undefined) }) it('Verify that taskFunctions parameter is mandatory', () => { expect(() => new ClusterWorker()).toThrowError( - 'taskFunctions parameter is mandatory' + new Error('taskFunctions parameter is mandatory') ) }) @@ -158,7 +200,7 @@ describe('Abstract worker test suite', () => { expect(killHandlerStub.calledOnce).toBe(true) }) - it('Verify that handleError() method works properly', () => { + it('Verify that handleError() method is working properly', () => { const error = new Error('Error as an error') const worker = new ClusterWorker(() => {}) expect(worker.handleError(error)).not.toBeInstanceOf(Error) @@ -173,7 +215,7 @@ describe('Abstract worker test suite', () => { ).toThrowError('Main worker not set') }) - it('Verify that hasTaskFunction() works', () => { + it('Verify that hasTaskFunction() is working', () => { const fn1 = () => { return 1 } @@ -181,19 +223,23 @@ describe('Abstract worker test suite', () => { return 2 } const worker = new ClusterWorker({ fn1, fn2 }) - expect(() => worker.hasTaskFunction(0)).toThrowError( - new TypeError('name parameter is not a string') - ) - expect(() => worker.hasTaskFunction('')).toThrowError( - new TypeError('name parameter is an empty string') - ) - expect(worker.hasTaskFunction(DEFAULT_TASK_NAME)).toBe(true) - expect(worker.hasTaskFunction('fn1')).toBe(true) - expect(worker.hasTaskFunction('fn2')).toBe(true) - expect(worker.hasTaskFunction('fn3')).toBe(false) + expect(worker.hasTaskFunction(0)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is not a string') + }) + expect(worker.hasTaskFunction('')).toStrictEqual({ + status: false, + error: new TypeError('name parameter is an empty string') + }) + expect(worker.hasTaskFunction(DEFAULT_TASK_NAME)).toStrictEqual({ + status: true + }) + expect(worker.hasTaskFunction('fn1')).toStrictEqual({ status: true }) + expect(worker.hasTaskFunction('fn2')).toStrictEqual({ status: true }) + expect(worker.hasTaskFunction('fn3')).toStrictEqual({ status: false }) }) - it('Verify that addTaskFunction() works', () => { + it('Verify that addTaskFunction() is working', () => { const fn1 = () => { return 1 } @@ -204,24 +250,30 @@ describe('Abstract worker test suite', () => { return 3 } const worker = new ThreadWorker(fn1) - expect(() => worker.addTaskFunction(0, fn1)).toThrowError( - new TypeError('name parameter is not a string') - ) - expect(() => worker.addTaskFunction('', fn1)).toThrowError( - new TypeError('name parameter is an empty string') - ) - expect(() => worker.addTaskFunction('fn3', '')).toThrowError( - new TypeError('fn parameter is not a function') - ) + expect(worker.addTaskFunction(0, fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is not a string') + }) + expect(worker.addTaskFunction('', fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is an empty string') + }) + expect(worker.addTaskFunction('fn3', '')).toStrictEqual({ + status: false, + error: new TypeError('fn parameter is not a function') + }) expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function) expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function) expect(worker.taskFunctions.size).toBe(2) expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual( worker.taskFunctions.get('fn1') ) - expect(() => worker.addTaskFunction(DEFAULT_TASK_NAME, fn2)).toThrowError( - new Error('Cannot add a task function with the default reserved name') - ) + expect(worker.addTaskFunction(DEFAULT_TASK_NAME, fn2)).toStrictEqual({ + status: false, + error: new Error( + 'Cannot add a task function with the default reserved name' + ) + }) worker.addTaskFunction('fn2', fn2) expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function) expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function) @@ -240,7 +292,7 @@ describe('Abstract worker test suite', () => { ) }) - it('Verify that removeTaskFunction() works', () => { + it('Verify that removeTaskFunction() is working', () => { const fn1 = () => { return 1 } @@ -248,12 +300,14 @@ describe('Abstract worker test suite', () => { return 2 } const worker = new ClusterWorker({ fn1, fn2 }) - expect(() => worker.removeTaskFunction(0, fn1)).toThrowError( - new TypeError('name parameter is not a string') - ) - expect(() => worker.removeTaskFunction('', fn1)).toThrowError( - new TypeError('name parameter is an empty string') - ) + expect(worker.removeTaskFunction(0, fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is not a string') + }) + expect(worker.removeTaskFunction('', fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is an empty string') + }) worker.getMainWorker = sinon.stub().returns({ id: 1, send: sinon.stub().returns() @@ -265,16 +319,18 @@ describe('Abstract worker test suite', () => { expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual( worker.taskFunctions.get('fn1') ) - expect(() => worker.removeTaskFunction(DEFAULT_TASK_NAME)).toThrowError( - new Error( + expect(worker.removeTaskFunction(DEFAULT_TASK_NAME)).toStrictEqual({ + status: false, + error: new Error( 'Cannot remove the task function with the default reserved name' ) - ) - expect(() => worker.removeTaskFunction('fn1')).toThrowError( - new Error( + }) + expect(worker.removeTaskFunction('fn1')).toStrictEqual({ + status: false, + error: new Error( 'Cannot remove the task function used as the default task function' ) - ) + }) worker.removeTaskFunction('fn2') expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function) expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function) @@ -283,7 +339,7 @@ describe('Abstract worker test suite', () => { expect(worker.getMainWorker().send.calledOnce).toBe(true) }) - it('Verify that listTaskFunctions() works', () => { + it('Verify that listTaskFunctionNames() is working', () => { const fn1 = () => { return 1 } @@ -291,14 +347,14 @@ describe('Abstract worker test suite', () => { return 2 } const worker = new ClusterWorker({ fn1, fn2 }) - expect(worker.listTaskFunctions()).toStrictEqual([ + expect(worker.listTaskFunctionNames()).toStrictEqual([ DEFAULT_TASK_NAME, 'fn1', 'fn2' ]) }) - it('Verify that setDefaultTaskFunction() works', () => { + it('Verify that setDefaultTaskFunction() is working', () => { const fn1 = () => { return 1 } @@ -306,12 +362,14 @@ describe('Abstract worker test suite', () => { return 2 } const worker = new ThreadWorker({ fn1, fn2 }) - expect(() => worker.setDefaultTaskFunction(0, fn1)).toThrowError( - new TypeError('name parameter is not a string') - ) - expect(() => worker.setDefaultTaskFunction('', fn1)).toThrowError( - new TypeError('name parameter is an empty string') - ) + expect(worker.setDefaultTaskFunction(0, fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is not a string') + }) + expect(worker.setDefaultTaskFunction('', fn1)).toStrictEqual({ + status: false, + error: new TypeError('name parameter is an empty string') + }) expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toBeInstanceOf(Function) expect(worker.taskFunctions.get('fn1')).toBeInstanceOf(Function) expect(worker.taskFunctions.get('fn2')).toBeInstanceOf(Function) @@ -319,16 +377,18 @@ describe('Abstract worker test suite', () => { expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual( worker.taskFunctions.get('fn1') ) - expect(() => worker.setDefaultTaskFunction(DEFAULT_TASK_NAME)).toThrowError( - new Error( + expect(worker.setDefaultTaskFunction(DEFAULT_TASK_NAME)).toStrictEqual({ + status: false, + error: new Error( 'Cannot set the default task function reserved name as the default task function' ) - ) - expect(() => worker.setDefaultTaskFunction('fn3')).toThrowError( - new Error( + }) + expect(worker.setDefaultTaskFunction('fn3')).toStrictEqual({ + status: false, + error: new Error( 'Cannot set the default task function to a non-existing task function' ) - ) + }) worker.setDefaultTaskFunction('fn1') expect(worker.taskFunctions.get(DEFAULT_TASK_NAME)).toStrictEqual( worker.taskFunctions.get('fn1')