]> Piment Noir Git Repositories - e-mobility-charging-stations-simulator.git/commit
refactor(sandcastle): generalize actor/critic loop with LoopContext and coherent API
authorJérôme Benoit <jerome.benoit@sap.com>
Thu, 7 May 2026 08:25:26 +0000 (10:25 +0200)
committerJérôme Benoit <jerome.benoit@sap.com>
Thu, 7 May 2026 08:25:26 +0000 (10:25 +0200)
commit16acd0da8c4ddf3f954f7fdafe5d39762de81b8c
treeb6c5982c3ab6e389bd579c8a56fdc3ec7810ed78
parent2d7683c76ecb65067f3b8a13417b9279f3657733
refactor(sandcastle): generalize actor/critic loop with LoopContext and coherent API

- Introduce LoopContext to group invariant params (spec, sandbox, strategy, baseBranch, signal)
- Extract GIT_BASE_BRANCH constant, thread through loop + finalization + prompts
- Rename 'implementer' to 'actor' in generic loop code
- Add extensibility: validate?, actorModel?, criticModel? on LoopStrategy
- Add baseBranch to RefinementLoopOptions and LoopResult
- Make Finding.category extensible (z.string())
- Make TaskSpec.labels optional
- Fix param ordering: pushBranch(spec, cwd, ...), deduplicateFindings(findings, cwd, ...)
- Simplify root lint-staged to cover all TS files
.sandcastle/constants.ts
.sandcastle/finalizer.ts
.sandcastle/refinement-loop.ts
.sandcastle/strategies/implement/critic-prompt.md
.sandcastle/strategies/implement/strategy.ts
.sandcastle/types.ts