]> Piment Noir Git Repositories - deb_libnfs.git/commit
repositories / deb_libnfs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e4a5ba4) | patch
Add a very subtle bug in nfs_set_error()
authorRonnie Sahlberg <ronniesahlberg@gmail.com>
Tue, 21 Jun 2011 08:33:50 +0000 (18:33 +1000)
committerRonnie Sahlberg <ronniesahlberg@gmail.com>
Tue, 21 Jun 2011 08:33:50 +0000 (18:33 +1000)
commit1e8994af0fde29bb03c52c5c4a972ef8d8ddbc33
tree73ee1165d110980b3eb74164f9ced5acae924234tree | snapshot (zip tar.gz tar.bz2)
parente4a5ba42b8212574a6c75ac518e7b3be6e619a5bcommit | diff
Add a very subtle bug in nfs_set_error()
when nfs_set_error is called with error_string being the result of a lower layer
problem so it is passed as "rpc_get_error()"

This meant that since free that nfs->rpc->error_string before we reference it a few lines further down in the vasprintf(..., error_string,
adn memory corruption triggers.

Valgrind found this, Valgrind rules!
examples/nfsclient-sync.c diff | blob | blame | history
lib/libnfs.c diff | blob | blame | history
libnfs Piment Noir Debian package repository