]> Piment Noir Git Repositories - e-mobility-charging-stations-simulator.git/commit
refactor(cli): complete remaining audit items — validate status, extract helpers...
authorJérôme Benoit <jerome.benoit@sap.com>
Wed, 15 Apr 2026 19:50:17 +0000 (21:50 +0200)
committerJérôme Benoit <jerome.benoit@sap.com>
Wed, 15 Apr 2026 19:51:07 +0000 (21:51 +0200)
commit84444f7c7efc01a367eea680d37c1657bde56bd1
treedc0b5018eb6bc96fa7634bbeabd77282561eddc5
parenteeeb43740e3f30fd341a687019ba6606398467f7
refactor(cli): complete remaining audit items — validate status, extract helpers, add 8 test cases

- Fix #28: Validate ResponsePayload status is string before cast in handleMessage()
- Fix #43: Extract settleHandler() private method to reduce duplication
- Fix #41: Normalize createMockWS → createMockWs for consistency
- Fix #39: Extract captureStream() parameterized helper to replace captureStdout/captureStderr
- Fix #47: Filter empty arrays in displayGenericPayload to avoid spurious output
- Test #21-#22: Add ConnectionError edge cases (empty cause, non-Error cause)
- Test #23: Add ServerFailureError without hashIdsFailed
- Test #24: Add post-connect onerror rejection test
- Test #25: Add displayGenericPayload failure path test
- Test #26: Add NaN and Infinity timeout validation tests

All tests pass, zero lint warnings.
ui/cli/src/output/table.ts
ui/cli/tests/lifecycle.test.ts
ui/cli/tests/output.test.ts
ui/common/src/client/WebSocketClient.ts
ui/common/tests/WebSocketClient.test.ts