refactor: add SimulateSignatureVerificationFailure to OCPP20VendorVariableName enum

Replace string literal with enum reference in OCPP20VariableRegistry
and OCPP20IncomingRequestService for type safety and consistency with
CertificatePrivateKey and ConnectionUrl vendor variables.

diff --git a/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts b/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
index d11e88f35b866507f541cd998fae148946de17b7..ea2ad85c00b2885610513208d0a092878187594f 100644 (file)
--- a/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
+++ b/src/charging-station/ocpp/2.0/OCPP20IncomingRequestService.ts
@@ -106,6 +106,7 @@ import {
   type OCPP20UnlockConnectorResponse,
   type OCPP20UpdateFirmwareRequest,
   type OCPP20UpdateFirmwareResponse,
+  OCPP20VendorVariableName,
   OCPPVersion,
   ReasonCodeEnumType,
   RegistrationStatusEnumType,
@@ -3496,7 +3497,9 @@ export class OCPP20IncomingRequestService extends OCPPIncomingRequestService {
         {
           attributeType: AttributeEnumType.Actual,
           component: { name: OCPP20ComponentName.FirmwareCtrlr as string },
-          variable: { name: 'SimulateSignatureVerificationFailure' },
+          variable: {
+            name: OCPP20VendorVariableName.SimulateSignatureVerificationFailure as string,
+          },
         },
       ])
       const simulateFailure = convertToBoolean(verificationResults[0]?.attributeValue)

diff --git a/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts b/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
index e9215789c18c9123662991605ed7ce6448eacecb..ee8c06b5381fdb5044c6dbf2ad2575510b0cb4a3 100644 (file)
--- a/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
+++ b/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
@@ -984,7 +984,10 @@ export const VARIABLE_REGISTRY: Record<string, VariableMetadata> = {
   },
 
   // FirmwareCtrlr Component
-  [buildRegistryKey(OCPP20ComponentName.FirmwareCtrlr, 'SimulateSignatureVerificationFailure')]: {
+  [buildRegistryKey(
+    OCPP20ComponentName.FirmwareCtrlr,
+    OCPP20VendorVariableName.SimulateSignatureVerificationFailure
+  )]: {
     component: OCPP20ComponentName.FirmwareCtrlr,
     dataType: DataEnumType.boolean,
     defaultValue: 'false',
@@ -993,7 +996,7 @@ export const VARIABLE_REGISTRY: Record<string, VariableMetadata> = {
     mutability: MutabilityEnumType.ReadWrite,
     persistence: PersistenceEnumType.Persistent,
     supportedAttributes: [AttributeEnumType.Actual],
-    variable: 'SimulateSignatureVerificationFailure',
+    variable: OCPP20VendorVariableName.SimulateSignatureVerificationFailure,
     vendorSpecific: true,
   },
 

diff --git a/src/types/ocpp/2.0/Variables.ts b/src/types/ocpp/2.0/Variables.ts
index 7a4360e55e64c4e63c81ce0672518420ba5f21dc..b7ab72aa13a595d9a254c02d79d887f651e1a361 100644 (file)
--- a/src/types/ocpp/2.0/Variables.ts
+++ b/src/types/ocpp/2.0/Variables.ts
@@ -80,6 +80,7 @@ export enum OCPP20RequiredVariableName {
 export enum OCPP20VendorVariableName {
   CertificatePrivateKey = 'CertificatePrivateKey',
   ConnectionUrl = 'ConnectionUrl',
+  SimulateSignatureVerificationFailure = 'SimulateSignatureVerificationFailure',
 }
 
 export enum PersistenceEnumType {