refactor: extract normalized boolean variable in validation checks

diff --git a/src/charging-station/ocpp/2.0/OCPP20VariableManager.ts b/src/charging-station/ocpp/2.0/OCPP20VariableManager.ts
index 4a34b59f949fd1d04c60b7d9815b031d9cfc5266..f1410a3dc1b7f40af7b9044a7324618148cdd1ee 100644 (file)
--- a/src/charging-station/ocpp/2.0/OCPP20VariableManager.ts
+++ b/src/charging-station/ocpp/2.0/OCPP20VariableManager.ts
@@ -937,7 +937,8 @@ export class OCPP20VariableManager {
       isOCPP20RequiredVariableName(variable.name) &&
       variable.name === OCPP20RequiredVariableName.AuthorizeRemoteStart
     ) {
-      if (attributeValue.toLowerCase() !== 'true' && attributeValue.toLowerCase() !== 'false') {
+      const normalizedValue = attributeValue.toLowerCase()
+      if (normalizedValue !== 'true' && normalizedValue !== 'false') {
         return this.rejectSet(
           variable,
           component,

diff --git a/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts b/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
index edfaeaa3d4cc64334cbc3a2f6d49e2341311fded..7251234f832e7c67ec6b2618a5d7b10d58c2f02b 100644 (file)
--- a/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
+++ b/src/charging-station/ocpp/2.0/OCPP20VariableRegistry.ts
@@ -2499,7 +2499,8 @@ export function validateValue (
   }
   switch (variableMetadata.dataType) {
     case DataEnumType.boolean: {
-      if (rawValue.toLowerCase() !== 'true' && rawValue.toLowerCase() !== 'false') {
+      const normalizedValue = rawValue.toLowerCase()
+      if (normalizedValue !== 'true' && normalizedValue !== 'false') {
         return {
           info: 'Boolean must be "true" or "false"',
           ok: false,