]> Piment Noir Git Repositories - freqai-strategies.git/commitdiff
refactor(qav3): cleanup new features namespace
authorJérôme Benoit <jerome.benoit@piment-noir.org>
Mon, 24 Mar 2025 14:53:09 +0000 (15:53 +0100)
committerJérôme Benoit <jerome.benoit@piment-noir.org>
Mon, 24 Mar 2025 14:53:09 +0000 (15:53 +0100)
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
quickadapter/user_data/strategies/QuickAdapterV3.py

index 14b564b78f9ce74536358a61c594b62eed7aebc6..0d6b77d1d51381ecdb16d752ed01c8f783af412e 100644 (file)
@@ -209,19 +209,15 @@ class QuickAdapterV3(IStrategy):
             dataframe["close"],
             length=period,
         )
-        dataframe["%-linearreg-angle-period"] = ta.LINEARREG_ANGLE(
+        dataframe["%-linearreg_angle-period"] = ta.LINEARREG_ANGLE(
             dataframe, timeperiod=period
         )
-        # dataframe["%-linearreg_angle-period"] = ta.LINEARREG_ANGLE(
-        #     dataframe, timeperiod=period
-        # )
         dataframe["%-atr-period"] = ta.ATR(dataframe, timeperiod=period)
         dataframe["%-natr-period"] = ta.NATR(dataframe, timeperiod=period)
         return dataframe
 
     def feature_engineering_expand_basic(self, dataframe, **kwargs):
-        dataframe["%-pct-change"] = dataframe["close"].pct_change()
-        # dataframe["%-close_pct_change"] = dataframe["close"].pct_change()
+        dataframe["%-close_pct_change"] = dataframe["close"].pct_change()
         dataframe["%-raw_volume"] = dataframe["volume"]
         dataframe["%-obv"] = ta.OBV(dataframe)
         dataframe["%-ewo"] = ewo(
@@ -263,7 +259,7 @@ class QuickAdapterV3(IStrategy):
             non_zero_range(dataframe["high"], dataframe["low"])
         )
         dataframe["jaw"], dataframe["teeth"], dataframe["lips"] = alligator(
-            dataframe, mamode="ema", zero_lag=True
+            dataframe, zero_lag=True
         )
         dataframe["%-dist_to_jaw"] = get_distance(dataframe["close"], dataframe["jaw"])
         dataframe["%-dist_to_teeth"] = get_distance(