]> Piment Noir Git Repositories - freqai-strategies.git/commitdiff
fix(qav3): properly handle sqlite storage
authorJérôme Benoit <jerome.benoit@sap.com>
Wed, 19 Feb 2025 15:02:26 +0000 (16:02 +0100)
committerJérôme Benoit <jerome.benoit@sap.com>
Wed, 19 Feb 2025 15:02:26 +0000 (16:02 +0100)
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py

index ccf5a2b64d8d3d4eeb9f545a096df0f20db7d5e8..3f5446eb7c7e591233142c1b23ca36a5fce1e0db 100644 (file)
@@ -250,7 +250,6 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         storage_backend = self.__optuna_config.get("storage", "file")
         if storage_backend == "sqlite":
             storage = f"sqlite:///{storage_dir}/optuna-{dk.pair.split('/')[0]}.sqlite"
-            logging.info(f"Optuna storage: {storage}")
         elif storage_backend == "file":
             storage = optuna.storages.JournalStorage(
                 optuna.storages.journal.JournalFileBackend(
@@ -464,8 +463,12 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         try:
             _ = study.best_params
             return True
+        # file backend storage raises KeyError
         except KeyError:
             return False
+        # sqlite backend storage raises ValueError
+        except ValueError:
+            return False
 
 
 def log_sum_exp_min_max_pred(
index c559cb82dabf4d376b0edc383196523de8d486c4..fde58ccea8a82761625f19cdc5469c5d760de4cc 100644 (file)
@@ -464,8 +464,12 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         try:
             _ = study.best_params
             return True
+        # file backend storage raises KeyError
         except KeyError:
             return False
+        # sqlite backend storage raises ValueError
+        except ValueError:
+            return False
 
 
 def log_sum_exp_min_max_pred(