refactor(qav3): code cleanups

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
index a6b7c1b332273435205ba2bc900129e108887b34..5cde824a17d6a3f4038b4310aa8e11ea2b205c17 100644 (file)
--- a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
+++ b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
@@ -1371,10 +1371,10 @@ def zigzag(
             pos - candidate_pivot_pos
         )
 
-        if direction == TrendDirection.DOWN:
-            slope_ok_cache[cache_key] = log_slope_close < -min_slope
-        elif direction == TrendDirection.UP:
+        if direction == TrendDirection.UP:
             slope_ok_cache[cache_key] = log_slope_close > min_slope
+        elif direction == TrendDirection.DOWN:
+            slope_ok_cache[cache_key] = log_slope_close < -min_slope
         else:
             slope_ok_cache[cache_key] = False
 

diff --git a/quickadapter/user_data/strategies/Utils.py b/quickadapter/user_data/strategies/Utils.py
index 65435645ccec38de7db7dad0a75c729b41c899a1..0afca65ce3f74ebd935d001fac95b21ac0e77f80 100644 (file)
--- a/quickadapter/user_data/strategies/Utils.py
+++ b/quickadapter/user_data/strategies/Utils.py
@@ -500,10 +500,10 @@ def zigzag(
             pos - candidate_pivot_pos
         )
 
-        if direction == TrendDirection.DOWN:
-            slope_ok_cache[cache_key] = log_slope_close < -min_slope
-        elif direction == TrendDirection.UP:
+        if direction == TrendDirection.UP:
             slope_ok_cache[cache_key] = log_slope_close > min_slope
+        elif direction == TrendDirection.DOWN:
+            slope_ok_cache[cache_key] = log_slope_close < -min_slope
         else:
             slope_ok_cache[cache_key] = False