Revert incorrect isEmptyString() semantic change

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>

diff --git a/src/utils/Utils.ts b/src/utils/Utils.ts
index 0952be9bf206a3e8ea83a33fe61f65e723bea37e..6557a588446455506656c7f7133e8fe85c5881f0 100644 (file)
--- a/src/utils/Utils.ts
+++ b/src/utils/Utils.ts
@@ -193,7 +193,7 @@ export default class Utils {
   }
 
   public static isEmptyString(value: unknown): boolean {
-    return Utils.isString(value) ? (value as string).trim().length === 0 : true;
+    return Utils.isString(value) && (value as string).trim().length === 0;
   }
 
   public static isUndefined(value: unknown): boolean {

diff --git a/test/utils/UtilsTest.ts b/test/utils/UtilsTest.ts
index a3166aed856927d9d577642ae17d5ad4f10e64f1..21d5d1376a7bbd3ccd0daf8390ac36f5897a2c4c 100644 (file)
--- a/test/utils/UtilsTest.ts
+++ b/test/utils/UtilsTest.ts
@@ -161,15 +161,15 @@ describe('Utils test suite', () => {
     expect(Utils.isEmptyString('test')).toBe(false);
     expect(Utils.isEmptyString(' test')).toBe(false);
     expect(Utils.isEmptyString('test ')).toBe(false);
-    expect(Utils.isEmptyString(null)).toBe(true);
-    expect(Utils.isEmptyString(undefined)).toBe(true);
-    expect(Utils.isEmptyString(0)).toBe(true);
-    expect(Utils.isEmptyString({})).toBe(true);
-    expect(Utils.isEmptyString([])).toBe(true);
-    expect(Utils.isEmptyString(new Map())).toBe(true);
-    expect(Utils.isEmptyString(new Set())).toBe(true);
-    expect(Utils.isEmptyString(new WeakMap())).toBe(true);
-    expect(Utils.isEmptyString(new WeakSet())).toBe(true);
+    expect(Utils.isEmptyString(null)).toBe(false);
+    expect(Utils.isEmptyString(undefined)).toBe(false);
+    expect(Utils.isEmptyString(0)).toBe(false);
+    expect(Utils.isEmptyString({})).toBe(false);
+    expect(Utils.isEmptyString([])).toBe(false);
+    expect(Utils.isEmptyString(new Map())).toBe(false);
+    expect(Utils.isEmptyString(new Set())).toBe(false);
+    expect(Utils.isEmptyString(new WeakMap())).toBe(false);
+    expect(Utils.isEmptyString(new WeakSet())).toBe(false);
   });
 
   it('Verify isUndefined()', () => {