fix(qav3): brown paper bag bug in optuna_study_has_best_params()

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
index 543856610d9a7805603dd55d39356532bcf80eea..69d50fbbf518fdf02f38028553bcda2146d1952e 100644 (file)
--- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py
@@ -407,7 +407,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            _ = study.trials
+            _ = study.best_params
+            return True
         except KeyError:
             return False
 

diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
index 7038dffddfcb410cbc85f6c122d317f617ec6dbf..cdc6dce0e07b5b9580d68e40089405e8964ebc54 100644 (file)
--- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
+++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py
@@ -408,7 +408,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel):
         if not study:
             return False
         try:
-            _ = study.trials
+            _ = study.best_params
+            return True
         except KeyError:
             return False